From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1995C49EA6 for ; Thu, 24 Jun 2021 18:07:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A85ED613F2 for ; Thu, 24 Jun 2021 18:07:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230480AbhFXSJp (ORCPT ); Thu, 24 Jun 2021 14:09:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:47228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbhFXSJo (ORCPT ); Thu, 24 Jun 2021 14:09:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 156DE613C2; Thu, 24 Jun 2021 18:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624558045; bh=pjMUPrrv0IdP4953FNP37zcXZsFA4aLGtJ+obsfpazk=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=neRWxIrqAWWOEkcLHfsWvPPyu8qHYf6O9+nesgtq1VQP8radZCRQXZ+6VtdUNm3oM Jp1zCSR/ylOCpKO5BlnlUOIO9weCvaYDoXX3gjSTGd8jp1Sa1D98qOuliarKECNB6+ dkHjIORbEU19r8Tu9ljhk7hpIEvvIWVL4ewuBZ/TevsuSdCb22xCwD4RS675vQQmqV vceDnsfcanJD99jLvxstqp93LMtoYINKrJJ+jPhPG53JwJcnx8OiJZmcR8BCVJKJyX R/Ol8oQQwbhgxUsOUYuP7uXFkCyHNCbZd92VHTzEZWd7zXidEx7t7NgzIldikW2ICX KkRRor4L7EWEQ== Date: Thu, 24 Jun 2021 13:07:23 -0500 From: Bjorn Helgaas To: Simon Xue Cc: Bjorn Helgaas , Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, Johan Jonker , Heiko Stuebner , Peter Geis , Kever Yang , Shawn Lin Subject: Re: [PATCH v10] PCI: rockchip: Add Rockchip RK356X host controller driver Message-ID: <20210624180723.GA3543267@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210624021548.447301-1-xxm@rock-chips.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This needs a new driver name. We already have a "rockchip" driver (drivers/pci/controller/pcie-rockchip-host.c) and this one needs a different name that we can use in the subject line and similar places, e.g., something like: PCI: rockchip-dwc: Using "rockchip" for the other driver might have been a mistake. We should probably use something a little more specific for this driver to leave room for Rockchip to produce future hardware that may require a *third* driver. On Thu, Jun 24, 2021 at 10:15:47AM +0800, Simon Xue wrote: > Add a driver for the DesignWare-based PCIe controller found on > RK356X. The existing pcie-rockchip-host driver is only used for > the Rockchip-designed IP found on RK3399.