From: Rob Herring <robh@kernel.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
pali@kernel.org, linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] pinctrl: armada-37xx: Correct PWM pins definitions
Date: Thu, 24 Jun 2021 14:43:27 -0600 [thread overview]
Message-ID: <20210624204327.GA1956119@robh.at.kernel.org> (raw)
In-Reply-To: <20210614222527.11237-1-kabel@kernel.org>
On Tue, 15 Jun 2021 00:25:27 +0200, Marek Behún wrote:
> The PWM pins on North Bridge on Armada 37xx can be configured into PWM
> or GPIO functions. When in PWM function, each pin can also be configured
> to drive low on 0 and tri-state on 1 (LED mode).
>
> The current definitions handle this by declaring two pin groups for each
> pin:
> - group "pwmN" with functions "pwm" and "gpio"
> - group "ledN_od" ("od" for open drain) with functions "led" and "gpio"
>
> This is semantically incorrect. The correct definition for each pin
> should be one group with three functions: "pwm", "led" and "gpio".
>
> Change the "pwmN" groups to support "led" function.
>
> Remove "ledN_od" groups. This cannot break backwards compatibility with
> older device trees: no device tree uses it since there is no PWM driver
> for this SOC yet. Also "ledN_od" groups are not even documented.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> ---
> .../pinctrl/marvell,armada-37xx-pinctrl.txt | 8 ++++----
> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 16 ++++++++--------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2021-06-24 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 22:25 [PATCH] pinctrl: armada-37xx: Correct PWM pins definitions Marek Behún
2021-06-17 9:55 ` Marek Behún
2021-06-24 20:43 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624204327.GA1956119@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kabel@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).