From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33DEC2B9F4 for ; Fri, 25 Jun 2021 07:07:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 912EF6141E for ; Fri, 25 Jun 2021 07:07:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229454AbhFYHJX (ORCPT ); Fri, 25 Jun 2021 03:09:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43761 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbhFYHJW (ORCPT ); Fri, 25 Jun 2021 03:09:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624604821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pbp23JlztCvQMDGSzMZ1vEk44RnDqxHLzKF7l4kjbo8=; b=Ls389CAeVqagYQ2YX4XNeQa3W5YCPbUnT2Uv/HvP8Q/2JjybF5LiWS9h792E4eUGFj62YF jl/O7N1rqBBxmHG65bEMaDvPCoEj2JZNZHODhBZga4kW6nO70yjf7ldJyA6D0Oi42tQPoF 4W0q9d8ESl3Fbx9vQaEcTzqr/3LxXxQ= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-577-9FKwjj1EOFyC48BFnlWBeQ-1; Fri, 25 Jun 2021 03:07:00 -0400 X-MC-Unique: 9FKwjj1EOFyC48BFnlWBeQ-1 Received: by mail-ej1-f70.google.com with SMTP id 16-20020a1709063010b029037417ca2d43so2757106ejz.5 for ; Fri, 25 Jun 2021 00:07:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pbp23JlztCvQMDGSzMZ1vEk44RnDqxHLzKF7l4kjbo8=; b=Fhj4vEElkNl7yCNsS26KhS2y7p5agudcvCzJ59z4xIp4yJvNk6ExQmrLYWoheCLz1B L3d12mhfxgx5PYScOHU9DPR+BlcLDgoVZXGZzdf3bOttCCNOGFTCOzc+Z1U5gnO2a+aD 3XYcIez/9O7DyfeF4BtEoTGGN3YHx3mqt/csIl0KzZ1e2HHMKd5eMxYlFYYVKSv1eehZ nurJ4IYmVs+TVBr6oVZFdahZjPEVRhfXxGyHt/9dD6RmwFSTan1kBNURjP1EwlJWUjDJ MgHidyCMZJ4btPIksmI0z1FRNN+Pu4+SiJIzR5eMCvXrcLpqjWUXsvJXRPgFMrv9avfg 3XaQ== X-Gm-Message-State: AOAM532tdc1WcrQU3BbVanFvQulQd4WxKmVgylIFII1XIvtA40dLYgzi VLm12Zrpz4HrBhTFzpccH3Y0k2Sz9fxasc3G7GhG7raf8LNbeYii1oGwgvHYSkUhNi2niDwi+hn 9ID+fuSSYhkGTLQa74GQQUQ== X-Received: by 2002:a17:906:22c6:: with SMTP id q6mr9248386eja.275.1624604819105; Fri, 25 Jun 2021 00:06:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyaw4UrNydP6rJ+aMKvQTiKfg4uzK7jEe1lT6tuybSH8BIUV+HiOjSEMQXmQAWrdq0eFca0A== X-Received: by 2002:a17:906:22c6:: with SMTP id q6mr9248372eja.275.1624604818971; Fri, 25 Jun 2021 00:06:58 -0700 (PDT) Received: from gator (cst2-174-132.cust.vodafone.cz. [31.30.174.132]) by smtp.gmail.com with ESMTPSA id e28sm3333482edc.24.2021.06.25.00.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 00:06:58 -0700 (PDT) Date: Fri, 25 Jun 2021 09:06:56 +0200 From: Andrew Jones To: Gavin Shan Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rdunlap@infradead.org, robh+dt@kernel.org, shan.gavin@gmail.com Subject: Re: [PATCH v4] Documentation, dt, numa: Add note to empty NUMA node Message-ID: <20210625070656.j373hveemf5cdch4@gator> References: <20210625052338.4875-1-gshan@redhat.com> <20210625070217.4ffmfe7nwlusbbjc@gator> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210625070217.4ffmfe7nwlusbbjc@gator> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jun 25, 2021 at 09:02:17AM +0200, Andrew Jones wrote: > On Fri, Jun 25, 2021 at 01:23:38PM +0800, Gavin Shan wrote: > > The empty memory nodes, where no memory resides in, are allowed. > > For these empty memory nodes, the 'len' of 'reg' property is zero. > > The NUMA node IDs are still valid and parsed, but memory can be > > added to them through hotplug afterwards. I finds difficulty to > > get where it's properly documented. > > > > So lets add note to empty memory nodes in the NUMA binding doc. > > > > Signed-off-by: Gavin Shan > > --- > > Documentation/devicetree/bindings/numa.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt > > index 21b35053ca5a..0fc882e44270 100644 > > --- a/Documentation/devicetree/bindings/numa.txt > > +++ b/Documentation/devicetree/bindings/numa.txt > > @@ -109,6 +109,10 @@ Example: > > Dual socket system consists of 2 boards connected through ccn bus and > > each board having one socket/soc of 8 cpus, memory and pci bus. > > > > +Note that empty memory nodes, which no memory resides in, are allowed. > > +The NUMA node IDs in these empty memory nodes are still valid, but > > +memory can be added into them through hotplug afterwards. > > Please change the second sentence to: > > The NUMA node IDs in these empty memory nodes are still valid and > memory may be added into them through hotplug afterwards. > > But, this doesn't look like the right place for this paragraph. You're > adding the paragraph to the example section, but the example doesn't have > any empty memory nodes. > > I think the paragraph should be added to section "2 - numa-node-id" and an Or maybe even create a new section for it. > example empty memory node should be provided. Also, the commit message > talks about the length of 'reg' being zero, which is an important > distinction which should also be documented. > > Thanks, > drew > > > + > > memory@c00000 { > > device_type = "memory"; > > reg = <0x0 0xc00000 0x0 0x80000000>; > > -- > > 2.23.0 > >