From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5DA9C49EAB for ; Mon, 28 Jun 2021 15:38:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A46FE619A0 for ; Mon, 28 Jun 2021 15:38:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234135AbhF1PlF (ORCPT ); Mon, 28 Jun 2021 11:41:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238304AbhF1Pk2 (ORCPT ); Mon, 28 Jun 2021 11:40:28 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB179C014D9C for ; Mon, 28 Jun 2021 07:49:13 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id y4so14268340pfi.9 for ; Mon, 28 Jun 2021 07:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZSj4RmI8yCcxPcjTe6tWYJqNEZi8NLpBHAPv+jccWGE=; b=czLA0L+OepY2RMRvJPJ1aroh0vH2O14KivrTKKmu5i1pAnrV6c3S55WP8h6B05D4WX E6pjWDifCvl4akBD9x4dHM2Vo1su2nyq01tttiwlKv4c6e7GmGu389sWyaXXkiwamGeg 3wzfJ+HE+qAgxY6841XhFXVy7Z+AIIMt1MUC1AxqnEAyh9GgOYrZmptymgKyqsSTsaHc 2tC/y/zpKtO8kw4mWv9sWsu+pqKGbQE1DZNZt/ZD+WUCgvuUTBIg3SEzNKh25vPUo3p4 nRczpN7UtAASDR3WCrhNJEBB1KbRj7gYf2/UFRuzAHE6A0l8v/G7tfKt1KpTMzJXlKkG cGyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZSj4RmI8yCcxPcjTe6tWYJqNEZi8NLpBHAPv+jccWGE=; b=KeHyOoT4kJbHltzKmjNqplBG08wVq983+bWBR9o1LoI7bzCUtDnx9pCwkrlRO1ap/K mKZNfNCHW1wKZd2O95PwdsCgLLZxw/PCgF7Hj8n5x8ZoBdU7GTPm0cszIzo/X6S52LD2 l1DgQiZaAY5SSWUZgjhZf2eo1kTD8IjvHQvrQfpHt/UDoPW6t27xb0yhm+ktHcD1K1Vc bShU8SQxLjNQIZbD4jvU+DgkQfWVImbTD+J0TR/gsH2seiDc0Y9ge0JXNxHm1lEbvUcC nEZDLtSEBrPk0gF8EKCZN+e66fzpzhLB3O21sZwxm8tOinuHMtXUclxMTzRiNRlF31p8 k8GA== X-Gm-Message-State: AOAM5301lub4ENCgi5byo/O3khHm6hmGBQG3ytZSyCJQJIkprUnIHtAK LiNKvuuxEo5HrUC7wfzl0OxQ X-Google-Smtp-Source: ABdhPJyIdgCHYreL9ynww4hlIDfPkxPBnXApubL+5PLaIZmUXOXxvuyuqjadRqM97SkknpcXwJkS/A== X-Received: by 2002:a63:5302:: with SMTP id h2mr14002169pgb.262.1624891753107; Mon, 28 Jun 2021 07:49:13 -0700 (PDT) Received: from workstation ([120.138.13.225]) by smtp.gmail.com with ESMTPSA id n33sm14670914pgm.55.2021.06.28.07.49.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Jun 2021 07:49:12 -0700 (PDT) Date: Mon, 28 Jun 2021 20:19:08 +0530 From: Manivannan Sadhasivam To: Bjorn Andersson Cc: Andy Gross , Rob Herring , Sibi S , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: soc: qcom: aoss: Convert to YAML Message-ID: <20210628144908.GC4033@workstation> References: <20210625234018.1324681-1-bjorn.andersson@linaro.org> <20210625234018.1324681-3-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210625234018.1324681-3-bjorn.andersson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jun 25, 2021 at 04:40:17PM -0700, Bjorn Andersson wrote: > Convert to YAML in order to allow validation. > > Signed-off-by: Bjorn Andersson > --- > > I'm aware that this conflicts with Sibi's removal of '#power-domain-cells', but > that's a trivial change regardless of which of the two patches gets in first. > > .../bindings/soc/qcom/qcom,aoss-qmp.txt | 90 -------------- > .../bindings/soc/qcom/qcom,aoss-qmp.yaml | 115 ++++++++++++++++++ > 2 files changed, 115 insertions(+), 90 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml > [...] > +required: > + - compatible > + - reg > + - interrupts > + - mboxes > + - "#clock-cells" The old binding lists this property as optional but you're marking it as required. And by looking at the driver it seems to be optional only. > + - "#power-domain-cells" This one was marked optional as well but the driver registers the pd's unconditionally, so I guess it is fine. Thanks, Mani > + > +additionalProperties: false > + > +patternProperties: > + "^(cx|mx|ebi)$": > + type: object > + description: > + The AOSS side channel also provides the controls for three cooling devices, > + these are expressed as subnodes of the QMP node. The name of the node is > + used to identify the resource and must therefor be "cx", "mx" or "ebi". > + > + properties: > + "#cooling-cells": > + const: 2 > + > + required: > + - "#cooling-cells" > + > + additionalProperties: false > + > +examples: > + - | > + #include > + > + aoss_qmp: qmp@c300000 { > + compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp"; > + reg = <0x0c300000 0x100000>; > + interrupts = ; > + mboxes = <&apss_shared 0>; > + > + #clock-cells = <0>; > + #power-domain-cells = <1>; > + > + cx_cdev: cx { > + #cooling-cells = <2>; > + }; > + > + mx_cdev: mx { > + #cooling-cells = <2>; > + }; > + }; > +... > -- > 2.29.2 >