Re: [PATCH 3/4] ARM: dts: am335x-sancloud-bbe-lite: New devicetree

[Paul Barker <paul.barker@sancloud.com>]

[-- Attachment #1: Type: text/plain, Size: 3606 bytes --]

On Fri, 18 Jun 2021 11:02:12 -0500
Robert Nelson <robertcnelson@gmail.com> wrote:

> Hi Paul,
> 
> On Thu, Jun 17, 2021 at 4:35 AM Paul Barker
> <paul.barker@sancloud.com> wrote:
> >
> > This adds support for the Sancloud BBE Lite which shares a common
> > hardware base with the non-Lite version of the BBE.
> >
> > Signed-off-by: Paul Barker <paul.barker@sancloud.com>
> > ---
> >  arch/arm/boot/dts/Makefile                    |  1 +
> >  .../arm/boot/dts/am335x-sancloud-bbe-lite.dts | 51
> > +++++++++++++++++++ 2 files changed, 52 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/am335x-sancloud-bbe-lite.dts
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index f8f09c5066e7..8629c941f573 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -834,6 +834,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \
> >         am335x-pocketbeagle.dtb \
> >         am335x-regor-rdk.dtb \
> >         am335x-sancloud-bbe.dtb \
> > +       am335x-sancloud-bbe-lite.dtb \
> >         am335x-shc.dtb \
> >         am335x-sbc-t335.dtb \
> >         am335x-sl50.dtb \
> > diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe-lite.dts
> > b/arch/arm/boot/dts/am335x-sancloud-bbe-lite.dts new file mode
> > 100644 index 000000000000..9c311bd106f6
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/am335x-sancloud-bbe-lite.dts
> > @@ -0,0 +1,51 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (C) 2012 Texas Instruments Incorporated -
> > http://www.ti.com/
> > + * Copyright (C) 2021 SanCloud Ltd
> > + */
> > +/dts-v1/;
> > +
> > +#include "am33xx.dtsi"
> > +#include "am335x-bone-common.dtsi"
> > +#include "am335x-boneblack-common.dtsi"
> > +#include "am335x-sancloud-bbe-common.dtsi"
> > +
> > +/ {
> > +       model = "SanCloud BeagleBone Enhanced Lite";
> > +       compatible = "sancloud,am335x-boneenhanced",
> > +                    "ti,am335x-bone-black",
> > +                    "ti,am335x-bone",
> > +                    "ti,am33xx";
> > +};
> > +
> > +&am33xx_pinmux {
> > +       bb_spi0_pins: pinmux_bb_spi0_pins {
> > +               pinctrl-single,pins = <
> > +                       AM33XX_PADCONF(AM335X_PIN_SPI0_SCLK,
> > PIN_INPUT, MUX_MODE0)
> > +                       AM33XX_PADCONF(AM335X_PIN_SPI0_D0,
> > PIN_INPUT, MUX_MODE0)
> > +                       AM33XX_PADCONF(AM335X_PIN_SPI0_D1,
> > PIN_INPUT, MUX_MODE0)
> > +                       AM33XX_PADCONF(AM335X_PIN_SPI0_CS0,
> > PIN_INPUT, MUX_MODE0)
> > +               >;
> > +       };
> > +};
> > +
> > +&spi0 {
> > +       #address-cells = <1>;
> > +       #size-cells = <0>;
> > +
> > +       status = "okay";
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&bb_spi0_pins>;
> > +
> > +       channel@0 {
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +
> > +               compatible = "micron,spi-authenta";
> > +               symlink = "spi/0.0";  
> 
> Sorry, this "symlink" is an undocumented "feature" of the
> BeagleBoard.org tree.. We use it to help "identity" spi/usart/i2c
> nodes names when they dynamically change node numbers based on kernel
> versions or even 'drivers'....
> 
> https://github.com/beagleboard/customizations/blob/master/etc/udev/rules.d/10-of-symlink.rules
> 
> For 'mainline' we need to remove it..

Ok, that's a straightforward change. I'll send an updated patch series
later in the week.

Thanks,

-- 
Paul Barker
Principal Software Engineer
SanCloud Ltd

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]