Re: [PATCH v2 2/2] media: rc: introduce Meson IR blaster driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4505 bytes --]

Hi Viktor,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.13 next-20210707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Viktor-Prutyanov/media-rc-add-support-for-Amlogic-Meson-IR-blaster/20210707-221429
base:   git://linuxtv.org/media_tree.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/42877697e4d06c6c44aa04f0ee1936579cbbc47c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Viktor-Prutyanov/media-rc-add-support-for-Amlogic-Meson-IR-blaster/20210707-221429
        git checkout 42877697e4d06c6c44aa04f0ee1936579cbbc47c
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/media/rc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/printk.h:409,
                    from include/linux/kernel.h:17,
                    from include/linux/list.h:9,
                    from include/linux/rculist.h:10,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from drivers/media/rc/meson-irblaster.c:23:
   drivers/media/rc/meson-irblaster.c: In function 'irb_send':
>> drivers/media/rc/meson-irblaster.c:218:56: error: 'len' undeclared (first use in this function)
     218 |  dev_dbg(irb->dev, "tx started, buffer length = %u\n", len);
         |                                                        ^~~
   include/linux/dynamic_debug.h:134:15: note: in definition of macro '__dynamic_func_call'
     134 |   func(&id, ##__VA_ARGS__);  \
         |               ^~~~~~~~~~~
   include/linux/dynamic_debug.h:166:2: note: in expansion of macro '_dynamic_func_call'
     166 |  _dynamic_func_call(fmt,__dynamic_dev_dbg,   \
         |  ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
     123 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |  ^~~~~~~~~~~~~~~
   drivers/media/rc/meson-irblaster.c:218:2: note: in expansion of macro 'dev_dbg'
     218 |  dev_dbg(irb->dev, "tx started, buffer length = %u\n", len);
         |  ^~~~~~~
   drivers/media/rc/meson-irblaster.c:218:56: note: each undeclared identifier is reported only once for each function it appears in
     218 |  dev_dbg(irb->dev, "tx started, buffer length = %u\n", len);
         |                                                        ^~~
   include/linux/dynamic_debug.h:134:15: note: in definition of macro '__dynamic_func_call'
     134 |   func(&id, ##__VA_ARGS__);  \
         |               ^~~~~~~~~~~
   include/linux/dynamic_debug.h:166:2: note: in expansion of macro '_dynamic_func_call'
     166 |  _dynamic_func_call(fmt,__dynamic_dev_dbg,   \
         |  ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
     123 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |  ^~~~~~~~~~~~~~~
   drivers/media/rc/meson-irblaster.c:218:2: note: in expansion of macro 'dev_dbg'
     218 |  dev_dbg(irb->dev, "tx started, buffer length = %u\n", len);
         |  ^~~~~~~


vim +/len +218 drivers/media/rc/meson-irblaster.c

   213	
   214	static void irb_send(struct irblaster_dev *irb)
   215	{
   216		reinit_completion(&irb->completion);
   217	
 > 218		dev_dbg(irb->dev, "tx started, buffer length = %u\n", len);
   219		irb_send_buffer(irb);
   220		wait_for_completion_interruptible(&irb->completion);
   221		dev_dbg(irb->dev, "tx completed\n");
   222	}
   223	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60306 bytes --]