From: "Nuno Sá" <nuno.sa@analog.com>
To: <linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>
Subject: [RFC PATCH 5/6] hwmon: axi-fan-control: clear the fan fault irq at startup
Date: Thu, 8 Jul 2021 14:01:10 +0200 [thread overview]
Message-ID: <20210708120111.519444-6-nuno.sa@analog.com> (raw)
In-Reply-To: <20210708120111.519444-1-nuno.sa@analog.com>
The core might pull itself out of reset automatically which means it can
run with invalid tacho evaluation parameters for some time. Thus, it will
trigger a FAN FAULT interrupt as soon as we unmask it. Some userland apps
might be sensitive to this and act drastically. Hence, we will clear it
here and if there's something really wrong with the FAN or the evaluation
parameters, we'll get that interrupt again...
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
drivers/hwmon/axi-fan-control.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c
index d4b62d54375b..59c9babb3850 100644
--- a/drivers/hwmon/axi-fan-control.c
+++ b/drivers/hwmon/axi-fan-control.c
@@ -379,6 +379,15 @@ static int axi_fan_control_init(struct axi_fan_control_data *ctl,
ADI_IRQ_SRC_PWM_CHANGED | ADI_IRQ_SRC_TEMP_INCREASE),
ADI_REG_IRQ_MASK, ctl);
+ /*
+ * The core might pull itself out of reset automatically which means it can run with
+ * invalid tacho evaluation parameters for some time. Thus, it will trigger a FAN
+ * FAULT interrupt as soon as we unmask it(and some userland apps might be sensitive to
+ * this). Hence, we will clear it here and if there's something really wrong with the
+ * FAN or the evaluation parameters, we'll get that interrupt again...
+ */
+ axi_iowrite(ADI_IRQ_SRC_TACH_ERR, ADI_REG_IRQ_PENDING, ctl);
+
/* bring the device out of reset */
axi_iowrite(0x01, ADI_REG_RSTN, ctl);
--
2.32.0
next prev parent reply other threads:[~2021-07-08 12:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 12:01 [RFC PATCH 0/6] AXI FAN new features and improvements Nuno Sá
2021-07-08 12:01 ` [RFC PATCH 1/6] hwmon: axi-fan-control: make sure the clock is enabled Nuno Sá
2021-07-17 17:24 ` Guenter Roeck
2021-07-19 7:27 ` Sa, Nuno
2021-07-08 12:01 ` [RFC PATCH 2/6] hwmon: axi-fan-control: add tacho devicetree properties Nuno Sá
2021-07-08 12:01 ` [RFC PATCH 3/6] dt-bindings: axi-fan-control: add tacho properties Nuno Sá
2021-07-12 17:26 ` Rob Herring
2021-07-15 10:26 ` Sa, Nuno
2021-07-15 20:39 ` Guenter Roeck
2021-07-16 7:44 ` Sa, Nuno
2021-07-16 15:03 ` Guenter Roeck
2021-07-19 7:46 ` Sa, Nuno
2021-07-21 15:00 ` Guenter Roeck
2021-07-22 13:00 ` Sa, Nuno
2021-07-22 15:23 ` Guenter Roeck
2021-07-08 12:01 ` [RFC PATCH 4/6] hwmon: axi-fan-control: handle irqs in natural order Nuno Sá
2021-07-08 12:01 ` Nuno Sá [this message]
2021-07-08 12:01 ` [RFC PATCH 6/6] hwmon: axi-fan-control: support temperature vs pwm points Nuno Sá
2021-07-17 17:22 ` Guenter Roeck
2021-07-19 7:23 ` Sa, Nuno
2021-07-27 8:42 ` [RFC PATCH 0/6] AXI FAN new features and improvements Sa, Nuno
2021-07-28 18:38 ` Guenter Roeck
2021-08-02 8:04 ` Sa, Nuno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708120111.519444-6-nuno.sa@analog.com \
--to=nuno.sa@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).