From: Maxime Ripard <maxime@cerno.tech>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: "Jernej Škrabec" <jernej.skrabec@siol.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Vagrant Cascadian" <vagrant@reproducible-builds.org>,
"B.R. Oake" <broake@mailfence.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode
Date: Sat, 10 Jul 2021 18:02:13 +0200 [thread overview]
Message-ID: <20210710160213.nursu2vc3ef53nbo@gilmour> (raw)
In-Reply-To: <YOmcI191mbxXCrp1@eldamar.lan>
Hi Salvatore,
On Sat, Jul 10, 2021 at 03:09:55PM +0200, Salvatore Bonaccorso wrote:
> Hi Maxime,
>
> On Mon, May 24, 2021 at 02:35:06PM +0200, Maxime Ripard wrote:
> > On Mon, May 24, 2021 at 02:21:11PM +0200, Salvatore Bonaccorso wrote:
> > > Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > > config") sets the RX/TX delay according to the phy-mode property in the
> > > device tree. For the Orange Pi Plus board this is "rgmii", which is the
> > > wrong setting.
> > >
> > > Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> > > Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> > > the Ethernet working again on this board.
> > >
> > > Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> > > Reported-by: "B.R. Oake" <broake@mailfence.com>
> > > Reported-by: Vagrant Cascadian <vagrant@reproducible-builds.org>
> > > Link: https://bugs.debian.org/988574
> > > Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> >
> > Applied, thanks!
>
> Did this fall trough the cracks?
>
> I see it in
> https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/commit/?id=b19d3479f25e8a0ff24df0b46c82e50ef0f900dd
> but got not merged yet in mainline.
I'm not really sure what happened, but I did send it as part of a fix PR
here:
https://lore.kernel.org/linux-arm-kernel/ad7ba352-315c-4201-b922-4bf914a00d98.lettre@localhost/
But it was sent as part of one of the arm-soc PR for 5.14:
https://lore.kernel.org/linux-arm-kernel/20210709234054.10288-1-olof@lixom.net/
I'm not sure if it didn't get applied to the right branch, but it
doesn't seem to be part of the proper PR either.
Anyway, this is on its way to Linus, will be part of 5.14 and picked up
by the stable tree at some point in a 5.13.* kernel
Maxime
prev parent reply other threads:[~2021-07-10 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 12:21 [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode Salvatore Bonaccorso
2021-05-24 12:35 ` Maxime Ripard
2021-07-10 13:09 ` Salvatore Bonaccorso
2021-07-10 16:02 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210710160213.nursu2vc3ef53nbo@gilmour \
--to=maxime@cerno.tech \
--cc=broake@mailfence.com \
--cc=carnil@debian.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=vagrant@reproducible-builds.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox