From: Rob Herring <robh@kernel.org>
To: kewei.xu@mediatek.com
Cc: wsa@the-dreams.de, bbrezillon@kernel.org, matthias.bgg@gmail.com,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
srv_heupstream@mediatek.com, leilk.liu@mediatek.com,
qii.wang@mediatek.com, liguo.zhang@mediatek.com,
xinping.qian@mediatek.com, ot_daolong.zhu@mediatek.com
Subject: Re: [PATCH V3 2/3] dt-bindings: i2c: add attribute default-timing-adjust
Date: Mon, 12 Jul 2021 14:53:42 -0600 [thread overview]
Message-ID: <20210712205342.GA2469648@robh.at.kernel.org> (raw)
In-Reply-To: <1624271985-23591-3-git-send-email-kewei.xu@mediatek.com>
On Mon, Jun 21, 2021 at 06:39:44PM +0800, kewei.xu@mediatek.com wrote:
> From: Kewei Xu <kewei.xu@mediatek.com>
>
> Add attribute default-timing-adjust for DT-binding document.
>
> Fixes: be5ce0e97cc7 ("i2c: mediatek: Add i2c ac-timing adjust support")
You want to fix a kernel change with a DT change? That's not a
compatible change (and I guess neither was the kernel change). Sounds
like the above commit should be reverted and rethink how to add a new
feature...
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> index 7c4915bc..7b80a11 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> @@ -33,6 +33,8 @@ Optional properties:
> - mediatek,have-pmic: platform can control i2c form special pmic side.
> Only mt6589 and mt8135 support this feature.
> - mediatek,use-push-pull: IO config use push-pull mode.
> + - mediatek,default-timing-adjust: use default timing calculation, no timing
> + adjustment.
>
> Example:
>
> --
> 1.9.1
>
>
next prev parent reply other threads:[~2021-07-12 20:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 10:39 [PATCH V3 0/3] Introduce an attribute to choose timing setting kewei.xu
2021-06-21 10:39 ` [PATCH V3 1/3] i2c: mediatek: Add OFFSET_EXT_CONF setting back kewei.xu
2021-06-23 5:30 ` Tzung-Bi Shih
2021-06-21 10:39 ` [PATCH V3 2/3] dt-bindings: i2c: add attribute default-timing-adjust kewei.xu
2021-07-12 20:53 ` Rob Herring [this message]
2021-07-14 7:49 ` Kewei Xu
2021-06-21 10:39 ` [PATCH V3 3/3] i2c: mediatek: Isolate speed setting via dts for special devices kewei.xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712205342.GA2469648@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bbrezillon@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kewei.xu@mediatek.com \
--cc=leilk.liu@mediatek.com \
--cc=liguo.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=ot_daolong.zhu@mediatek.com \
--cc=qii.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
--cc=xinping.qian@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).