* [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags [not found] <cover.1624349479.git.xji@analogixsemi.com> @ 2021-06-22 12:31 ` Xin Ji [not found] ` <CAG3jFys6D=-L-Aez4aWuE4nM7qJCtn4wPws3TKxbkRzcAoFR0A@mail.gmail.com> 0 siblings, 1 reply; 7+ messages in thread From: Xin Ji @ 2021-06-22 12:31 UTC (permalink / raw) To: Rob Herring, David Airlie, Nicolas Boichat, Hsin-Yi Wang Cc: Daniel Vetter, Sam Ravnborg, Laurent Pinchart, Maxime Ripard, Mark Brown, Ricardo Cañuelo, dri-devel, devicetree, Bernie Liang, Sheng Pan, Zhen Li, linux-kernel Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0, lane1 swing register array define, and audio enable flag. Signed-off-by: Xin Ji <xji@analogixsemi.com> --- .../display/bridge/analogix,anx7625.yaml | 57 ++++++++++++++++++- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml index ab48ab2f4240..9e604d19a3d5 100644 --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml @@ -43,6 +43,26 @@ properties: vdd33-supply: description: Regulator that provides the supply 3.3V power. + analogix,lane0-swing: + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 1 + maxItems: 20 + description: + an array of swing register setting for DP tx lane0 PHY, please don't + add this property, or contact vendor. + + analogix,lane1-swing: + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 1 + maxItems: 20 + description: + an array of swing register setting for DP tx lane1 PHY, please don't + add this property, or contact vendor. + + analogix,audio-enable: + type: boolean + description: let the driver enable audio HDMI codec function or not. + ports: $ref: /schemas/graph.yaml#/properties/ports @@ -50,13 +70,43 @@ properties: port@0: $ref: /schemas/graph.yaml#/properties/port description: - Video port for MIPI DSI input. + MIPI DSI/DPI input. + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + type: object + additionalProperties: false + + properties: + remote-endpoint: true + bus-type: true + data-lanes: true + + required: + - remote-endpoint + + required: + - endpoint + port@1: $ref: /schemas/graph.yaml#/properties/port description: Video port for panel or connector. + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + type: object + additionalProperties: false + + properties: + remote-endpoint: true + + required: + - remote-endpoint + required: - port@0 - port@1 @@ -87,6 +137,9 @@ examples: vdd10-supply = <&pp1000_mipibrdg>; vdd18-supply = <&pp1800_mipibrdg>; vdd33-supply = <&pp3300_mipibrdg>; + analogix,audio-enable; + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; ports { #address-cells = <1>; @@ -96,6 +149,8 @@ examples: reg = <0>; anx7625_in: endpoint { remote-endpoint = <&mipi_dsi>; + bus-type = <5>; + data-lanes = <0 1 2 3>; }; }; -- 2.25.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <CAG3jFys6D=-L-Aez4aWuE4nM7qJCtn4wPws3TKxbkRzcAoFR0A@mail.gmail.com>]
* Re: [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags [not found] ` <CAG3jFys6D=-L-Aez4aWuE4nM7qJCtn4wPws3TKxbkRzcAoFR0A@mail.gmail.com> @ 2021-07-07 7:30 ` Xin Ji 2021-07-13 22:10 ` Rob Herring 2021-07-14 8:32 ` Laurent Pinchart 0 siblings, 2 replies; 7+ messages in thread From: Xin Ji @ 2021-07-07 7:30 UTC (permalink / raw) To: Robert Foss Cc: Rob Herring, David Airlie, Nicolas Boichat, Hsin-Yi Wang, Daniel Vetter, Sam Ravnborg, Laurent Pinchart, Maxime Ripard, Mark Brown, Ricardo Cañuelo, dri-devel, devicetree, Bernie Liang, Sheng Pan, Zhen Li, linux-kernel On Thu, Jun 24, 2021 at 01:57:22PM +0200, Robert Foss wrote: > Hey Xin, > > I would like to merge this series now, but this patch needs a review > first. Maybe Laurent/Rob Herring are good candidates. > > > Rob. Hi Rob, I get Laurent/Rob comments before, and explained why we needs these DT properties, so far, I didn't get any response. Hi Rob Herring and Laurent, for the DT property lane0/1-swing, Google engineer has strong demond for them, they don't want to move DP swing adjusting to kernel, thus may cause change the driver code in each project, so config them in DT is a best option. Thanks, Xin > > On Tue, 22 Jun 2021 at 14:31, Xin Ji <xji@analogixsemi.com> wrote: > > > > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0, > > lane1 swing register array define, and audio enable flag. > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > --- > > .../display/bridge/analogix,anx7625.yaml | 57 ++++++++++++++++++- > > 1 file changed, 56 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > index ab48ab2f4240..9e604d19a3d5 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > @@ -43,6 +43,26 @@ properties: > > vdd33-supply: > > description: Regulator that provides the supply 3.3V power. > > > > + analogix,lane0-swing: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 1 > > + maxItems: 20 > > + description: > > + an array of swing register setting for DP tx lane0 PHY, please don't > > + add this property, or contact vendor. > > + > > + analogix,lane1-swing: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 1 > > + maxItems: 20 > > + description: > > + an array of swing register setting for DP tx lane1 PHY, please don't > > + add this property, or contact vendor. > > + > > + analogix,audio-enable: > > + type: boolean > > + description: let the driver enable audio HDMI codec function or not. > > + > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > > > @@ -50,13 +70,43 @@ properties: > > port@0: > > $ref: /schemas/graph.yaml#/properties/port > > description: > > - Video port for MIPI DSI input. > > + MIPI DSI/DPI input. > > + > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + type: object > > + additionalProperties: false > > + > > + properties: > > + remote-endpoint: true > > + bus-type: true > > + data-lanes: true > > + > > + required: > > + - remote-endpoint > > + > > + required: > > + - endpoint > > + > > > > port@1: > > $ref: /schemas/graph.yaml#/properties/port > > description: > > Video port for panel or connector. > > > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + type: object > > + additionalProperties: false > > + > > + properties: > > + remote-endpoint: true > > + > > + required: > > + - remote-endpoint > > + > > required: > > - port@0 > > - port@1 > > @@ -87,6 +137,9 @@ examples: > > vdd10-supply = <&pp1000_mipibrdg>; > > vdd18-supply = <&pp1800_mipibrdg>; > > vdd33-supply = <&pp3300_mipibrdg>; > > + analogix,audio-enable; > > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > > > ports { > > #address-cells = <1>; > > @@ -96,6 +149,8 @@ examples: > > reg = <0>; > > anx7625_in: endpoint { > > remote-endpoint = <&mipi_dsi>; > > + bus-type = <5>; > > + data-lanes = <0 1 2 3>; > > }; > > }; > > > > -- > > 2.25.1 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags 2021-07-07 7:30 ` Xin Ji @ 2021-07-13 22:10 ` Rob Herring 2021-07-16 5:32 ` Xin Ji 2021-07-14 8:32 ` Laurent Pinchart 1 sibling, 1 reply; 7+ messages in thread From: Rob Herring @ 2021-07-13 22:10 UTC (permalink / raw) To: Xin Ji Cc: Robert Foss, David Airlie, Nicolas Boichat, Hsin-Yi Wang, Daniel Vetter, Sam Ravnborg, Laurent Pinchart, Maxime Ripard, Mark Brown, Ricardo Cañuelo, dri-devel, devicetree, Bernie Liang, Sheng Pan, Zhen Li, linux-kernel On Wed, Jul 07, 2021 at 03:30:51PM +0800, Xin Ji wrote: > On Thu, Jun 24, 2021 at 01:57:22PM +0200, Robert Foss wrote: > > Hey Xin, > > > > I would like to merge this series now, but this patch needs a review > > first. Maybe Laurent/Rob Herring are good candidates. > > > > > > Rob. > Hi Rob, I get Laurent/Rob comments before, and explained why we needs > these DT properties, so far, I didn't get any response. Do I have to go dig that up? If it was more than a week ago, assume I don't remember. This is 1 of 100 bindings a week. Justify why this is needed in your commit message. > Hi Rob Herring and Laurent, for the DT property lane0/1-swing, Google > engineer has strong demond for them, they don't want to move DP swing > adjusting to kernel, thus may cause change the driver code in each > project, so config them in DT is a best option. Where's the ack from a Google engineer? > > Thanks, > Xin > > > > On Tue, 22 Jun 2021 at 14:31, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0, > > > lane1 swing register array define, and audio enable flag. > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > --- > > > .../display/bridge/analogix,anx7625.yaml | 57 ++++++++++++++++++- > > > 1 file changed, 56 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > index ab48ab2f4240..9e604d19a3d5 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > @@ -43,6 +43,26 @@ properties: > > > vdd33-supply: > > > description: Regulator that provides the supply 3.3V power. > > > > > > + analogix,lane0-swing: > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > + minItems: 1 > > > + maxItems: 20 > > > + description: > > > + an array of swing register setting for DP tx lane0 PHY, please don't > > > + add this property, or contact vendor. Why do we have the property if we're not supposed to add it. > > > + > > > + analogix,lane1-swing: > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > + minItems: 1 > > > + maxItems: 20 > > > + description: > > > + an array of swing register setting for DP tx lane1 PHY, please don't > > > + add this property, or contact vendor. > > > + > > > + analogix,audio-enable: > > > + type: boolean > > > + description: let the driver enable audio HDMI codec function or not. Wouldn't we have a 'port' node if audio is to be enabled? > > > + > > > ports: > > > $ref: /schemas/graph.yaml#/properties/ports > > > > > > @@ -50,13 +70,43 @@ properties: > > > port@0: > > > $ref: /schemas/graph.yaml#/properties/port > > > description: > > > - Video port for MIPI DSI input. > > > + MIPI DSI/DPI input. > > > + > > > + properties: > > > + endpoint: > > > + $ref: /schemas/media/video-interfaces.yaml# > > > + type: object > > > + additionalProperties: false Use 'unevaluatedProperties: false' instead... > > > + > > > + properties: > > > + remote-endpoint: true ...And drop this. > > > + bus-type: true This device supports all the possible bus types? What's the default as it is not required? > > > + data-lanes: true And up to 8 lanes? > > > + > > > + required: > > > + - remote-endpoint > > > + > > > + required: > > > + - endpoint You can drop both 'required'. > > > + > > > > > > port@1: > > > $ref: /schemas/graph.yaml#/properties/port > > > description: > > > Video port for panel or connector. > > > > > > + properties: > > > + endpoint: > > > + $ref: /schemas/media/video-interfaces.yaml# Doesn't look like anything from video-interfaces.yaml is used. This whole chunk is not needed. > > > + type: object > > > + additionalProperties: false > > > + > > > + properties: > > > + remote-endpoint: true > > > + > > > + required: > > > + - remote-endpoint > > > + > > > required: > > > - port@0 > > > - port@1 > > > @@ -87,6 +137,9 @@ examples: > > > vdd10-supply = <&pp1000_mipibrdg>; > > > vdd18-supply = <&pp1800_mipibrdg>; > > > vdd33-supply = <&pp3300_mipibrdg>; > > > + analogix,audio-enable; > > > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > > > > > ports { > > > #address-cells = <1>; > > > @@ -96,6 +149,8 @@ examples: > > > reg = <0>; > > > anx7625_in: endpoint { > > > remote-endpoint = <&mipi_dsi>; > > > + bus-type = <5>; > > > + data-lanes = <0 1 2 3>; > > > }; > > > }; > > > > > > -- > > > 2.25.1 > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags 2021-07-13 22:10 ` Rob Herring @ 2021-07-16 5:32 ` Xin Ji 2021-07-16 6:13 ` Nicolas Boichat 0 siblings, 1 reply; 7+ messages in thread From: Xin Ji @ 2021-07-16 5:32 UTC (permalink / raw) To: Rob Herring Cc: David Airlie, Nicolas Boichat, Hsin-Yi Wang, Daniel Vetter, Sam Ravnborg, Laurent Pinchart, Maxime Ripard, Mark Brown, Ricardo Cañuelo, dri-devel, devicetree, Bernie Liang, Sheng Pan, Zhen Li, linux-kernel On Tue, Jul 13, 2021 at 04:10:10PM -0600, Rob Herring wrote: > On Wed, Jul 07, 2021 at 03:30:51PM +0800, Xin Ji wrote: > > On Thu, Jun 24, 2021 at 01:57:22PM +0200, Robert Foss wrote: > > > Hey Xin, > > > > > > I would like to merge this series now, but this patch needs a review > > > first. Maybe Laurent/Rob Herring are good candidates. > > > > > > > > > Rob. > > Hi Rob, I get Laurent/Rob comments before, and explained why we needs > > these DT properties, so far, I didn't get any response. > > Do I have to go dig that up? If it was more than a week ago, assume I > don't remember. This is 1 of 100 bindings a week. > > Justify why this is needed in your commit message. Hi Rob, I'll give more detail description in commit message. > > > Hi Rob Herring and Laurent, for the DT property lane0/1-swing, Google > > engineer has strong demond for them, they don't want to move DP swing > > adjusting to kernel, thus may cause change the driver code in each > > project, so config them in DT is a best option. > > Where's the ack from a Google engineer? They didn't give the review ack, but we discussed it offline. Nicolas Boichat known this. Thanks, Xin > > > > > Thanks, > > Xin > > > > > > On Tue, 22 Jun 2021 at 14:31, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0, > > > > lane1 swing register array define, and audio enable flag. > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > --- > > > > .../display/bridge/analogix,anx7625.yaml | 57 ++++++++++++++++++- > > > > 1 file changed, 56 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > index ab48ab2f4240..9e604d19a3d5 100644 > > > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > @@ -43,6 +43,26 @@ properties: > > > > vdd33-supply: > > > > description: Regulator that provides the supply 3.3V power. > > > > > > > > + analogix,lane0-swing: > > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > > + minItems: 1 > > > > + maxItems: 20 > > > > + description: > > > > + an array of swing register setting for DP tx lane0 PHY, please don't > > > > + add this property, or contact vendor. > > Why do we have the property if we're not supposed to add it. > > > > > + > > > > + analogix,lane1-swing: > > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > > + minItems: 1 > > > > + maxItems: 20 > > > > + description: > > > > + an array of swing register setting for DP tx lane1 PHY, please don't > > > > + add this property, or contact vendor. > > > > + > > > > + analogix,audio-enable: > > > > + type: boolean > > > > + description: let the driver enable audio HDMI codec function or not. > > Wouldn't we have a 'port' node if audio is to be enabled? > > > > > + > > > > ports: > > > > $ref: /schemas/graph.yaml#/properties/ports > > > > > > > > @@ -50,13 +70,43 @@ properties: > > > > port@0: > > > > $ref: /schemas/graph.yaml#/properties/port > > > > description: > > > > - Video port for MIPI DSI input. > > > > + MIPI DSI/DPI input. > > > > + > > > > + properties: > > > > + endpoint: > > > > + $ref: /schemas/media/video-interfaces.yaml# > > > > + type: object > > > > + additionalProperties: false > > Use 'unevaluatedProperties: false' instead... > > > > > + > > > > + properties: > > > > + remote-endpoint: true > > ...And drop this. > > > > > + bus-type: true > > This device supports all the possible bus types? What's the default as > it is not required? > > > > > + data-lanes: true > > And up to 8 lanes? > > > > > + > > > > + required: > > > > + - remote-endpoint > > > > + > > > > + required: > > > > + - endpoint > > You can drop both 'required'. > > > > > + > > > > > > > > port@1: > > > > $ref: /schemas/graph.yaml#/properties/port > > > > description: > > > > Video port for panel or connector. > > > > > > > > + properties: > > > > + endpoint: > > > > + $ref: /schemas/media/video-interfaces.yaml# > > Doesn't look like anything from video-interfaces.yaml is used. This > whole chunk is not needed. > > > > > + type: object > > > > + additionalProperties: false > > > > + > > > > + properties: > > > > + remote-endpoint: true > > > > + > > > > + required: > > > > + - remote-endpoint > > > > + > > > > required: > > > > - port@0 > > > > - port@1 > > > > @@ -87,6 +137,9 @@ examples: > > > > vdd10-supply = <&pp1000_mipibrdg>; > > > > vdd18-supply = <&pp1800_mipibrdg>; > > > > vdd33-supply = <&pp3300_mipibrdg>; > > > > + analogix,audio-enable; > > > > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > > > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > > > > > > > ports { > > > > #address-cells = <1>; > > > > @@ -96,6 +149,8 @@ examples: > > > > reg = <0>; > > > > anx7625_in: endpoint { > > > > remote-endpoint = <&mipi_dsi>; > > > > + bus-type = <5>; > > > > + data-lanes = <0 1 2 3>; > > > > }; > > > > }; > > > > > > > > -- > > > > 2.25.1 > > > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags 2021-07-16 5:32 ` Xin Ji @ 2021-07-16 6:13 ` Nicolas Boichat 0 siblings, 0 replies; 7+ messages in thread From: Nicolas Boichat @ 2021-07-16 6:13 UTC (permalink / raw) To: Xin Ji Cc: Rob Herring, Nicolas Boichat, Laurent Pinchart, Devicetree List, David Airlie, Ricardo Cañuelo, Zhen Li, lkml, Mark Brown, dri-devel, Hsin-Yi Wang, Sam Ravnborg, Bernie Liang, Sheng Pan On Fri, Jul 16, 2021 at 1:32 PM Xin Ji <xji@analogixsemi.com> wrote: > > On Tue, Jul 13, 2021 at 04:10:10PM -0600, Rob Herring wrote: > > On Wed, Jul 07, 2021 at 03:30:51PM +0800, Xin Ji wrote: > > > On Thu, Jun 24, 2021 at 01:57:22PM +0200, Robert Foss wrote: > > > > Hey Xin, > > > > > > > > I would like to merge this series now, but this patch needs a review > > > > first. Maybe Laurent/Rob Herring are good candidates. > > > > > > > > > > > > Rob. > > > Hi Rob, I get Laurent/Rob comments before, and explained why we needs > > > these DT properties, so far, I didn't get any response. > > > > Do I have to go dig that up? If it was more than a week ago, assume I > > don't remember. This is 1 of 100 bindings a week. > > > > Justify why this is needed in your commit message. > Hi Rob, I'll give more detail description in commit message. > > > > > Hi Rob Herring and Laurent, for the DT property lane0/1-swing, Google > > > engineer has strong demond for them, they don't want to move DP swing > > > adjusting to kernel, thus may cause change the driver code in each > > > project, so config them in DT is a best option. > > > > Where's the ack from a Google engineer? > They didn't give the review ack, but we discussed it offline. Nicolas > Boichat known this. Yeah I suggested this here: https://lore.kernel.org/patchwork/patch/1359670/#1564682 . I also looked at the ANX7625 datasheet at the time and it was pretty clear to me that this was not something customers could tune without ANX's help, but it'd be great if Xin Ji can describe a bit more. > > Thanks, > Xin > [snip] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags 2021-07-07 7:30 ` Xin Ji 2021-07-13 22:10 ` Rob Herring @ 2021-07-14 8:32 ` Laurent Pinchart 2021-07-16 5:35 ` Xin Ji 1 sibling, 1 reply; 7+ messages in thread From: Laurent Pinchart @ 2021-07-14 8:32 UTC (permalink / raw) To: Xin Ji Cc: Robert Foss, Rob Herring, David Airlie, Nicolas Boichat, Hsin-Yi Wang, Daniel Vetter, Sam Ravnborg, Maxime Ripard, Mark Brown, Ricardo Cañuelo, dri-devel, devicetree, Bernie Liang, Sheng Pan, Zhen Li, linux-kernel Hi Xin, On Wed, Jul 07, 2021 at 03:30:51PM +0800, Xin Ji wrote: > On Thu, Jun 24, 2021 at 01:57:22PM +0200, Robert Foss wrote: > > Hey Xin, > > > > I would like to merge this series now, but this patch needs a review > > first. Maybe Laurent/Rob Herring are good candidates. > > Hi Rob, I get Laurent/Rob comments before, and explained why we needs > these DT properties, so far, I didn't get any response. > > Hi Rob Herring and Laurent, for the DT property lane0/1-swing, Google > engineer has strong demond for them, they don't want to move DP swing > adjusting to kernel, thus may cause change the driver code in each > project, so config them in DT is a best option. Hardcoding it in the driver is certainly not a good option, but hardcoding it in DT isn't either unless you can explain how the value should be computed. "Contact the vendor" isn't good enough. > > On Tue, 22 Jun 2021 at 14:31, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0, > > > lane1 swing register array define, and audio enable flag. > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > --- > > > .../display/bridge/analogix,anx7625.yaml | 57 ++++++++++++++++++- > > > 1 file changed, 56 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > index ab48ab2f4240..9e604d19a3d5 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > @@ -43,6 +43,26 @@ properties: > > > vdd33-supply: > > > description: Regulator that provides the supply 3.3V power. > > > > > > + analogix,lane0-swing: > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > + minItems: 1 > > > + maxItems: 20 > > > + description: > > > + an array of swing register setting for DP tx lane0 PHY, please don't > > > + add this property, or contact vendor. > > > + > > > + analogix,lane1-swing: > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > + minItems: 1 > > > + maxItems: 20 > > > + description: > > > + an array of swing register setting for DP tx lane1 PHY, please don't > > > + add this property, or contact vendor. > > > + > > > + analogix,audio-enable: > > > + type: boolean > > > + description: let the driver enable audio HDMI codec function or not. > > > + > > > ports: > > > $ref: /schemas/graph.yaml#/properties/ports > > > > > > @@ -50,13 +70,43 @@ properties: > > > port@0: > > > $ref: /schemas/graph.yaml#/properties/port > > > description: > > > - Video port for MIPI DSI input. > > > + MIPI DSI/DPI input. > > > + > > > + properties: > > > + endpoint: > > > + $ref: /schemas/media/video-interfaces.yaml# > > > + type: object > > > + additionalProperties: false > > > + > > > + properties: > > > + remote-endpoint: true > > > + bus-type: true > > > + data-lanes: true > > > + > > > + required: > > > + - remote-endpoint > > > + > > > + required: > > > + - endpoint > > > + > > > > > > port@1: > > > $ref: /schemas/graph.yaml#/properties/port > > > description: > > > Video port for panel or connector. > > > > > > + properties: > > > + endpoint: > > > + $ref: /schemas/media/video-interfaces.yaml# > > > + type: object > > > + additionalProperties: false > > > + > > > + properties: > > > + remote-endpoint: true > > > + > > > + required: > > > + - remote-endpoint > > > + > > > required: > > > - port@0 > > > - port@1 > > > @@ -87,6 +137,9 @@ examples: > > > vdd10-supply = <&pp1000_mipibrdg>; > > > vdd18-supply = <&pp1800_mipibrdg>; > > > vdd33-supply = <&pp3300_mipibrdg>; > > > + analogix,audio-enable; > > > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > > > > > ports { > > > #address-cells = <1>; > > > @@ -96,6 +149,8 @@ examples: > > > reg = <0>; > > > anx7625_in: endpoint { > > > remote-endpoint = <&mipi_dsi>; > > > + bus-type = <5>; > > > + data-lanes = <0 1 2 3>; > > > }; > > > }; > > > -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags 2021-07-14 8:32 ` Laurent Pinchart @ 2021-07-16 5:35 ` Xin Ji 0 siblings, 0 replies; 7+ messages in thread From: Xin Ji @ 2021-07-16 5:35 UTC (permalink / raw) To: Laurent Pinchart Cc: Rob Herring, David Airlie, Nicolas Boichat, Hsin-Yi Wang, Daniel Vetter, Sam Ravnborg, Maxime Ripard, Mark Brown, Ricardo Cañuelo, dri-devel, devicetree, Bernie Liang, Sheng Pan, Zhen Li, linux-kernel On Wed, Jul 14, 2021 at 11:32:35AM +0300, Laurent Pinchart wrote: > Hi Xin, > > On Wed, Jul 07, 2021 at 03:30:51PM +0800, Xin Ji wrote: > > On Thu, Jun 24, 2021 at 01:57:22PM +0200, Robert Foss wrote: > > > Hey Xin, > > > > > > I would like to merge this series now, but this patch needs a review > > > first. Maybe Laurent/Rob Herring are good candidates. > > > > Hi Rob, I get Laurent/Rob comments before, and explained why we needs > > these DT properties, so far, I didn't get any response. > > > > Hi Rob Herring and Laurent, for the DT property lane0/1-swing, Google > > engineer has strong demond for them, they don't want to move DP swing > > adjusting to kernel, thus may cause change the driver code in each > > project, so config them in DT is a best option. > > Hardcoding it in the driver is certainly not a good option, but > hardcoding it in DT isn't either unless you can explain how the value > should be computed. "Contact the vendor" isn't good enough. Hi Laurent Pinchart, thanks for the coment, I'll add more detail explain about the value means. Thanks, Xin > > > > On Tue, 22 Jun 2021 at 14:31, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0, > > > > lane1 swing register array define, and audio enable flag. > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > --- > > > > .../display/bridge/analogix,anx7625.yaml | 57 ++++++++++++++++++- > > > > 1 file changed, 56 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > index ab48ab2f4240..9e604d19a3d5 100644 > > > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > > @@ -43,6 +43,26 @@ properties: > > > > vdd33-supply: > > > > description: Regulator that provides the supply 3.3V power. > > > > > > > > + analogix,lane0-swing: > > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > > + minItems: 1 > > > > + maxItems: 20 > > > > + description: > > > > + an array of swing register setting for DP tx lane0 PHY, please don't > > > > + add this property, or contact vendor. > > > > + > > > > + analogix,lane1-swing: > > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > > + minItems: 1 > > > > + maxItems: 20 > > > > + description: > > > > + an array of swing register setting for DP tx lane1 PHY, please don't > > > > + add this property, or contact vendor. > > > > + > > > > + analogix,audio-enable: > > > > + type: boolean > > > > + description: let the driver enable audio HDMI codec function or not. > > > > + > > > > ports: > > > > $ref: /schemas/graph.yaml#/properties/ports > > > > > > > > @@ -50,13 +70,43 @@ properties: > > > > port@0: > > > > $ref: /schemas/graph.yaml#/properties/port > > > > description: > > > > - Video port for MIPI DSI input. > > > > + MIPI DSI/DPI input. > > > > + > > > > + properties: > > > > + endpoint: > > > > + $ref: /schemas/media/video-interfaces.yaml# > > > > + type: object > > > > + additionalProperties: false > > > > + > > > > + properties: > > > > + remote-endpoint: true > > > > + bus-type: true > > > > + data-lanes: true > > > > + > > > > + required: > > > > + - remote-endpoint > > > > + > > > > + required: > > > > + - endpoint > > > > + > > > > > > > > port@1: > > > > $ref: /schemas/graph.yaml#/properties/port > > > > description: > > > > Video port for panel or connector. > > > > > > > > + properties: > > > > + endpoint: > > > > + $ref: /schemas/media/video-interfaces.yaml# > > > > + type: object > > > > + additionalProperties: false > > > > + > > > > + properties: > > > > + remote-endpoint: true > > > > + > > > > + required: > > > > + - remote-endpoint > > > > + > > > > required: > > > > - port@0 > > > > - port@1 > > > > @@ -87,6 +137,9 @@ examples: > > > > vdd10-supply = <&pp1000_mipibrdg>; > > > > vdd18-supply = <&pp1800_mipibrdg>; > > > > vdd33-supply = <&pp3300_mipibrdg>; > > > > + analogix,audio-enable; > > > > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > > > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > > > > > > > ports { > > > > #address-cells = <1>; > > > > @@ -96,6 +149,8 @@ examples: > > > > reg = <0>; > > > > anx7625_in: endpoint { > > > > remote-endpoint = <&mipi_dsi>; > > > > + bus-type = <5>; > > > > + data-lanes = <0 1 2 3>; > > > > }; > > > > }; > > > > > > -- > Regards, > > Laurent Pinchart ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-16 6:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1624349479.git.xji@analogixsemi.com>
2021-06-22 12:31 ` [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags Xin Ji
[not found] ` <CAG3jFys6D=-L-Aez4aWuE4nM7qJCtn4wPws3TKxbkRzcAoFR0A@mail.gmail.com>
2021-07-07 7:30 ` Xin Ji
2021-07-13 22:10 ` Rob Herring
2021-07-16 5:32 ` Xin Ji
2021-07-16 6:13 ` Nicolas Boichat
2021-07-14 8:32 ` Laurent Pinchart
2021-07-16 5:35 ` Xin Ji
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).