From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Johan Jonker <jbx6244@gmail.com>,
Heiko Stuebner <heiko@sntech.de>, Sasha Levin <sashal@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: [PATCH AUTOSEL 5.10 24/88] arm64: dts: rockchip: fix regulator-gpio states array
Date: Wed, 14 Jul 2021 15:41:59 -0400 [thread overview]
Message-ID: <20210714194303.54028-24-sashal@kernel.org> (raw)
In-Reply-To: <20210714194303.54028-1-sashal@kernel.org>
From: Johan Jonker <jbx6244@gmail.com>
[ Upstream commit b82f8e2992534aab0fa762a37376be30df263701 ]
A test with the command below gives this error:
/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dt.yaml:
sdmmcio-regulator: states:0:
[1800000, 1, 3300000, 0] is too long
dtbs_check expects regulator-gpio states in a format
of 2 per item, so fix them all.
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/
regulator/gpio-regulator.yaml
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Link: https://lore.kernel.org/r/20210510215840.16270-1-jbx6244@gmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts | 4 ++--
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 4 ++--
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 4 ++--
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 2 +-
arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 ++--
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts
index 7a96be10eaf0..bce6f8b7db43 100644
--- a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts
@@ -78,8 +78,8 @@ vcc_sdmmc: vcc-sdmmc {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_HIGH>;
- states = <1800000 0x0
- 3300000 0x1>;
+ states = <1800000 0x0>,
+ <3300000 0x1>;
vin-supply = <&vcc5v0_sys>;
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
index 1eecad724f04..83a0bdbe00d6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
@@ -71,8 +71,8 @@ vcc_io_sdio: sdmmcio-regulator {
regulator-settling-time-us = <5000>;
regulator-type = "voltage";
startup-delay-us = <2000>;
- states = <1800000 0x1
- 3300000 0x0>;
+ states = <1800000 0x1>,
+ <3300000 0x0>;
vin-supply = <&vcc_io_33>;
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
index b76282e704de..daa9a0c601a9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
@@ -45,8 +45,8 @@ vcc_sd: sdmmc-regulator {
vcc_sdio: sdmmcio-regulator {
compatible = "regulator-gpio";
gpios = <&grf_gpio 0 GPIO_ACTIVE_HIGH>;
- states = <1800000 0x1
- 3300000 0x0>;
+ states = <1800000 0x1>,
+ <3300000 0x0>;
regulator-name = "vcc_sdio";
regulator-type = "voltage";
regulator-min-microvolt = <1800000>;
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi
index 60cd1c18cd4e..e9ecffc409c0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi
@@ -245,7 +245,7 @@ &ppvar_gpu_pwm {
};
&ppvar_sd_card_io {
- states = <1800000 0x0 3300000 0x1>;
+ states = <1800000 0x0>, <3300000 0x1>;
regulator-max-microvolt = <3300000>;
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
index 32dcaf210085..765b24a2bcbf 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
@@ -247,8 +247,8 @@ ppvar_sd_card_io: ppvar-sd-card-io {
enable-active-high;
enable-gpio = <&gpio2 2 GPIO_ACTIVE_HIGH>;
gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>;
- states = <1800000 0x1
- 3000000 0x0>;
+ states = <1800000 0x1>,
+ <3000000 0x0>;
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3000000>;
--
2.30.2
next prev parent reply other threads:[~2021-07-14 19:48 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 19:41 [PATCH AUTOSEL 5.10 01/88] ARM: dts: gemini: rename mdio to the right name Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 02/88] ARM: dts: gemini: add device_type on pci Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 03/88] ARM: dts: rockchip: Fix thermal sensor cells o rk322x Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 04/88] ARM: dts: rockchip: fix pinctrl sleep nodename for rk3036-kylin and rk3288 Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 05/88] arm64: dts: rockchip: fix pinctrl sleep nodename for rk3399.dtsi Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 06/88] ARM: dts: rockchip: Fix the timer clocks order Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 07/88] ARM: dts: rockchip: Fix IOMMU nodes properties on rk322x Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 08/88] ARM: dts: rockchip: Fix power-controller node names for rk3066a Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 09/88] ARM: dts: rockchip: Fix power-controller node names for rk3188 Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 10/88] ARM: dts: rockchip: Fix power-controller node names for rk3288 Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 11/88] arm64: dts: rockchip: Fix power-controller node names for px30 Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 12/88] arm64: dts: rockchip: Fix power-controller node names for rk3328 Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 13/88] arm64: dts: rockchip: Fix power-controller node names for rk3399 Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 15/88] ARM: brcmstb: dts: fix NAND nodes names Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 16/88] ARM: Cygnus: " Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 17/88] ARM: NSP: " Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 18/88] ARM: dts: BCM63xx: Fix " Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 19/88] ARM: dts: Hurricane 2: " Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 20/88] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F] Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 21/88] ARM: dts: exynos: align Broadcom WiFi with dtschema Sasha Levin
2021-07-14 19:41 ` [PATCH AUTOSEL 5.10 22/88] ARM: dts: imx6: phyFLEX: Fix UART hardware flow control Sasha Levin
2021-07-14 19:41 ` Sasha Levin [this message]
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 25/88] ARM: dts: ux500: Fix interrupt cells Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 26/88] ARM: dts: ux500: Rename gpio-controller node Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 27/88] ARM: dts: ux500: Fix orientation of accelerometer Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 28/88] ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE value Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 30/88] arm64: dts: renesas: beacon: Fix USB extal reference Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 31/88] arm64: dts: renesas: beacon: Fix USB ref clock references Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 33/88] ARM: dts: am335x: align GPIO hog names with dt-schema Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 34/88] ARM: dts: am437x: align gpio " Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 35/88] ARM: dts: omap3: " Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 36/88] ARM: dts: omap5-board-common: " Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 37/88] ARM: dts: dra7x-evm: Align GPIO " Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 38/88] ARM: dts: am57xx-cl-som-am57x: fix ti,no-reset-on-init flag for gpios Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 39/88] ARM: dts: am437x-gp-evm: " Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 40/88] ARM: dts: am335x: " Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 41/88] ARM: dts: OMAP2+: Replace underscores in sub-mailbox node names Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 42/88] arm64: dts: ti: k3-am654x/j721e/j7200-common-proc-board: Fix MCU_RGMII1_TXC direction Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 43/88] ARM: tegra: wm8903: Fix polarity of headphones-detection GPIO in device-trees Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 44/88] ARM: tegra: nexus7: Correct 3v3 regulator GPIO of PM269 variant Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 45/88] arm64: dts: qcom: msm8996: Make CPUCC actually probe (and work) Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 46/88] arm64: dts: qcom: sc7180: Move rmtfs memory region Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 47/88] ARM: dts: stm32: Remove extra size-cells on dhcom-pdk2 Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 48/88] ARM: dts: stm32: Fix touchscreen node " Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 49/88] ARM: dts: stm32: fix stm32mp157c-odyssey card detect pin Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 50/88] ARM: dts: stm32: fix gpio-keys node on STM32 MCU boards Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 51/88] ARM: dts: stm32: fix RCC node name on stm32f429 MCU Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 52/88] ARM: dts: stm32: fix timer nodes on STM32 MCU to prevent warnings Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 56/88] ARM: dts: bcm283x: Fix up MMC node names Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 57/88] ARM: dts: bcm283x: Fix up GPIO LED " Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 58/88] arm64: dts: juno: Update SCPI nodes as per the YAML schema Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 59/88] ARM: dts: rockchip: fix supply properties in io-domains nodes Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 60/88] ARM: dts: stm32: fix i2c node name on stm32f746 to prevent warnings Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 61/88] ARM: dts: stm32: move stmmac axi config in ethernet node on stm32mp15 Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 62/88] ARM: dts: stm32: fix the Odyssey SoM eMMC VQMMC supply Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 63/88] ARM: dts: stm32: Drop unused linux,wakeup from touchscreen node on DHCOM SoM Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 64/88] ARM: dts: stm32: Rename spi-flash/mx66l51235l@N to flash@N " Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 65/88] ARM: dts: stm32: fix stpmic node for stm32mp1 boards Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 69/88] arm64: dts: ls208xa: remove bus-num from dspi node Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 70/88] arm64: dts: imx8mq: assign PCIe clocks Sasha Levin
2021-07-14 19:42 ` [PATCH AUTOSEL 5.10 76/88] arch/arm64/boot/dts/marvell: fix NAND partitioning scheme Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714194303.54028-24-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).