From: Maxime Ripard <maxime@cerno.tech>
To: fengzheng923@gmail.com
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
wens@csie.org, jernej.skrabec@gmail.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
Date: Thu, 15 Jul 2021 09:49:59 +0200 [thread overview]
Message-ID: <20210715074959.lepsaiyl3ihthy4s@gilmour> (raw)
In-Reply-To: <20210711124826.5376-1-fengzheng923@gmail.com>
On Sun, Jul 11, 2021 at 08:48:26AM -0400, fengzheng923@gmail.com wrote:
> From: Ban Tao <fengzheng923@gmail.com>
>
> DT binding documentation for this new ASoC driver.
>
> Signed-off-by: Ban Tao <fengzheng923@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Maxime Ripard <maxime@cerno.tech>
> ---
> v1->v2:
> 1.Fix some build errors.
> ---
> v2->v3:
> 1.Fix some build errors.
> ---
> v3->v4:
> 1.None.
> ---
> v4->v5:
> 1.Add interrupt.
> 2.Keep clock and reset index.
> ---
> v5->v6:
> 1.None.
> ---
Just as a general comment, you don't need to duplicate the --- all the
time, here something like the following would have been fine
---
v1->v2:
1.Fix some build errors.
v2->v3:
1.Fix some build errors.
v3->v4:
1.None
etc.
git will ignore anything after ---, so it doesn't matter whether there's
one or multiple.
Maxime
prev parent reply other threads:[~2021-07-15 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 12:48 [PATCH v6 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller fengzheng923
2021-07-15 7:49 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715074959.lepsaiyl3ihthy4s@gilmour \
--to=maxime@cerno.tech \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fengzheng923@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox