* [PATCH] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro
@ 2021-07-15 16:41 matthias.bgg
2021-07-17 21:52 ` Heiko Stuebner
0 siblings, 1 reply; 3+ messages in thread
From: matthias.bgg @ 2021-07-15 16:41 UTC (permalink / raw)
To: Rob Herring, Heiko Stuebner
Cc: Matthias Brugger, devicetree, Simon South, linux-arm-kernel,
linux-rockchip, Guillaume Gardet, linux-kernel
From: Matthias Brugger <mbrugger@suse.com>
The CDN DP needs a PHY and a extcon to work correctly. But no extcon is
provided by the device-tree, which leads to an error:
cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
cdn-dp: probe of fec00000.dp failed with error -22
Disable the CDN DP to make graphic work on the Pinebook Pro.
Reported-by: Guillaume Gardet <guillaume.gardet@arm.com>
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 2b5f001ff4a6..9e5d07f5712e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -385,10 +385,6 @@ mains_charger: dc-charger {
};
};
-&cdn_dp {
- status = "okay";
-};
-
&cpu_b0 {
cpu-supply = <&vdd_cpu_b>;
};
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro
2021-07-15 16:41 [PATCH] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro matthias.bgg
@ 2021-07-17 21:52 ` Heiko Stuebner
2021-10-23 18:34 ` Siva Mahadevan
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stuebner @ 2021-07-17 21:52 UTC (permalink / raw)
To: Rob Herring, matthias.bgg@kernel.org
Cc: Heiko Stuebner, devicetree, Simon South, linux-kernel,
linux-arm-kernel, Guillaume Gardet, linux-rockchip,
Matthias Brugger
On Thu, 15 Jul 2021 18:41:01 +0200, matthias.bgg@kernel.org wrote:
> The CDN DP needs a PHY and a extcon to work correctly. But no extcon is
> provided by the device-tree, which leads to an error:
> cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
> cdn-dp: probe of fec00000.dp failed with error -22
>
> Disable the CDN DP to make graphic work on the Pinebook Pro.
Applied, thanks!
[1/1] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro
commit: 714b35da2b6eace13bfe23ae02330e3b6a2ea4e7
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro
2021-07-17 21:52 ` Heiko Stuebner
@ 2021-10-23 18:34 ` Siva Mahadevan
0 siblings, 0 replies; 3+ messages in thread
From: Siva Mahadevan @ 2021-10-23 18:34 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, matthias.bgg@kernel.org
Cc: devicetree, Simon South, linux-kernel, linux-arm-kernel,
Guillaume Gardet, linux-rockchip, Matthias Brugger
Heiko Stuebner wrote:
> On Thu, 15 Jul 2021 18:41:01 +0200, matthias.bgg@kernel.org wrote:
> > The CDN DP needs a PHY and a extcon to work correctly. But no extcon is
> > provided by the device-tree, which leads to an error:
> > cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
> > cdn-dp: probe of fec00000.dp failed with error -22
> >
> > Disable the CDN DP to make graphic work on the Pinebook Pro.
>
> Applied, thanks!
>
> [1/1] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro
> commit: 714b35da2b6eace13bfe23ae02330e3b6a2ea4e7
>
> Best regards,
> --
> Heiko Stuebner <heiko@sntech.de>
Will this patch be submitted to mainline? I can confirm on my pinebook
pro that this solves the issue.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-23 18:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-15 16:41 [PATCH] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro matthias.bgg
2021-07-17 21:52 ` Heiko Stuebner
2021-10-23 18:34 ` Siva Mahadevan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).