[PATCH V2] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN

[PATCH V2] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN

[Joakim Zhang]

FlexCAN on i.MX8MP is not derived from i.MX6Q, instead resues from
i.MX8QM with extra ECC added and default is enabled, so that the FlexCAN
would be put into freeze mode without FLEXCAN_QUIRK_DISABLE_MECR quirk.

This patch removes "fsl,imx6q-flexcan" fallback compatible string since
it's not compatible with the i.MX6Q.

Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
ChangeLogs:
V1->V2:
	* improve commit message a bit.
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 9f7c7f587d38..1bfb359dba4a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -579,7 +579,7 @@
 			};
 
 			flexcan1: can@308c0000 {
-				compatible = "fsl,imx8mp-flexcan", "fsl,imx6q-flexcan";
+				compatible = "fsl,imx8mp-flexcan";
 				reg = <0x308c0000 0x10000>;
 				interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
@@ -594,7 +594,7 @@
 			};
 
 			flexcan2: can@308d0000 {
-				compatible = "fsl,imx8mp-flexcan", "fsl,imx6q-flexcan";
+				compatible = "fsl,imx8mp-flexcan";
 				reg = <0x308d0000 0x10000>;
 				interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
-- 
2.17.1

Re: [PATCH V2] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN

[Fabio Estevam]

Hi Joakim,

On Fri, Jul 16, 2021 at 7:03 AM Joakim Zhang <qiangqing.zhang@nxp.com> wrote:
>
> FlexCAN on i.MX8MP is not derived from i.MX6Q, instead resues from
> i.MX8QM with extra ECC added and default is enabled, so that the FlexCAN
> would be put into freeze mode without FLEXCAN_QUIRK_DISABLE_MECR quirk.
>
> This patch removes "fsl,imx6q-flexcan" fallback compatible string since
> it's not compatible with the i.MX6Q.
>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Re: [PATCH V2] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

On Fri, Jul 16, 2021 at 06:04:14PM +0800, Joakim Zhang wrote:
> FlexCAN on i.MX8MP is not derived from i.MX6Q, instead resues from

s/resues/reuses/ I guess

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: [PATCH V2] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN

[Joakim Zhang]

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Sent: 2021年7月17日 1:48
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> mkl@pengutronix.de; Aisheng Dong <aisheng.dong@nxp.com>;
> devicetree@vger.kernel.org; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; kernel@pengutronix.de
> Subject: Re: [PATCH V2] arm64: dts: imx8mp: remove fallback compatible
> string for FlexCAN
> 
> On Fri, Jul 16, 2021 at 06:04:14PM +0800, Joakim Zhang wrote:
> > FlexCAN on i.MX8MP is not derived from i.MX6Q, instead resues from
> 
> s/resues/reuses/ I guess

Yes, not found by checkpatch.pl, I will correct and resend it. thanks.

Joakim Zhang
> 
> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                           | Uwe Kleine-König
> |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |