From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F13DFC4338F for ; Mon, 9 Aug 2021 19:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D50F760EB5 for ; Mon, 9 Aug 2021 19:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233947AbhHIThg (ORCPT ); Mon, 9 Aug 2021 15:37:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:50934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232334AbhHIThf (ORCPT ); Mon, 9 Aug 2021 15:37:35 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5187960C51; Mon, 9 Aug 2021 19:37:12 +0000 (UTC) Date: Mon, 9 Aug 2021 20:40:04 +0100 From: Jonathan Cameron To: Simon Xue Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, Johan Jonker , Heiko Stuebner , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, David Wu Subject: Re: [PATCH v3] iio: adc: rockchip_saradc: add voltage notifier so get referenced voltage once at probe Message-ID: <20210809203952.08d9acec@jic23-huawei> In-Reply-To: <20210809011517.6374-1-xxm@rock-chips.com> References: <20210809011517.6374-1-xxm@rock-chips.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 9 Aug 2021 09:15:17 +0800 Simon Xue wrote: > From: David Wu > > Add voltage notifier, no need to query regulator voltage for > every saradc read, just get regulator voltage once at probe. > > Signed-off-by: David Wu > Signed-off-by: Simon Xue > Reviewed-by: Heiko Stuebner Was just about to apply this, but noticed one last thing :( See inline. > --- > drivers/iio/adc/rockchip_saradc.c | 46 ++++++++++++++++++++++++++----- > 1 file changed, 39 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > index f3eb8d2e50dc..33c7dd635eb9 100644 > --- a/drivers/iio/adc/rockchip_saradc.c > +++ b/drivers/iio/adc/rockchip_saradc.c > @@ -49,10 +49,12 @@ struct rockchip_saradc { > struct clk *clk; > struct completion completion; > struct regulator *vref; > + int uv_vref; > struct reset_control *reset; > const struct rockchip_saradc_data *data; > u16 last_val; > const struct iio_chan_spec *last_chan; > + struct notifier_block nb; > }; > > static void rockchip_saradc_power_down(struct rockchip_saradc *info) > @@ -105,13 +107,7 @@ static int rockchip_saradc_read_raw(struct iio_dev *indio_dev, > mutex_unlock(&indio_dev->mlock); > return IIO_VAL_INT; > case IIO_CHAN_INFO_SCALE: > - ret = regulator_get_voltage(info->vref); > - if (ret < 0) { > - dev_err(&indio_dev->dev, "failed to get voltage\n"); > - return ret; > - } > - > - *val = ret / 1000; > + *val = info->uv_vref / 1000; > *val2 = chan->scan_type.realbits; > return IIO_VAL_FRACTIONAL_LOG2; > default: > @@ -298,6 +294,26 @@ static irqreturn_t rockchip_saradc_trigger_handler(int irq, void *p) > return IRQ_HANDLED; > } > > +static int rockchip_saradc_volt_notify(struct notifier_block *nb, > + unsigned long event, > + void *data) > +{ > + struct rockchip_saradc *info = > + container_of(nb, struct rockchip_saradc, nb); > + > + if (event & REGULATOR_EVENT_VOLTAGE_CHANGE) > + info->uv_vref = (unsigned long)data; > + > + return NOTIFY_OK; > +} > + > +static void rockchip_saradc_regulator_action(void *data) This is not a well named function. What is 'action'? Perhaps rockchip_saradc_reg_unreg_notifier() or something along those lines? > +{ > + struct rockchip_saradc *info = data; > + > + regulator_unregister_notifier(info->vref, &info->nb); > +} > + > static int rockchip_saradc_probe(struct platform_device *pdev) > { > struct rockchip_saradc *info = NULL; > @@ -410,6 +426,12 @@ static int rockchip_saradc_probe(struct platform_device *pdev) > return ret; > } > > + ret = regulator_get_voltage(info->vref); > + if (ret < 0) > + return ret; > + > + info->uv_vref = ret; > + > ret = clk_prepare_enable(info->pclk); > if (ret < 0) { > dev_err(&pdev->dev, "failed to enable pclk\n"); > @@ -450,6 +472,16 @@ static int rockchip_saradc_probe(struct platform_device *pdev) > if (ret) > return ret; > > + info->nb.notifier_call = rockchip_saradc_volt_notify; > + ret = regulator_register_notifier(info->vref, &info->nb); > + if (ret) > + return ret; > + > + ret = devm_add_action_or_reset(&pdev->dev, > + rockchip_saradc_regulator_action, info); > + if (ret) > + return ret; > + > return devm_iio_device_register(&pdev->dev, indio_dev); > } >