devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Leo Li <leoyang.li@nxp.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Kettenis <mark.kettenis@xs4all.nl>,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART
Date: Sat, 14 Aug 2021 12:47:04 +0800	[thread overview]
Message-ID: <20210814044703.GU30984@dragon> (raw)
In-Reply-To: <AS8PR04MB8946D0EB15D631346F4D13198FF69@AS8PR04MB8946.eurprd04.prod.outlook.com>

On Mon, Aug 09, 2021 at 10:52:04PM +0000, Leo Li wrote:
> 
> 
> > -----Original Message-----
> > From: Zhen Lei <thunder.leizhen@huawei.com>
> > Sent: Tuesday, June 15, 2021 8:16 AM
> > To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
> > Herring <robh+dt@kernel.org>; Mark Kettenis <mark.kettenis@xs4all.nl>;
> > devicetree <devicetree@vger.kernel.org>; linux-arm-kernel <linux-arm-
> > kernel@lists.infradead.org>; linux-kernel <linux-kernel@vger.kernel.org>
> > Cc: Zhen Lei <thunder.leizhen@huawei.com>
> > Subject: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of
> > LX2160A UART
> > 
> > Mark Kettenis told us that:
> > According to the NXP documentation, the LX2160A has a real PL011 UART.
> > 
> > Therefore, rewrite it to the compatible string of pl011. The property "current-
> > speed" specific to "arm,sbsa-uart" is also deleted.
> 
> Sorry that I missed the discussion on the v1.  But looks like this change breaks the LX2160 boot.  The AMBA matching doesn't seem to work.  And the console is not registered correctly.
> 
> [    0.639055] OF: amba_device_add() failed (-2) for /soc/serial@21c0000
> [    0.645612] OF: amba_device_add() failed (-2) for /soc/serial@21d0000

Patch dropped.

Shawn

      parent reply	other threads:[~2021-08-14  4:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 13:16 [PATCH v2 0/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART Zhen Lei
2021-06-15 13:16 ` [PATCH v2 1/1] " Zhen Lei
2021-07-14  7:22   ` Shawn Guo
2021-08-09 22:52   ` Leo Li
2021-08-10  1:28     ` Leizhen (ThunderTown)
2021-08-10  3:38       ` Leo Li
2021-08-12 23:09         ` Li Yang
2021-08-14  4:47     ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210814044703.GU30984@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=robh+dt@kernel.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).