From: "Alvin Šipraga" <alvin@pqrs.dk>
To: Linus Walleij <linus.walleij@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: mir@bang-olufsen.dk, alvin@pqrs.dk,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH net-next 0/5] net: dsa: add support for RTL8365MB-VC
Date: Sun, 22 Aug 2021 21:31:38 +0200 [thread overview]
Message-ID: <20210822193145.1312668-1-alvin@pqrs.dk> (raw)
From: Alvin Šipraga <alsi@bang-olufsen.dk>
This series adds support for Realtek's RTL8365MB-VC, a 4+1 port
10/100/1000M Ethernet switch. The driver - rtl8365mb - was developed by
Michael Ramussen and myself.
Summary of patches:
- The first patch in the series is a bugfix in realtek-smi which I
found when writing the new rtl8365mb subdriver and building
realtek-smi as a module. If desired, I can spin it off into a
separate patch and target it for net (not net-next).
- The second patch updates the dt-bindings for the new compatible
string.
- The third patch adds the 8 byte tag protocol driver.
- The fourth patch adds the rtl8365mb subdriver - the main feature of
this patch series.
- The fifth patch adds a PHY driver for the internal PHYs found in the
RTL8365MB-VC. This is not strictly necessary for the rtl8365mb
driver to work, but it avoids using the poll-only Generic PHY driver
directly by hooking into the IRQs made available by the switch
driver.
This is my first time in the DSA subsystem, so I am submitting this as
an RFC patch series for now. Apologies if I have made some terrible
mistakes along the way. All feedback - no matter how minor - is thus
very welcome.
There is a lot more work that can be done on this driver, particularly
when it comes to offloading certain DSA features to the hardware. I
intend to revisit this later when I have more time. In the mean time,
the driver seems to be in a good enough state for upstream submission.
Finally, there is an outstanding issue in probing the PHY driver when
fw_devlink=on. This seems to be a generic problem with DSA drivers which
create a dependency between an internal interrupt-controller and child
PHY nodes, realtek-smi being one of them. See [1] for an ongoing
discussion about that. Since this seems to be an existing problem and
not unique to this new driver, I hope that it will not impede the
upstreaming of this patch series.
[1] https://lore.kernel.org/netdev/cd0d9c40-d07b-e2ab-b068-d0bcb4685d09@bang-olufsen.dk/
Alvin Šipraga (5):
net: dsa: realtek-smi: fix mdio_free bug on module unload
dt-bindings: net: dsa: realtek-smi: document new compatible rtl8365mb
net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tag
net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC
net: phy: realtek: add support for RTL8365MB-VC internal PHYs
.../bindings/net/dsa/realtek-smi.txt | 1 +
drivers/net/dsa/Kconfig | 1 +
drivers/net/dsa/Makefile | 2 +-
drivers/net/dsa/realtek-smi-core.c | 10 +
drivers/net/dsa/realtek-smi-core.h | 2 +
drivers/net/dsa/rtl8365mb.c | 2124 +++++++++++++++++
drivers/net/dsa/rtl8366rb.c | 8 +
drivers/net/phy/realtek.c | 8 +
include/net/dsa.h | 2 +
net/dsa/Kconfig | 6 +
net/dsa/Makefile | 1 +
net/dsa/tag_rtl8_4.c | 178 ++
12 files changed, 2342 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/dsa/rtl8365mb.c
create mode 100644 net/dsa/tag_rtl8_4.c
--
2.32.0
next reply other threads:[~2021-08-22 19:32 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 19:31 Alvin Šipraga [this message]
2021-08-22 19:31 ` [RFC PATCH net-next 1/5] net: dsa: realtek-smi: fix mdio_free bug on module unload Alvin Šipraga
2021-08-22 21:40 ` Andrew Lunn
2021-08-22 22:33 ` Alvin Šipraga
2021-08-22 23:16 ` Andrew Lunn
2021-08-27 22:06 ` Linus Walleij
2021-08-28 10:50 ` Alvin Šipraga
2021-08-22 21:54 ` Vladimir Oltean
2021-08-22 22:42 ` Alvin Šipraga
2021-08-22 23:10 ` Vladimir Oltean
2021-08-22 19:31 ` [RFC PATCH net-next 2/5] dt-bindings: net: dsa: realtek-smi: document new compatible rtl8365mb Alvin Šipraga
2021-08-22 21:44 ` Andrew Lunn
2021-08-23 10:15 ` Florian Fainelli
2021-08-24 16:51 ` Rob Herring
2021-08-27 22:08 ` Linus Walleij
2021-08-22 19:31 ` [RFC PATCH net-next 3/5] net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tag Alvin Šipraga
2021-08-22 22:02 ` Andrew Lunn
2021-08-22 22:50 ` Alvin Šipraga
2021-08-22 23:14 ` Andrew Lunn
2021-08-22 23:27 ` Alvin Šipraga
2021-08-22 22:13 ` Vladimir Oltean
2021-08-22 23:11 ` Alvin Šipraga
2021-08-22 23:25 ` Vladimir Oltean
2021-08-22 23:37 ` Alvin Šipraga
2021-08-22 23:45 ` Vladimir Oltean
2021-08-23 0:28 ` Alvin Šipraga
2021-08-23 0:31 ` Vladimir Oltean
2021-08-22 19:31 ` [RFC PATCH net-next 4/5] net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC Alvin Šipraga
2021-08-22 22:48 ` Vladimir Oltean
2021-08-22 23:56 ` Alvin Šipraga
2021-08-23 0:19 ` Vladimir Oltean
2021-08-23 1:22 ` Alvin Šipraga
2021-08-23 2:12 ` Vladimir Oltean
2021-08-23 10:06 ` Alvin Šipraga
2021-08-23 10:31 ` Vladimir Oltean
2021-08-23 10:54 ` Alvin Šipraga
2021-08-23 13:13 ` Andrew Lunn
2021-08-23 13:20 ` Alvin Šipraga
2021-08-27 22:24 ` Linus Walleij
2021-08-22 23:04 ` Andrew Lunn
2021-08-22 23:25 ` Alvin Šipraga
2021-08-23 1:14 ` Andrew Lunn
2021-08-23 10:08 ` Alvin Šipraga
2021-08-23 4:37 ` DENG Qingfang
2021-08-23 10:11 ` Alvin Šipraga
2021-08-22 19:31 ` [RFC PATCH net-next 5/5] net: phy: realtek: add support for RTL8365MB-VC internal PHYs Alvin Šipraga
2021-08-23 10:13 ` Florian Fainelli
2021-08-27 22:27 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210822193145.1312668-1-alvin@pqrs.dk \
--to=alvin@pqrs.dk \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mir@bang-olufsen.dk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).