public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Saenz Julienne <nsaenzju@redhat.com>
To: robh+dt@kernel.org, nsaenz@kernel.org, f.fainelli@gmail.com
Cc: gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stefan.wahren@i2se.com,
	Nicolas Saenz Julienne <nsaenzju@redhat.com>
Subject: [PATCH] ARM: dts: bcm2711-rpi-4-b: Fix pcie0's unit address
Date: Mon, 30 Aug 2021 12:39:09 +0200	[thread overview]
Message-ID: <20210830103909.323356-1-nsaenzju@redhat.com> (raw)

dtbs_check currently complains that:

arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning
(pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format
error, expected "0,0"

Unsurprisingly pci@0,0 is the right address, as illustrated by its reg
property:

	&pcie0 {
		pci@0,0 {
			/*
			 * As defined in the IEEE Std 1275-1994 document,
			 * reg is a five-cell address encoded as (phys.hi
			 * phys.mid phys.lo size.hi size.lo). phys.hi
			 * should contain the device's BDF as 0b00000000
			 * bbbbbbbb dddddfff 00000000. The other cells
			 * should be zero.
			 */
			reg = <0 0 0 0 0>;
		};
	};

The bus is clearly 0. So fix it.

Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node")
Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com>
---
 arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
index f24bdd0870a5..8a77f9e942be 100644
--- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
+++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
@@ -217,7 +217,7 @@ phy1: ethernet-phy@1 {
 };
 
 &pcie0 {
-	pci@1,0 {
+	pci@0,0 {
 		#address-cells = <3>;
 		#size-cells = <2>;
 		ranges;
-- 
2.31.1


             reply	other threads:[~2021-08-30 10:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 10:39 Nicolas Saenz Julienne [this message]
2021-08-30 13:39 ` [PATCH] ARM: dts: bcm2711-rpi-4-b: Fix pcie0's unit address Rob Herring
2021-08-30 13:52   ` nsaenzju
2021-08-30 16:45   ` nsaenzju
2021-08-30 21:56     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830103909.323356-1-nsaenzju@redhat.com \
    --to=nsaenzju@redhat.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nsaenz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox