From: Jonathan Cameron <jic23@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
bcousson@baylibre.com, Tony Lindgren <tony@atomide.com>,
Tero Kristo <t-kristo@ti.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
"Ryan J . Barnett" <ryan.barnett@collins.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, linux-omap@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 05/40] dt-bindings: touchscreen: ti,am3359-tsc: Remove deprecated text file
Date: Mon, 30 Aug 2021 13:39:06 +0100 [thread overview]
Message-ID: <20210830133906.6638d794@jic23-huawei> (raw)
In-Reply-To: <20210825152518.379386-6-miquel.raynal@bootlin.com>
On Wed, 25 Aug 2021 17:24:43 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Now that the three hardware peaces described in this file have been
> translated in yaml in 3 dedicated files (MFD, touchscreen controller and
> ADC) it is time to remove this text file.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Nice to have another one of these go away :)
> ---
> .../bindings/input/touchscreen/ti-tsc-adc.txt | 91 -------------------
> 1 file changed, 91 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> deleted file mode 100644
> index aad5e34965eb..000000000000
> --- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> +++ /dev/null
> @@ -1,91 +0,0 @@
> -* TI - TSC ADC (Touschscreen and analog digital converter)
> -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> -
> -Required properties:
> -- mfd
> - compatible: Should be
> - "ti,am3359-tscadc" for AM335x/AM437x SoCs
> - "ti,am654-tscadc", "ti,am3359-tscadc" for AM654 SoCs
> -- child "tsc"
> - compatible: Should be "ti,am3359-tsc".
> - ti,wires: Wires refer to application modes i.e. 4/5/8 wire touchscreen
> - support on the platform.
> - ti,x-plate-resistance: X plate resistance
> - ti,coordinate-readouts: The sequencer supports a total of 16
> - programmable steps each step is used to
> - read a single coordinate. A single
> - readout is enough but multiple reads can
> - increase the quality.
> - A value of 5 means, 5 reads for X, 5 for
> - Y and 2 for Z (always). This utilises 12
> - of the 16 software steps available. The
> - remaining 4 can be used by the ADC.
> - ti,wire-config: Different boards could have a different order for
> - connecting wires on touchscreen. We need to provide an
> - 8 bit number where in the 1st four bits represent the
> - analog lines and the next 4 bits represent positive/
> - negative terminal on that input line. Notations to
> - represent the input lines and terminals resoectively
> - is as follows:
> - AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
> - XP = 0, XN = 1, YP = 2, YN = 3.
> -- child "adc"
> - compatible: Should be
> - "ti,am3359-adc" for AM335x/AM437x SoCs
> - "ti,am654-adc", "ti,am3359-adc" for AM654 SoCs
> - ti,adc-channels: List of analog inputs available for ADC.
> - AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
> -
> -Optional properties:
> -- child "tsc"
> - ti,charge-delay: Length of touch screen charge delay step in terms of
> - ADC clock cycles. Charge delay value should be large
> - in order to avoid false pen-up events. This value
> - effects the overall sampling speed, hence need to be
> - kept as low as possible, while avoiding false pen-up
> - event. Start from a lower value, say 0x400, and
> - increase value until false pen-up events are avoided.
> - The pen-up detection happens immediately after the
> - charge step, so this does in fact function as a
> - hardware knob for adjusting the amount of "settling
> - time".
> -
> -- child "adc"
> - ti,chan-step-opendelay: List of open delays for each channel of
> - ADC in the order of ti,adc-channels. The
> - value corresponds to the number of ADC
> - clock cycles to wait after applying the
> - step configuration registers and before
> - sending the start of ADC conversion.
> - Maximum value is 0x3FFFF.
> - ti,chan-step-sampledelay: List of sample delays for each channel
> - of ADC in the order of ti,adc-channels.
> - The value corresponds to the number of
> - ADC clock cycles to sample (to hold
> - start of conversion high).
> - Maximum value is 0xFF.
> - ti,chan-step-avg: Number of averages to be performed for each
> - channel of ADC. If average is 16 then input
> - is sampled 16 times and averaged to get more
> - accurate value. This increases the time taken
> - by ADC to generate a sample. Valid range is 0
> - average to 16 averages. Maximum value is 16.
> -
> -Example:
> - tscadc: tscadc@44e0d000 {
> - compatible = "ti,am3359-tscadc";
> - tsc {
> - ti,wires = <4>;
> - ti,x-plate-resistance = <200>;
> - ti,coordiante-readouts = <5>;
> - ti,wire-config = <0x00 0x11 0x22 0x33>;
> - ti,charge-delay = <0x400>;
> - };
> -
> - adc {
> - ti,adc-channels = <4 5 6 7>;
> - ti,chan-step-opendelay = <0x098 0x3ffff 0x098 0x0>;
> - ti,chan-step-sampledelay = <0xff 0x0 0xf 0x0>;
> - ti,chan-step-avg = <16 2 4 8>;
> - };
> - }
next prev parent reply other threads:[~2021-08-30 12:36 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 15:24 [PATCH 00/40] TI AM437X ADC1 Miquel Raynal
2021-08-25 15:24 ` [PATCH 01/40] clk: ti: am43xx: Add clkctrl data for am43xx ADC1 Miquel Raynal
2021-08-25 15:24 ` [PATCH 02/40] dt-bindings: mfd: ti,am3359-tscadc: Add a yaml description for this MFD Miquel Raynal
2021-08-30 12:47 ` Jonathan Cameron
2021-09-02 17:35 ` Miquel Raynal
2021-08-31 19:33 ` Rob Herring
2021-08-25 15:24 ` [PATCH 03/40] dt-bindings: touchscreen: ti,am3359-tsc: New yaml description Miquel Raynal
2021-08-30 13:36 ` Jonathan Cameron
2021-09-02 17:45 ` Miquel Raynal
2021-09-05 11:58 ` Jonathan Cameron
2021-08-31 19:37 ` Rob Herring
2021-09-01 7:42 ` Miquel Raynal
2021-08-25 15:24 ` [PATCH 04/40] dt-bindings: iio: adc: ti,am3359-adc: " Miquel Raynal
2021-08-30 12:31 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 05/40] dt-bindings: touchscreen: ti,am3359-tsc: Remove deprecated text file Miquel Raynal
2021-08-30 12:39 ` Jonathan Cameron [this message]
2021-08-31 19:38 ` Rob Herring
2021-08-25 15:24 ` [PATCH 06/40] dt-bindings: mfd: ti,am3359-tscadc: Describe am4372 MFD compatible Miquel Raynal
2021-08-30 12:34 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 07/40] dt-bindings: iio: adc: ti,am3359-adc: Describe am4372 ADC compatible Miquel Raynal
2021-08-30 12:35 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 08/40] mfd: ti_am335x_tscadc: Replace license text with SPDX tag Miquel Raynal
2021-08-30 12:38 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 09/40] mfd: ti_am335x_tscadc: Fix style Miquel Raynal
2021-08-30 12:49 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 10/40] mfd: ti_am335x_tscadc: Drop extra spacing when declaring stack variables Miquel Raynal
2021-08-30 12:52 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 11/40] mfd: ti_am335x_tscadc: Get rid of useless gotos Miquel Raynal
2021-08-30 13:39 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 12/40] mfd: ti_am335x_tscadc: Move the driver structure allocation earlier Miquel Raynal
2021-08-30 14:25 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 13/40] mfd: ti_am335x_tscadc: Reword the comment explaining the dividers Miquel Raynal
2021-08-30 13:43 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 14/40] mfd: ti_am335x_tscadc: Don't search the tree for our clock Miquel Raynal
2021-08-25 15:24 ` [PATCH 15/40] mfd: ti_am335x_tscadc: Simplify divisor calculation Miquel Raynal
2021-08-30 13:47 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 16/40] mfd: ti_am335x_tscadc: Use driver data Miquel Raynal
2021-08-30 14:46 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 17/40] mfd: ti_am335x_tscadc: Mimic the probe from resume() Miquel Raynal
2021-08-25 15:24 ` [PATCH 18/40] mfd: ti_am335x_tscadc: Drop useless variables from the driver structure Miquel Raynal
2021-08-25 15:24 ` [PATCH 19/40] mfd: ti_am335x_tscadc: Always provide an idle configuration Miquel Raynal
2021-08-30 14:49 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 20/40] mfd: ti_am335x_tscadc: Gather the ctrl register logic at one place Miquel Raynal
2021-08-30 13:56 ` Jonathan Cameron
2021-09-02 19:42 ` Miquel Raynal
2021-09-05 11:13 ` Jonathan Cameron
2021-08-25 15:24 ` [PATCH 21/40] mfd: ti_am335x_tscadc: Rename the subsystem enable macro Miquel Raynal
2021-08-30 14:50 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 22/40] mfd: ti_am335x_tscadc: Add TSC prefix in certain macros Miquel Raynal
2021-08-30 14:52 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 23/40] mfd: ti_am335x_tscadc: Rename a variable Miquel Raynal
2021-08-30 14:53 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 24/40] mfd: ti_am335x_tscadc: Fix an error message Miquel Raynal
2021-08-30 13:58 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 25/40] mfd: ti_am335x_tscadc: Add a boolean to clarify the presence of a touchscreen Miquel Raynal
2021-08-30 13:59 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 26/40] mfd: ti_am335x_tscadc: Introduce has_tsc Miquel Raynal
2021-08-30 14:02 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 27/40] mfd: ti_am335x_tscadc: Move control register configuration Miquel Raynal
2021-08-30 14:03 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 28/40] mfd: ti_am335x_tscadc: Add ADC1/magnetic reader support Miquel Raynal
2021-08-30 14:10 ` Jonathan Cameron
2021-09-02 18:31 ` Miquel Raynal
2021-09-02 20:03 ` Miquel Raynal
2021-09-01 19:26 ` Grygorii Strashko
2021-09-02 6:47 ` Miquel Raynal
2021-09-02 9:57 ` Grygorii Strashko
2021-08-25 15:25 ` [PATCH 29/40] mfd: ti_am335x_tscadc: Support the correctly spelled DT property Miquel Raynal
2021-08-30 14:11 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 30/40] iio: adc: ti_am335x_adc: Replace license text with SPDX tag Miquel Raynal
2021-08-30 14:12 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 31/40] iio: adc: ti_am335x_adc: Fix style Miquel Raynal
2021-08-30 14:16 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 32/40] iio: adc: ti_am335x_adc: Get rid of useless gotos Miquel Raynal
2021-08-30 14:18 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 33/40] iio: adc: ti_am335x_adc: Gather the checks on the delays Miquel Raynal
2021-08-30 14:19 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 34/40] iio: adc: ti_am335x_adc: Add a unit to the timeout delay Miquel Raynal
2021-08-30 14:20 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 35/40] iio: adc: ti_am335x_adc: Wait the idle state to avoid stalls Miquel Raynal
2021-08-30 14:22 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 36/40] iio: adc: ti_am335x_adc: Add the scale information Miquel Raynal
2021-08-30 14:23 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 37/40] iio: adc: ti_am335x_adc: Add the am437x compatible Miquel Raynal
2021-08-30 14:24 ` Jonathan Cameron
2021-08-25 15:25 ` [PATCH 38/40] ARM: dts: am437x-cm-t43: Use a correctly spelled DT property Miquel Raynal
2021-08-25 15:25 ` [PATCH 39/40] ARM: dts: am43xx: Describe the magnetic reader/ADC1 hardware module Miquel Raynal
2021-08-25 15:25 ` [PATCH 40/40] ARM: dts: am437x-gp-evm: enable ADC1 Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830133906.6638d794@jic23-huawei \
--to=jic23@kernel.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=ryan.barnett@collins.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox