Re: [PATCH v15 3/3] cpufreq: mediatek-hw: Add support for CPUFREQ HW

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3056 bytes --]

Hi Hector,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on soc/for-next]
[also build test ERROR on robh/for-next v5.14]
[cannot apply to pm/linux-next next-20210903]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hector-Yuan/dt-bindings-cpufreq-add-bindings-for-MediaTek-cpufreq-HW/20210903-174004
base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a7148c526ed4198bbe953fb17e52257f0d50d8c4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hector-Yuan/dt-bindings-cpufreq-add-bindings-for-MediaTek-cpufreq-HW/20210903-174004
        git checkout a7148c526ed4198bbe953fb17e52257f0d50d8c4
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/cpufreq/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/cpufreq/mediatek-cpufreq-hw.c:280:10: error: 'struct cpufreq_driver' has no member named 'register_em'
     280 |         .register_em    = mtk_cpufreq_register_em,
         |          ^~~~~~~~~~~
>> drivers/cpufreq/mediatek-cpufreq-hw.c:280:27: error: initialization of 'int (*)(struct cpufreq_policy *)' from incompatible pointer type 'void (*)(struct cpufreq_policy *)' [-Werror=incompatible-pointer-types]
     280 |         .register_em    = mtk_cpufreq_register_em,
         |                           ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/cpufreq/mediatek-cpufreq-hw.c:280:27: note: (near initialization for 'cpufreq_mtk_hw_driver.suspend')
   cc1: some warnings being treated as errors


vim +280 drivers/cpufreq/mediatek-cpufreq-hw.c

   270	
   271	static struct cpufreq_driver cpufreq_mtk_hw_driver = {
   272		.flags		= CPUFREQ_NEED_INITIAL_FREQ_CHECK |
   273				  CPUFREQ_HAVE_GOVERNOR_PER_POLICY |
   274				  CPUFREQ_IS_COOLING_DEV,
   275		.verify		= cpufreq_generic_frequency_table_verify,
   276		.target_index	= mtk_cpufreq_hw_target_index,
   277		.get		= mtk_cpufreq_hw_get,
   278		.init		= mtk_cpufreq_hw_cpu_init,
   279		.exit		= mtk_cpufreq_hw_cpu_exit,
 > 280		.register_em	= mtk_cpufreq_register_em,
   281		.fast_switch	= mtk_cpufreq_hw_fast_switch,
   282		.name		= "mtk-cpufreq-hw",
   283		.attr		= cpufreq_generic_attr,
   284	};
   285	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54084 bytes --]