From: Jonathan Cameron <jic23@kernel.org>
To: <Eugen.Hristev@microchip.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<Nicolas.Ferre@microchip.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
<Ludovic.Desroches@microchip.com>
Subject: Re: [PATCH v2 05/10] iio: adc: at91-sama5d2-adc: add support for separate end of conversion registers
Date: Sun, 5 Sep 2021 11:12:03 +0100 [thread overview]
Message-ID: <20210905111139.2b5ade8c@jic23-huawei> (raw)
In-Reply-To: <7d2607ce-4cfc-63f9-dad2-a5ef5c9538b5@microchip.com>
On Tue, 31 Aug 2021 06:45:01 +0000
<Eugen.Hristev@microchip.com> wrote:
> On 8/24/21 2:54 PM, Eugen Hristev wrote:
> > Some platforms have separated the end-of-conversion information from the
> > usual ISR/IMR/IER/IDR registers, into EOC_ISR/EOC_IMR/EOC_IER/EOC_IDR.
> > To cope with both variants, helpers are being added, that will make
> > code more clear and more easy to read.
> >
> > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> > ---
>
> Hi Jonathan,
>
> If you can still make changes on your testing branch, I noticed a typo
> in the shortcommit of this patch : 'at91-sama5d2-adc' instead of
> 'at91-sama5d2_adc' , grepping through commits in the future might miss
> this patch, so maybe you can change it ?
Testing is very much rebaseable. I won't push the tree out as something
I'm not happy to rebase until I have a stable base for it (after rc1).
So dropped v2. I'll get to v3 a bit later today probably.
Jonathan
>
> Thanks,
> Eugen
next prev parent reply other threads:[~2021-09-05 10:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 11:54 [PATCH v2 00/10] iio: adc: at91-sama5d2_adc: add support for sama7g5 Eugen Hristev
2021-08-24 11:54 ` [PATCH v2 01/10] dt-bindings: iio: adc: at91-sama5d2: add compatible for sama7g5-adc Eugen Hristev
2021-08-24 11:54 ` [PATCH v2 02/10] iio: adc: at91-sama5d2_adc: initialize hardware after clock is started Eugen Hristev
2021-08-24 11:54 ` [PATCH v2 03/10] iio: adc: at91-sama5d2_adc: remove unused definition Eugen Hristev
2021-08-24 11:54 ` [PATCH v2 04/10] iio: adc: at91-sama5d2_adc: convert to platform specific data structures Eugen Hristev
2021-08-30 12:21 ` Jonathan Cameron
2021-08-30 12:28 ` Eugen.Hristev
2021-08-30 12:31 ` Eugen.Hristev
2021-08-30 14:44 ` Jonathan Cameron
2021-08-31 11:50 ` Eugen.Hristev
2021-09-05 10:08 ` Jonathan Cameron
2021-08-24 11:54 ` [PATCH v2 05/10] iio: adc: at91-sama5d2-adc: add support for separate end of conversion registers Eugen Hristev
2021-08-31 6:45 ` Eugen.Hristev
2021-09-05 10:12 ` Jonathan Cameron [this message]
2021-08-24 11:54 ` [PATCH v2 06/10] iio: adc: at91-sama5d2_adc: add helper for COR register Eugen Hristev
2021-08-30 12:18 ` Jonathan Cameron
2021-08-24 11:54 ` [PATCH v2 07/10] iio: adc: at91-sama5d2_adc: add support for sama7g5 device Eugen Hristev
2021-08-24 11:54 ` [PATCH v2 08/10] iio: adc: at91-sama5d2_adc: update copyright and authors information Eugen Hristev
2021-08-24 11:54 ` [PATCH v2 09/10] ARM: dts: at91: sama7g5: add node for the ADC Eugen Hristev
2021-08-24 11:54 ` [PATCH v2 10/10] ARM: dts: at91: sama7g5ek: enable ADC on the board Eugen Hristev
2021-08-30 12:26 ` [PATCH v2 00/10] iio: adc: at91-sama5d2_adc: add support for sama7g5 Jonathan Cameron
2021-09-01 9:47 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210905111139.2b5ade8c@jic23-huawei \
--to=jic23@kernel.org \
--cc=Eugen.Hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).