From: Lucas Stach <l.stach@pengutronix.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Adam Ford <aford173@gmail.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Marek Vasut <marex@denx.de>, Tim Harvey <tharvey@gateworks.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, patchwork-lst@pengutronix.de
Subject: [PATCH v3 01/18] Revert "soc: imx: gpcv2: move reset assert after requesting domain power up"
Date: Mon, 6 Sep 2021 20:43:16 +0200 [thread overview]
Message-ID: <20210906184333.1855426-2-l.stach@pengutronix.de> (raw)
In-Reply-To: <20210906184333.1855426-1-l.stach@pengutronix.de>
This reverts commit a77ebdd9f553. It turns out that the VPU domain has no
different requirements, even though the downstream ATF implementation seems
to suggest otherwise. Powering on the domain with the reset asserted works
fine. As the changed sequence has caused sporadic issues with the GPU
domains, just revert the change to go back to the working sequence.
Cc: <stable@vger.kernel.org> # 5.14
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Acked-by: Peng Fan <peng.fan@nxp.com>
---
drivers/soc/imx/gpcv2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
index 34a9ac1f2b9b..8b7a01773aec 100644
--- a/drivers/soc/imx/gpcv2.c
+++ b/drivers/soc/imx/gpcv2.c
@@ -244,6 +244,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd)
goto out_regulator_disable;
}
+ reset_control_assert(domain->reset);
+
if (domain->bits.pxx) {
/* request the domain to power up */
regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ,
@@ -266,8 +268,6 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd)
GPC_PGC_CTRL_PCR);
}
- reset_control_assert(domain->reset);
-
/* delay for reset to propagate */
udelay(5);
--
2.30.2
next prev parent reply other threads:[~2021-09-06 18:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 18:43 [PATCH v3 00/18] i.MX8MM GPC improvements and BLK_CTRL driver Lucas Stach
2021-09-06 18:43 ` Lucas Stach [this message]
2021-09-06 18:43 ` [PATCH v3 02/18] soc: imx: gpcv2: Turn domain->pgc into bitfield Lucas Stach
2021-09-06 18:43 ` [PATCH v3 03/18] soc: imx: gpcv2: Set both GPC_PGC_nCTRL(GPU_2D|GPU_3D) for MX8MM GPU domain Lucas Stach
2021-09-06 18:43 ` [PATCH v3 04/18] soc: imx: gpcv2: add lockdep annotation Lucas Stach
2021-09-06 18:43 ` [PATCH v3 05/18] soc: imx: gpcv2: add domain option to keep domain clocks enabled Lucas Stach
2021-09-06 18:43 ` [PATCH v3 06/18] soc: imx: gpcv2: keep i.MX8M* bus " Lucas Stach
2021-09-06 18:43 ` [PATCH v3 07/18] soc: imx: gpcv2: support system suspend/resume Lucas Stach
2021-09-06 18:43 ` [PATCH v3 08/18] dt-bindings: soc: add binding for i.MX8MM VPU blk-ctrl Lucas Stach
2021-09-06 18:43 ` [PATCH v3 09/18] dt-bindings: power: imx8mm: add defines for VPU blk-ctrl domains Lucas Stach
2021-09-07 7:06 ` Frieder Schrempf
2021-09-07 8:11 ` Lucas Stach
2021-09-06 18:43 ` [PATCH v3 10/18] soc: imx: add i.MX8M blk-ctrl driver Lucas Stach
2021-09-07 7:28 ` Frieder Schrempf
2021-09-07 9:08 ` Philipp Zabel
2021-09-06 18:43 ` [PATCH v3 11/18] dt-bindings: soc: add binding for i.MX8MM DISP blk-ctrl Lucas Stach
2021-09-06 18:43 ` [PATCH v3 12/18] dt-bindings: power: imx8mm: add defines for DISP blk-ctrl domains Lucas Stach
2021-09-06 18:43 ` [PATCH v3 13/18] soc: imx: imx8m-blk-ctrl: add DISP blk-ctrl Lucas Stach
2021-09-06 18:43 ` [PATCH v3 14/18] arm64: dts: imx8mm: add GPC node Lucas Stach
2021-09-06 18:43 ` [PATCH v3 15/18] arm64: dts: imx8mm: put USB controllers into power-domains Lucas Stach
2021-09-06 18:43 ` [PATCH v3 16/18] arm64: dts: imx8mm: Add GPU nodes for 2D and 3D core Lucas Stach
2021-09-06 18:43 ` [PATCH v3 17/18] arm64: dts: imx8mm: add VPU blk-ctrl Lucas Stach
2021-09-06 18:43 ` [PATCH v3 18/18] arm64: dts: imx8mm: add DISP blk-ctrl Lucas Stach
2021-09-06 19:01 ` [PATCH v3 00/18] i.MX8MM GPC improvements and BLK_CTRL driver Fabio Estevam
2021-09-07 6:52 ` Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906184333.1855426-2-l.stach@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=patchwork-lst@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).