From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D7EC433EF for ; Tue, 7 Sep 2021 16:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2CBA61101 for ; Tue, 7 Sep 2021 16:35:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343793AbhIGQg4 convert rfc822-to-8bit (ORCPT ); Tue, 7 Sep 2021 12:36:56 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:44485 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231378AbhIGQg4 (ORCPT ); Tue, 7 Sep 2021 12:36:56 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 93BC560009; Tue, 7 Sep 2021 16:35:46 +0000 (UTC) Date: Tue, 7 Sep 2021 18:35:45 +0200 From: Miquel Raynal To: Grygorii Strashko Cc: Roger Quadros , , , , , , , , , , Subject: Re: [PATCH v3 5/8] dt-bindings: mtd: ti,gpmc-nand: Convert to yaml Message-ID: <20210907183545.3e281b7d@xps13> In-Reply-To: References: <20210907113226.31876-1-rogerq@kernel.org> <20210907113226.31876-6-rogerq@kernel.org> <20210907160317.2ec5304a@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Grygorii, > > > >> + > >> + nand-bus-width: > >> + description: > >> + Bus width to the NAND chip > >> + $ref: /schemas/types.yaml#/definitions/uint32 > >> + enum: [8, 16] > >> + default: 8 > > > > This is part of nand-controller.yaml binding and should not be there. > > > >> + > >> +allOf: > >> + - $ref: "../memory-controllers/ti,gpmc-child.yaml" > > > > Maybe you need to reference the nand controller bindings as well > > > > This will not work out of the box :( as nand-controller.yaml defines both > nand controller and nand memory. It potentially might work if it will be possible to split > nand memory definition (or nand memory properties) out of and-controller.yaml, similarly to > ti,gpmc-child.yaml from this series. What you think would be the issue? I am not opposed to split nand-controller.yaml into nand-controller.yaml and nand-chip.yaml if it simplifies the description of controllers but I don't get why it would be needed. In particular since we expect all drivers to support the nand-controller { controller-props; nand-chip { chip-props; } } organization which has been enforced since at least 2018. Having a controller vs. chip representation is fundamentally right. But here I see how "legacy" are these bindings with so much unneeded specific "ti," properties... On one side it would be good to verify that the driver supports this representation (which I believe is true) and on the other side maybe it's time to advertise "better" bindings as well. Thanks, Miquèl