Re: [PATCH v5 4/6] drivers: iio: dac: ad5766: Fix dt property name

Re: [PATCH v5 4/6] drivers: iio: dac: ad5766: Fix dt property name

[Jonathan Cameron]

On Fri, 17 Sep 2021 10:53:54 +0300
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:

> On Fri, Sep 17, 2021 at 9:11 AM Mihail Chindris
> <mihail.chindris@analog.com> wrote:
> >
> > In the documentation the name for the property is
> > output-range-microvolts which is a standard name, therefore this name
> > must be used.
> >  
> 
> This requires a Fixes tag.
> With that addressed:
> 
> Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Good catch. These cases are always a mess. 
As the binding doc went in with the driver, there should have been no window
in which anyone who was actually checking their DTS files against the yaml could
have this wrong. Hopefully that means we don't have any broken ones out there in the wild

As this is binding related, sensible to cc Rob and the dt list.
+CC


> 
> > Signed-off-by: Mihail Chindris <mihail.chindris@analog.com>
> > ---
> >  drivers/iio/dac/ad5766.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/dac/ad5766.c b/drivers/iio/dac/ad5766.c
> > index 3104ec32dfac..dafda84fdea3 100644
> > --- a/drivers/iio/dac/ad5766.c
> > +++ b/drivers/iio/dac/ad5766.c
> > @@ -503,13 +503,13 @@ static int ad5766_get_output_range(struct ad5766_state *st)
> >         int i, ret, min, max, tmp[2];
> >
> >         ret = device_property_read_u32_array(&st->spi->dev,
> > -                                            "output-range-voltage",
> > +                                            "output-range-microvolts",
> >                                              tmp, 2);
> >         if (ret)
> >                 return ret;
> >
> > -       min = tmp[0] / 1000;
> > -       max = tmp[1] / 1000;
> > +       min = tmp[0] / 1000000;
> > +       max = tmp[1] / 1000000;
> >         for (i = 0; i < ARRAY_SIZE(ad5766_span_tbl); i++) {
> >                 if (ad5766_span_tbl[i].min != min ||
> >                     ad5766_span_tbl[i].max != max)
> > --
> > 2.27.0
> >  

Re: [PATCH v5 5/6] Documentation:devicetree:bindings:iio:dac: Fix val

[Jonathan Cameron]

On Fri, 17 Sep 2021 10:53:02 +0300
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:

> On Fri, Sep 17, 2021 at 9:08 AM Mihail Chindris
> <mihail.chindris@analog.com> wrote:
> >
> > A correct value for output-range-microvolts is -5 to 5 Volts
> > not -5 to 5 milivolts
> >  
> 
> Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
+CC DT maintainer and list.

Please provide a suitable Fixes tag.

Thanks,

Jonathan


> 
> > Signed-off-by: Mihail Chindris <mihail.chindris@analog.com>
> > ---
> >  Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml
> > index d5c54813ce87..a8f7720d1e3e 100644
> > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml
> > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml
> > @@ -54,7 +54,7 @@ examples:
> >
> >            ad5766@0 {
> >                compatible = "adi,ad5766";
> > -              output-range-microvolts = <(-5000) 5000>;
> > +              output-range-microvolts = <(-5000000) 5000000>;
> >                reg = <0>;
> >                spi-cpol;
> >                spi-max-frequency = <1000000>;
> > --
> > 2.27.0
> >