From: Nishanth Menon <nm@ti.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Suman Anna <s-anna@ti.com>,
Sinthu Raja <sinthu.raja@mistralsolutions.com>,
Rob Herring <robh+dt@kernel.org>,
Baolin Wang <baolin.wang7@gmail.com>,
Ohad Ben-Cohen <ohad@wizery.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-remoteproc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Sinthu Raja <sinthu.raja@ti.com>
Subject: Re: [PATCH] dt-bindings: hwlock: omap: Remove board-specific compatible from DT example
Date: Wed, 22 Sep 2021 16:00:07 -0500 [thread overview]
Message-ID: <20210922210007.myuuwpwd7ltpdvtf@expanse> (raw)
In-Reply-To: <YUkE1TRVBxnLuktb@builder.lan>
On 17:01-20210920, Bjorn Andersson wrote:
> On Mon 20 Sep 16:14 CDT 2021, Suman Anna wrote:
>
> > On 9/17/21 9:44 AM, Nishanth Menon wrote:
> > > On 15:17-20210917, Sinthu Raja wrote:
> > >> From: Sinthu Raja <sinthu.raja@ti.com>
> > >>
> > >> The example includes a board-specific compatible property, this is
> > >> wrong as the example should be board agnostic. Replace the same with a
> > >> generic soc node.
> > >>
> > >> Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML")
> > >> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > >> ---
> > >>
> > >> This patch was triggered by discussions in [1].
> > >>
> > >> When applying the patch, if you could provide an immutable tag for the
> > >> bindings, it would help line things up for new platforms to be added for
> > >> us. See [2] for the context
> > >
> > >
> > > Aah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is
> > > bindings).
> >
> > Hmm, I don't think an immutable tag is needed for this patch. This is just
> > cleanup, what is your exact dependency here?
> >
> > The relevant HwSpinlock dts nodes are all upstream on all applicable platforms
> > already.
> >
>
> I agree and in general I think it's better to do DT validation against
> linux-next, as you would otherwise miss out on any newly introduced
> issues from inherited bindings etc.
I agree that an immutable commit is not needed on this specific patch.
The updated revision[1] posted had already dropped that request.
On the other hand, series[2] makes Rob's checks fail (as it runs on
rc1) - and helps keep everyone sane by getting an immutable commit
merged in allowing for follow on patches to stay clean.
NOTE: I do test patches for both checks and functionality to the best I
can on both rc1 (my tree)[3] and on linux-next on the day I pick the
patches up.
[1] https://lore.kernel.org/all/20210920123152.32751-1-sinthu.raja@ti.com/
[2] https://lore.kernel.org/all/20210917095426.19277-1-sinthu.raja@ti.com/
[3] https://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git/tree/
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2021-09-22 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 9:47 [PATCH] dt-bindings: hwlock: omap: Remove board-specific compatible from DT example Sinthu Raja
2021-09-17 14:44 ` Nishanth Menon
2021-09-20 21:14 ` Suman Anna
2021-09-20 22:01 ` Bjorn Andersson
2021-09-22 21:00 ` Nishanth Menon [this message]
2021-09-17 15:12 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210922210007.myuuwpwd7ltpdvtf@expanse \
--to=nm@ti.com \
--cc=baolin.wang7@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=sinthu.raja@mistralsolutions.com \
--cc=sinthu.raja@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).