From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD944C433F5 for ; Thu, 23 Sep 2021 08:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C805261216 for ; Thu, 23 Sep 2021 08:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239841AbhIWIU6 convert rfc822-to-8bit (ORCPT ); Thu, 23 Sep 2021 04:20:58 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:50389 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237996AbhIWIU5 (ORCPT ); Thu, 23 Sep 2021 04:20:57 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 1D09FE0007; Thu, 23 Sep 2021 08:19:22 +0000 (UTC) Date: Thu, 23 Sep 2021 10:19:22 +0200 From: Miquel Raynal To: Lee Jones Cc: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Dmitry Torokhov , bcousson@baylibre.com, Tony Lindgren , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, Thomas Petazzoni , Vignesh Raghavendra , Lokesh Vutla , Tero Kristo , Ryan Barnett , Grygorii Strashko , Jason Reeder , Jonathan Cameron Subject: Re: [PATCH v3 36/47] mfd: ti_am335x_tscadc: Support the correctly spelled DT property Message-ID: <20210923101922.2c108d2b@xps13> In-Reply-To: References: <20210915155908.476767-1-miquel.raynal@bootlin.com> <20210915155908.476767-37-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Lee, lee.jones@linaro.org wrote on Wed, 22 Sep 2021 16:57:10 +0100: > On Wed, 15 Sep 2021, Miquel Raynal wrote: > > > There was in the past a typo in the coordinate readouts property. The > > bindings have been updated, the touchscreen driver as well and now > > supports both. However, the MFD driver that is in charge of verifying > > the validity of the property only checks the bogus one. Add support for > > the correctly spelled DT property. > > > > Fixes: c9aeb249bf72 ("Input: ti_am335x_tsc - fix spelling mistake in TSC/ADC DT binding") > > Signed-off-by: Miquel Raynal > > Reviewed-by: Jonathan Cameron > > --- > > drivers/mfd/ti_am335x_tscadc.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > > index 155a8ed879b3..aa46ed669016 100644 > > --- a/drivers/mfd/ti_am335x_tscadc.c > > +++ b/drivers/mfd/ti_am335x_tscadc.c > > @@ -144,8 +144,14 @@ static int ti_tscadc_probe(struct platform_device *pdev) > > if (tscadc->data->has_tsc) { > > node = of_get_child_by_name(pdev->dev.of_node, "tsc"); > > of_property_read_u32(node, "ti,wires", &tscmag_wires); > > - of_property_read_u32(node, "ti,coordiante-readouts", &readouts); > > + err = of_property_read_u32(node, "ti,coordinate-readouts", > > + &readouts); > > + if (err < 0) > > + of_property_read_u32(node, "ti,coordiante-readouts", > > + &readouts); > > + > > How long are you proposing that we support this churn? Well, I am not proposing anything, I am just "fixing" the driver so that it fits the bindings :) Given the fact that at the end of this series there is a patch that changes the "coordiante" typo to "coordinate" in a device tree source file, I believe it is still too soon... Thanks, Miquèl