devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Adam Ford <aford173@gmail.com>
Cc: linux-omap@vger.kernel.org, hns@goldelico.com,
	aford@beaconembedded.com,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] ARM: dts: omap36xx: Remove turbo mode for 1GHz variants
Date: Fri, 1 Oct 2021 09:54:04 +0200	[thread overview]
Message-ID: <20211001095404.41f73d88@aktux> (raw)
In-Reply-To: <20210109170103.1249838-1-aford173@gmail.com>

On Sat,  9 Jan 2021 11:01:03 -0600
Adam Ford <aford173@gmail.com> wrote:

> Previously, the 1GHz variants were marked as a turbo,
> because that variant has reduced thermal operating range.
> 
> Now that the thermal throttling is in place, it should be
> safe to remove the turbo-mode from the 1GHz variants, because
> the CPU will automatically slow if the thermal limit is reached.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2:  The orignal patch had the wrong file added. Add the omap36xx.dtsi
> 
hmm, I somehow expected that there is a revert of this thing going
through. But now, the turbo-mode is still missing and I understood the
revert is only in Nikolaus' trees. The 1Ghz mode was working for some
time but does not anymore. Is it just me or do others also have the
same problems?

Regards,
Andreas

> diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
> index 05fe5ed127b0..20844dbc002e 100644
> --- a/arch/arm/boot/dts/omap36xx.dtsi
> +++ b/arch/arm/boot/dts/omap36xx.dtsi
> @@ -72,7 +72,6 @@ opp1g-1000000000 {
>  					 <1375000 1375000 1375000>;
>  			/* only on am/dm37x with speed-binned bit set */
>  			opp-supported-hw = <0xffffffff 2>;
> -			turbo-mode;
>  		};
>  	};
>  


  parent reply	other threads:[~2021-10-01  7:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09 17:01 [PATCH V2] ARM: dts: omap36xx: Remove turbo mode for 1GHz variants Adam Ford
2021-01-26 11:20 ` Tony Lindgren
2021-10-01  7:54 ` Andreas Kemnade [this message]
2021-10-01  9:59   ` H. Nikolaus Schaller
2021-10-02 12:12     ` Adam Ford
2021-10-07 18:00       ` Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001095404.41f73d88@aktux \
    --to=andreas@kemnade.info \
    --cc=aford173@gmail.com \
    --cc=aford@beaconembedded.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hns@goldelico.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).