From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 392F8C433EF for ; Mon, 4 Oct 2021 03:01:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10891610F9 for ; Mon, 4 Oct 2021 03:01:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232290AbhJDDDZ (ORCPT ); Sun, 3 Oct 2021 23:03:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232266AbhJDDDY (ORCPT ); Sun, 3 Oct 2021 23:03:24 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56267C061783 for ; Sun, 3 Oct 2021 20:01:36 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id g2so13251390pfc.6 for ; Sun, 03 Oct 2021 20:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TjNWNuR+gMWf2t1n3s/D7Jq0z4ZiFV+w9SGfLF5kxQg=; b=luns9ZSXpq0KwYmC30LME0ipn/Lhv8Yc/t39g1t4rSTQ+iFcOhBgGlExIX37NFUhbZ UaTJcfqDK0CKntIhETTytNStKpEhyWRnVsUW8cNqFrA8dzM5rgNDOQn5RW7cD4D/E63Y KrsltA8CCHxXkhKbsSNyFUrhxDCfowCmtCBTQ4hHx+YsmrwWUh2+HwiLk8Hs+wIhsQcm +wH+OiQMG8XFTB/o8n0eKyOUDztOs1MMG1bYOTKZEfosWVRY/egh6kHWy/rK9GzD7tGs HrwSr0yzEDxi5nSqgG+41GwZdW+eFpI/fGRp9/aHYhKcc24xmF1Sq9/GVnZd5cUhYhIa Jp/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TjNWNuR+gMWf2t1n3s/D7Jq0z4ZiFV+w9SGfLF5kxQg=; b=IRPPACXnvlWccJB1Q4SMrAo2y8mI3Y9mmJGUBmJATwcldtj+Xi3mP7yh6KOKcQ/CzO Wu3lvNaB0prYEF7JsxhgjUSEDCGTs9Yit95YSCXZ3coeT48+TXPycpnzb8DWobSlmP03 JeDKyrCnQv9kx0KEPU9ey5GlGwWGYovkYri9b87pyJMOIkBm+lagIgoCV9Cx5MTNyn3E TAzI6LKQW3Pe7NBdt42s7rbPDIcb4QRgKoUoTZEa/YHbnjtWuOrMgcHUdIM5kgxo4nSv DYVAKR6ZzVQdeoApWwbS0K7XWy+bigC42kYmeG4Uvva5Utvd5bGiPA/HggWYd26qM/Cf 8SmA== X-Gm-Message-State: AOAM531JjJrKh3sLw3USn7GOinEfSpAf5XmRZjg8z8sV75fMbE9+sAin dhVkrzP/fZybtX+q+zUfcfGLLw== X-Google-Smtp-Source: ABdhPJx8e9TmH82hx3DHUZCdh+Mi5WHU8V7twDoiKMJ9iWdcG6G1h07M6jVbiAmzYwvghqe9IEqi/A== X-Received: by 2002:a63:c5d:: with SMTP id 29mr5780720pgm.100.1633316495627; Sun, 03 Oct 2021 20:01:35 -0700 (PDT) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id t1sm11656919pgf.78.2021.10.03.20.01.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Oct 2021 20:01:35 -0700 (PDT) Date: Mon, 4 Oct 2021 11:01:29 +0800 From: Shawn Guo To: Vinod Koul Cc: Bjorn Andersson , AngeloGioacchino Del Regno , Konrad Dybcio , Jeffrey Hugo , Jami Kettunen , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] Add missing vdd-supply for QUSB2 PHY Message-ID: <20211004030128.GC13320@dragon> References: <20210928022002.26286-1-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Vinod, On Fri, Oct 01, 2021 at 01:46:23PM +0530, Vinod Koul wrote: > Hi Shawn, > > On 28-09-21, 10:19, Shawn Guo wrote: > > The series adds missing vdd-supply for QUSB2 PHY which is required for > > digital circuit. The driver works right now likely because firmware > > already sets it up. Add it to bindings, driver and DTS that miss the > > supply. > > > > It should not cause problem for existing DTBs: > > - SC7180, SDM630, SDM845 based platforms already specified vdd-supply > > in the DTBs. > > - MSM8996 and MSM8998 platform DTBs miss vdd-supply, but dummy regulator > > will ensure QUSB2 PHY driver works as before on these platforms. > > What about the rest.. I checked SM8350 and SM8250 mtp ones are missing > this. With the property made mandatory, I guess it would cause these to > fail right.. >From what I can see, SM8350 and SM8250 use qcom-snps-femto-v2 PHY rather than qcom-qusb2. So they should not be affected by this series. Shawn