From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23154C433F5 for ; Tue, 5 Oct 2021 07:09:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08DDD6154B for ; Tue, 5 Oct 2021 07:09:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232431AbhJEHLq (ORCPT ); Tue, 5 Oct 2021 03:11:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:51038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232561AbhJEHLp (ORCPT ); Tue, 5 Oct 2021 03:11:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E13861425; Tue, 5 Oct 2021 07:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633417795; bh=LolzeVyvQ9Fdg5AkSm3PkTTdmlFXrwEm0GL30clzJto=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GxilFPaiS6TAr3bQVhm56wzc4JTQjhYIvMLUUju0F9keWMASsTqBJHwvoAeWZytso Ur8dqOIpN+fTIf/wdtaPFZ0UTFw/lePh/6iKtPZQpDMYrttaVpHfyAyOw72sYVcNmQ mRHXK3IXIDTJUwxNyEfqn2W/2Sbk1Jag8/alf8pjr3JSV0NZ9PT2pN7njnXka7FMkp VOeUvM84aserRlVX5MRJBD5CQv70yEU+3ydIDnQWT0DZ7LdIr9xBFl51zKPfZQSUew +zSLr7O8WiPyBbJBjOCQeUnn+AT9lJvJIQr27kiO+Aa2PBONDGxVKGpnSSdUjAOE1D QdRa/lhHU2QiQ== Date: Tue, 5 Oct 2021 15:09:49 +0800 From: Shawn Guo To: Frieder Schrempf Cc: devicetree@vger.kernel.org, Frieder Schrempf , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH 4/8] arm64: dts: imx8mm-kontron: Fix reg_rst_eth2 and reg_vdd_5v regulators Message-ID: <20211005070949.GB20743@dragon> References: <20210930155633.2745201-1-frieder@fris.de> <20210930155633.2745201-5-frieder@fris.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210930155633.2745201-5-frieder@fris.de> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Sep 30, 2021 at 05:56:27PM +0200, Frieder Schrempf wrote: > From: Frieder Schrempf > > The regulator reg_vdd_5v represents the fixed 5V supply on the board which > can't be switched off. Mark it as always-on. > > The regulator reg_rst_eth2 should keep the reset signal of the USB ethernet > adapter deassertet anytime. Fix the polarity and mark it as always-on. It seems to be wrong from the beginning that the reset is modelled by a regulator. > > Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") > Cc: stable@vger.kernel.org > Signed-off-by: Frieder Schrempf > --- > arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > index 62ba3bd08a0c..f2c8ccefd1bf 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > @@ -70,7 +70,9 @@ reg_rst_eth2: regulator-rst-eth2 { > regulator-name = "rst-usb-eth2"; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usb_eth2>; > - gpio = <&gpio3 2 GPIO_ACTIVE_LOW>; > + gpio = <&gpio3 2 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + regulator-always-on; > }; > > reg_vdd_5v: regulator-5v { > @@ -78,6 +80,7 @@ reg_vdd_5v: regulator-5v { > regulator-name = "vdd-5v"; > regulator-min-microvolt = <5000000>; > regulator-max-microvolt = <5000000>; > + regulator-always-on; You do not have any on/off control over the regulator. So how does this always-on property make any difference? Shawn > }; > }; > > -- > 2.33.0 >