* [PATCH AUTOSEL 5.14 06/40] dt-bindings: interconnect: sdm660: Add missing a2noc qos clocks [not found] <20211005135020.214291-1-sashal@kernel.org> @ 2021-10-05 13:49 ` Sasha Levin 2021-10-05 19:11 ` Georgi Djakov 0 siblings, 1 reply; 3+ messages in thread From: Sasha Levin @ 2021-10-05 13:49 UTC (permalink / raw) To: linux-kernel, stable Cc: Shawn Guo, Rob Herring, AngeloGioacchino Del Regno, Georgi Djakov, Sasha Levin, agross, bjorn.andersson, robh+dt, kholk11, linux-arm-msm, linux-pm, devicetree From: Shawn Guo <shawn.guo@linaro.org> [ Upstream commit cf49e366020396ad83845c1c3bdbaa3c1406f5ce ] It adds the missing a2noc clocks required for QoS registers programming per downstream kernel[1]. [1] https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/sdm660-bus.dtsi?h=LA.UM.8.2.r1-04800-sdm660.0#n43 Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Reviewed-by: Rob Herring <robh@kernel.org> Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> Link: https://lore.kernel.org/r/20210824043435.23190-2-shawn.guo@linaro.org Signed-off-by: Georgi Djakov <djakov@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- .../bindings/interconnect/qcom,sdm660.yaml | 46 +++++++++++++++++-- 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml index 29de7807df54..bcd41e491f1d 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml @@ -31,11 +31,11 @@ properties: clocks: minItems: 1 - maxItems: 3 + maxItems: 7 clock-names: minItems: 1 - maxItems: 3 + maxItems: 7 required: - compatible @@ -72,6 +72,32 @@ allOf: contains: enum: - qcom,sdm660-a2noc + then: + properties: + clocks: + items: + - description: Bus Clock. + - description: Bus A Clock. + - description: IPA Clock. + - description: UFS AXI Clock. + - description: Aggregate2 UFS AXI Clock. + - description: Aggregate2 USB3 AXI Clock. + - description: Config NoC USB2 AXI Clock. + clock-names: + items: + - const: bus + - const: bus_a + - const: ipa + - const: ufs_axi + - const: aggre2_ufs_axi + - const: aggre2_usb3_axi + - const: cfg_noc_usb2_axi + + - if: + properties: + compatible: + contains: + enum: - qcom,sdm660-bimc - qcom,sdm660-cnoc - qcom,sdm660-gnoc @@ -91,6 +117,7 @@ examples: - | #include <dt-bindings/clock/qcom,rpmcc.h> #include <dt-bindings/clock/qcom,mmcc-sdm660.h> + #include <dt-bindings/clock/qcom,gcc-sdm660.h> bimc: interconnect@1008000 { compatible = "qcom,sdm660-bimc"; @@ -123,9 +150,20 @@ examples: compatible = "qcom,sdm660-a2noc"; reg = <0x01704000 0xc100>; #interconnect-cells = <1>; - clock-names = "bus", "bus_a"; + clock-names = "bus", + "bus_a", + "ipa", + "ufs_axi", + "aggre2_ufs_axi", + "aggre2_usb3_axi", + "cfg_noc_usb2_axi"; clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>, - <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>; + <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>, + <&rpmcc RPM_SMD_IPA_CLK>, + <&gcc GCC_UFS_AXI_CLK>, + <&gcc GCC_AGGRE2_UFS_AXI_CLK>, + <&gcc GCC_AGGRE2_USB3_AXI_CLK>, + <&gcc GCC_CFG_NOC_USB2_AXI_CLK>; }; mnoc: interconnect@1745000 { -- 2.33.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH AUTOSEL 5.14 06/40] dt-bindings: interconnect: sdm660: Add missing a2noc qos clocks 2021-10-05 13:49 ` [PATCH AUTOSEL 5.14 06/40] dt-bindings: interconnect: sdm660: Add missing a2noc qos clocks Sasha Levin @ 2021-10-05 19:11 ` Georgi Djakov 2021-10-06 15:12 ` Sasha Levin 0 siblings, 1 reply; 3+ messages in thread From: Georgi Djakov @ 2021-10-05 19:11 UTC (permalink / raw) To: Sasha Levin, linux-kernel, stable Cc: Shawn Guo, Rob Herring, AngeloGioacchino Del Regno, agross, bjorn.andersson, robh+dt, kholk11, linux-arm-msm, linux-pm, devicetree Hi Sasha, On 5.10.21 16:49, Sasha Levin wrote: > From: Shawn Guo <shawn.guo@linaro.org> > > [ Upstream commit cf49e366020396ad83845c1c3bdbaa3c1406f5ce ] > > It adds the missing a2noc clocks required for QoS registers programming > per downstream kernel[1]. > > [1] https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/sdm660-bus.dtsi?h=LA.UM.8.2.r1-04800-sdm660.0#n43 > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > Link: https://lore.kernel.org/r/20210824043435.23190-2-shawn.guo@linaro.org > Signed-off-by: Georgi Djakov <djakov@kernel.org> > Signed-off-by: Sasha Levin <sashal@kernel.org> There is no benefit to backport these changes, as devices that needed them, would not boot on v5.14 anyways. So please drop these: [PATCH AUTOSEL 5.14 06/40] dt-bindings: interconnect: sdm660: Add missing a2noc qos clocks [PATCH AUTOSEL 5.14 07/40] interconnect: qcom: sdm660: Add missing a2noc qos clocks Thanks, Georgi ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH AUTOSEL 5.14 06/40] dt-bindings: interconnect: sdm660: Add missing a2noc qos clocks 2021-10-05 19:11 ` Georgi Djakov @ 2021-10-06 15:12 ` Sasha Levin 0 siblings, 0 replies; 3+ messages in thread From: Sasha Levin @ 2021-10-06 15:12 UTC (permalink / raw) To: Georgi Djakov Cc: linux-kernel, stable, Shawn Guo, Rob Herring, AngeloGioacchino Del Regno, agross, bjorn.andersson, robh+dt, kholk11, linux-arm-msm, linux-pm, devicetree On Tue, Oct 05, 2021 at 10:11:31PM +0300, Georgi Djakov wrote: >Hi Sasha, > >On 5.10.21 16:49, Sasha Levin wrote: >>From: Shawn Guo <shawn.guo@linaro.org> >> >>[ Upstream commit cf49e366020396ad83845c1c3bdbaa3c1406f5ce ] >> >>It adds the missing a2noc clocks required for QoS registers programming >>per downstream kernel[1]. >> >>[1] https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/sdm660-bus.dtsi?h=LA.UM.8.2.r1-04800-sdm660.0#n43 >> >>Signed-off-by: Shawn Guo <shawn.guo@linaro.org> >>Reviewed-by: Rob Herring <robh@kernel.org> >>Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> >>Link: https://lore.kernel.org/r/20210824043435.23190-2-shawn.guo@linaro.org >>Signed-off-by: Georgi Djakov <djakov@kernel.org> >>Signed-off-by: Sasha Levin <sashal@kernel.org> > >There is no benefit to backport these changes, as devices that >needed them, would not boot on v5.14 anyways. So please drop these: > >[PATCH AUTOSEL 5.14 06/40] dt-bindings: interconnect: sdm660: Add >missing a2noc qos clocks >[PATCH AUTOSEL 5.14 07/40] interconnect: qcom: sdm660: Add missing >a2noc qos clocks I'll drop it, thanks! -- Thanks, Sasha ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-06 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211005135020.214291-1-sashal@kernel.org>
2021-10-05 13:49 ` [PATCH AUTOSEL 5.14 06/40] dt-bindings: interconnect: sdm660: Add missing a2noc qos clocks Sasha Levin
2021-10-05 19:11 ` Georgi Djakov
2021-10-06 15:12 ` Sasha Levin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).