public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Mihail Chindris <mihail.chindris@analog.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
	<lars@metafoo.de>, <Michael.Hennerich@analog.com>,
	<nuno.sa@analog.com>, <dragos.bogdan@analog.com>,
	<alexandru.ardelean@analog.com>, <robh+dt@kernel.org>,
	<devicetree@vger.kernel.org>,
	Alexandru Ardelean <ardeleanalex@gmail.com>
Subject: Re: [PATCH v6 4/6] drivers: iio: dac: ad5766: Fix dt property name
Date: Thu, 7 Oct 2021 16:51:23 +0100	[thread overview]
Message-ID: <20211007165123.023ecbc1@jic23-huawei> (raw)
In-Reply-To: <20211007080035.2531-5-mihail.chindris@analog.com>

On Thu, 7 Oct 2021 08:00:34 +0000
Mihail Chindris <mihail.chindris@analog.com> wrote:

> In the documentation the name for the property is
> output-range-microvolts which is a standard name, therefore this name
> must be used.
> 
> Fixes: fd9373e41b9ba ("iio: dac: ad5766: add driver support for AD5766")
> Signed-off-by: Mihail Chindris <mihail.chindris@analog.com>
> Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Applied this one to the fixes-togreg branch of iio.git and marked it for stable.

Thankfully this is (I think) far enough from the other changes that we
should be able to take the other patches through the togreg tree and have
them all meet up in linux-next / upstream.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ad5766.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/dac/ad5766.c b/drivers/iio/dac/ad5766.c
> index 3104ec32dfac..dafda84fdea3 100644
> --- a/drivers/iio/dac/ad5766.c
> +++ b/drivers/iio/dac/ad5766.c
> @@ -503,13 +503,13 @@ static int ad5766_get_output_range(struct ad5766_state *st)
>  	int i, ret, min, max, tmp[2];
>  
>  	ret = device_property_read_u32_array(&st->spi->dev,
> -					     "output-range-voltage",
> +					     "output-range-microvolts",
>  					     tmp, 2);
>  	if (ret)
>  		return ret;
>  
> -	min = tmp[0] / 1000;
> -	max = tmp[1] / 1000;
> +	min = tmp[0] / 1000000;
> +	max = tmp[1] / 1000000;
>  	for (i = 0; i < ARRAY_SIZE(ad5766_span_tbl); i++) {
>  		if (ad5766_span_tbl[i].min != min ||
>  		    ad5766_span_tbl[i].max != max)


  reply	other threads:[~2021-10-07 15:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211007080035.2531-1-mihail.chindris@analog.com>
2021-10-07  8:00 ` [PATCH v6 4/6] drivers: iio: dac: ad5766: Fix dt property name Mihail Chindris
2021-10-07 15:51   ` Jonathan Cameron [this message]
2021-10-07  8:00 ` [PATCH v6 5/6] Documentation:devicetree:bindings:iio:dac: Fix val Mihail Chindris
2021-10-07 15:53   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211007165123.023ecbc1@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=alexandru.ardelean@analog.com \
    --cc=ardeleanalex@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dragos.bogdan@analog.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihail.chindris@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox