From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Rob Herring" <robh+dt@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Prasanna Vengateshan" <prasanna.vengateshan@microchip.com>,
"Ansuel Smith" <ansuelsmth@gmail.com>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>
Subject: [PATCH net-next 0/6] New RGMII delay DT bindings for the SJA1105 DSA driver
Date: Thu, 14 Oct 2021 01:23:07 +0300 [thread overview]
Message-ID: <20211013222313.3767605-1-vladimir.oltean@nxp.com> (raw)
During recent reviews I've been telling people that new MAC drivers
should adopt a certain DT binding format for RGMII delays in order to
avoid conflicting interpretations. Some suggestions were better received
than others, and it appears we are still far from a consensus.
Part of the problem seems to be that there are still drivers that apply
RGMII delays based on an incorrect interpretation of the device tree,
and these serve as a bad example for others.
I happen to maintain one of those drivers and I am able to test it, so I
figure that one of the ways in which I can make a change is to stop
providing a bad example.
Therefore, this series adds support for the "rx-internal-delay-ps" and
"tx-internal-delay-ps" properties inside sja1105 switch port DT nodes,
and if these are present, they will decide what RGMII delays will the
driver apply.
The in-tree device trees are also updated to follow the new format, as
well as the schema validator.
I assume it's okay to get all changes merged in through the same tree
(net-next). Although the DTS changes could be split, if needed - the
driver works with or without them. There is one more DTS which should be
changed, which is in Shawn's tree but not in net-next:
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/tree/arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dts?h=for-next
For that, I'd have to send a separate patch.
Vladimir Oltean (6):
ARM: dts: imx6qp-prtwd3: update RGMII delays for sja1105 switch
ARM: dts: ls1021a-tsn: update RGMII delays for sja1105 switch
dt-bindings: net: dsa: sja1105: fix example so all ports have a
phy-handle of fixed-link
dt-bindings: net: dsa: inherit the ethernet-controller DT schema
dt-bindings: net: dsa: sja1105: add {rx,tx}-internal-delay-ps
net: dsa: sja1105: parse {rx,tx}-internal-delay-ps properties for
RGMII delays
.../devicetree/bindings/net/dsa/dsa.yaml | 7 ++
.../bindings/net/dsa/nxp,sja1105.yaml | 43 +++++++++
arch/arm/boot/dts/imx6qp-prtwd3.dts | 2 +
arch/arm/boot/dts/ls1021a-tsn.dts | 2 +
drivers/net/dsa/sja1105/sja1105.h | 25 ++++-
drivers/net/dsa/sja1105/sja1105_clocking.c | 35 +++----
drivers/net/dsa/sja1105/sja1105_main.c | 94 ++++++++++++++-----
7 files changed, 161 insertions(+), 47 deletions(-)
--
2.25.1
next reply other threads:[~2021-10-13 22:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 22:23 Vladimir Oltean [this message]
2021-10-13 22:23 ` [PATCH net-next 1/6] ARM: dts: imx6qp-prtwd3: update RGMII delays for sja1105 switch Vladimir Oltean
2021-10-15 17:16 ` Florian Fainelli
2021-10-13 22:23 ` [PATCH net-next 2/6] ARM: dts: ls1021a-tsn: " Vladimir Oltean
2021-10-15 17:16 ` Florian Fainelli
2021-10-13 22:23 ` [PATCH net-next 3/6] dt-bindings: net: dsa: sja1105: fix example so all ports have a phy-handle of fixed-link Vladimir Oltean
2021-10-15 16:51 ` Florian Fainelli
2021-10-13 22:23 ` [PATCH net-next 4/6] dt-bindings: net: dsa: inherit the ethernet-controller DT schema Vladimir Oltean
2021-10-15 16:51 ` Florian Fainelli
2021-10-13 22:23 ` [PATCH net-next 5/6] dt-bindings: net: dsa: sja1105: add {rx,tx}-internal-delay-ps Vladimir Oltean
2021-10-14 14:31 ` Rob Herring
2021-10-15 19:55 ` Jakub Kicinski
2021-10-15 22:48 ` Vladimir Oltean
2021-10-18 13:40 ` Rob Herring
2021-10-15 16:53 ` Florian Fainelli
2021-10-13 22:23 ` [PATCH net-next 6/6] net: dsa: sja1105: parse {rx,tx}-internal-delay-ps properties for RGMII delays Vladimir Oltean
2021-10-14 0:24 ` Jakub Kicinski
2021-10-14 12:00 ` Vladimir Oltean
2021-10-15 17:15 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013222313.3767605-1-vladimir.oltean@nxp.com \
--to=vladimir.oltean@nxp.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=prasanna.vengateshan@microchip.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).