From: Pavel Machek <pavel@ucw.cz>
To: "Marek Behún" <kabel@kernel.org>
Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>,
robh+dt@kernel.org, Jacek Anaszewski <jacek.anaszewski@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: leds: Add `excludes` property
Date: Thu, 14 Oct 2021 12:29:18 +0200 [thread overview]
Message-ID: <20211014102918.GA21116@duo.ucw.cz> (raw)
In-Reply-To: <20211013204424.10961-2-kabel@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
Hi!
> Some RJ-45 connectors have LEDs wired in the following way:
>
> LED1
> +--|>|--+
> | |
> A---+--|<|--+---B
> LED2
>
> With + on A and - on B, LED1 is ON and LED2 is OFF. Inverting the
> polarity turns LED1 OFF and LED2 ON.
>
> So these LEDs exclude each other.
>
> Add new `excludes` property to the LED binding. The property is a
> phandle-array to all the other LEDs that are excluded by this LED.
I don't think this belongs to the LED binding.
This is controller limitation, and the driver handling the controller
needs to know about it... so it does not need to learn that from the
LED binding.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-10-14 10:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 20:44 [PATCH 1/3] dt-bindings: leds: Deprecate `linux,default-trigger` property Marek Behún
2021-10-13 20:44 ` [PATCH 2/3] dt-bindings: leds: Add `excludes` property Marek Behún
2021-10-13 22:20 ` Rob Herring
2021-10-14 10:29 ` Pavel Machek [this message]
2021-10-14 10:43 ` Marek Behún
2021-10-14 11:30 ` Alexander Dahl
2021-10-14 11:58 ` Marek Behún
2021-10-13 20:44 ` [PATCH 3/3] dt-bindings: leds: Allow for multiple colors in the `color` property Marek Behún
2021-10-26 20:44 ` Rob Herring
2021-10-26 20:39 ` [PATCH 1/3] dt-bindings: leds: Deprecate `linux,default-trigger` property Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014102918.GA21116@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=kabel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).