From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0250FC433F5 for ; Fri, 15 Oct 2021 03:51:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC14B611CC for ; Fri, 15 Oct 2021 03:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235240AbhJODxk (ORCPT ); Thu, 14 Oct 2021 23:53:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:55204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235225AbhJODxk (ORCPT ); Thu, 14 Oct 2021 23:53:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D71D1611C3; Fri, 15 Oct 2021 03:51:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634269894; bh=HRiWV+8zHe2qqxJgo56IMSWbI8+MHo9yh+QgaaZsvtU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tDLwis3n2ThfcX1Fy8D9CxQP864NyJ4aDZk4T4GB5OCKNutkll8StU7Jzt/pwzlqT NGwEW/sjcxyqYXIUveg8eVYPh1QJ4ZKjt1tRR+0G9yZiG6uY08n+irsmU4mEmQ4JrQ mzyqiIg1aJCPfTMs9cWloY0ZuxsbC5lW/8GmlYyNX4MjEQBsypdLqbieDmwFoJSiJB UyMfAg5/8NuAVz21mewx7V9Wi00aGVdvkHRQ+s++S+38zVNWUby2Zsz9t1WajvOw5L bFKsBlV06WZm850pNoceMCnHFold8eri4UEfo7Pj1qmk60a69TOLdzU8XpJApRWGFU U4C1HjyoiTuxg== Date: Fri, 15 Oct 2021 11:51:27 +0800 From: Shawn Guo To: Frieder Schrempf Cc: Frieder Schrempf , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , Fabio Estevam , Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH 2/8] arm64: dts: imx8mm-kontron: Make sure SOC and DRAM supply voltages are correct Message-ID: <20211015035122.GE22881@dragon> References: <20210930155633.2745201-1-frieder@fris.de> <20210930155633.2745201-3-frieder@fris.de> <20211005065358.GZ20743@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Oct 05, 2021 at 03:10:14PM +0200, Frieder Schrempf wrote: > On 05.10.21 08:53, Shawn Guo wrote: > > On Thu, Sep 30, 2021 at 05:56:25PM +0200, Frieder Schrempf wrote: > >> From: Frieder Schrempf > >> > >> VDD_SOC should be 800 mV in suspend and 850 mV in run mode. VDD_DRAM > >> should be 950 mV for DDR clock frequencies of 1.5 GHz. > >> > >> This information is taken from the datasheet and the uboot-imx code. > > > > I'm wondering where the existing settings were coming from? > > Good question, but I can't really retrace now how I actually determined > the values back then. Seems like I had failed to validate them properly. Please update commit log with these background info. Shawn > > > > >> > >> Signed-off-by: Frieder Schrempf > >> --- > >> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 6 ++++-- > >> 1 file changed, 4 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > >> index 03b3516abd64..b12fb7ce6686 100644 > >> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > >> @@ -92,10 +92,12 @@ regulators { > >> reg_vdd_soc: BUCK1 { > >> regulator-name = "buck1"; > >> regulator-min-microvolt = <800000>; > >> - regulator-max-microvolt = <900000>; > >> + regulator-max-microvolt = <850000>; > >> regulator-boot-on; > >> regulator-always-on; > >> regulator-ramp-delay = <3125>; > >> + nxp,dvs-run-voltage = <850000>; > >> + nxp,dvs-standby-voltage = <800000>; > >> }; > >> > >> reg_vdd_arm: BUCK2 { > >> @@ -111,7 +113,7 @@ reg_vdd_arm: BUCK2 { > >> reg_vdd_dram: BUCK3 { > >> regulator-name = "buck3"; > >> regulator-min-microvolt = <850000>; > >> - regulator-max-microvolt = <900000>; > >> + regulator-max-microvolt = <950000>; > >> regulator-boot-on; > >> regulator-always-on; > >> }; > >> -- > >> 2.33.0 > >>