From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Adamski <krzysztof.adamski@nokia.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 2/9] hwmon: (tmp421) add support for defining labels from DT
Date: Fri, 15 Oct 2021 15:45:42 -0700 [thread overview]
Message-ID: <20211015224542.GA1484162@roeck-us.net> (raw)
In-Reply-To: <dab0fda6ac0e8d7f163c3762a7fb1e595a4d8159.1634206677.git.krzysztof.adamski@nokia.com>
On Thu, Oct 14, 2021 at 03:00:49PM +0200, Krzysztof Adamski wrote:
> tmp42x is a multichannel temperature sensor with several external
> channels. Since those channels can be used to connect diodes placed
> anywhere in the system, their meaning will vary depending on the
> project. For this case, the hwmon framework has an idea of labels which
> allows us to assign the meaning to each channel.
>
> The similar concept is already implemented in ina3221 - the label for
> each channel can be defined via device tree. See commit a9e9dd9c6de5
> ("hwmon: (ina3221) Read channel input source info from DT")
>
> This patch adds support for similar feature to tmp421.
>
> Signed-off-by: Krzysztof Adamski <krzysztof.adamski@nokia.com>
> ---
> drivers/hwmon/tmp421.c | 61 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c
> index 707310d616a4..89346ca6c9a9 100644
> --- a/drivers/hwmon/tmp421.c
> +++ b/drivers/hwmon/tmp421.c
> @@ -88,6 +88,7 @@ static const struct of_device_id __maybe_unused tmp421_of_match[] = {
> MODULE_DEVICE_TABLE(of, tmp421_of_match);
>
> struct tmp421_channel {
> + const char *label;
> s16 temp;
> };
git reports this patch as corrupted and claims it was hand-edited.
Looking into it, there is an extra space in unchanged lines of code.
Indeed, it applies cleanly after replacing douple spaces at the beginning
of each line with a single space.
No idea how that happened, but please be careful whend sending patches.
Applied.
Guenter
next prev parent reply other threads:[~2021-10-15 22:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 13:00 [PATCH v5 0/9] Add per channel properies support in tmp421 Krzysztof Adamski
2021-10-14 13:00 ` [PATCH v5 1/9] dt-bindings: hwmon: add missing tmp421 binding Krzysztof Adamski
2021-10-14 16:31 ` Rob Herring
2021-10-15 22:29 ` Guenter Roeck
2021-10-14 13:00 ` [PATCH v5 2/9] hwmon: (tmp421) add support for defining labels from DT Krzysztof Adamski
2021-10-15 22:45 ` Guenter Roeck [this message]
2021-10-14 13:01 ` [PATCH v5 3/9] hwmon: (tmp421) support disabling channels " Krzysztof Adamski
2021-10-15 22:47 ` Guenter Roeck
2021-10-17 0:00 ` Krzysztof Adamski
2021-10-14 13:01 ` [PATCH v5 4/9] hwmon: (tmp421) support specifying n-factor via DT Krzysztof Adamski
2021-10-15 22:49 ` Guenter Roeck
2021-10-14 13:09 ` [PATCH v5 5/9] hwmon: (tmp421) really disable channels Krzysztof Adamski
2021-10-15 22:53 ` Guenter Roeck
2021-10-14 13:09 ` [PATCH v5 6/9] hwmon: (tmp421) support HWMON_T_ENABLE Krzysztof Adamski
2021-10-15 22:53 ` Guenter Roeck
2021-10-14 13:10 ` [PATCH v5 7/9] hwmon: (tmp421) update documentation Krzysztof Adamski
2021-10-15 22:54 ` Guenter Roeck
2021-10-14 13:11 ` [PATCH v5 8/9] hwmon: (tmp421) ignore non-channel related DT nodes Krzysztof Adamski
2021-10-15 22:56 ` Guenter Roeck
2021-10-14 13:11 ` [PATCH v5 9/9] dt-bindings: hwmon: allow specifying channels for tmp421 Krzysztof Adamski
2021-10-14 16:31 ` Rob Herring
2021-10-15 22:57 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015224542.GA1484162@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.adamski@nokia.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).