devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Adamski <krzysztof.adamski@nokia.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 8/9] hwmon: (tmp421) ignore non-channel related DT nodes
Date: Fri, 15 Oct 2021 15:56:21 -0700	[thread overview]
Message-ID: <20211015225621.GA1486145@roeck-us.net> (raw)
In-Reply-To: <8e9e332b18dc2cf545f8e8255157e408d356f916.1634206677.git.krzysztof.adamski@nokia.com>

On Thu, Oct 14, 2021 at 03:11:02PM +0200, Krzysztof Adamski wrote:
> In case the DT contains some nodes not describing the input channels,
> ignore them instead of exiting with error.
> 
> Signed-off-by: Krzysztof Adamski <krzysztof.adamski@nokia.com>

Applied, after the usual fixup.

Guenter

> ---
>  drivers/hwmon/tmp421.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c
> index 2e20c558fcb0..493a24cdfca2 100644
> --- a/drivers/hwmon/tmp421.c
> +++ b/drivers/hwmon/tmp421.c
> @@ -414,6 +414,9 @@ static int tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *d
>  	int err;
>  
>  	for_each_child_of_node(np, child) {
> +		if (strcmp(child->name, "channel"))
> +			continue;
> +
>  		err = tmp421_probe_child_from_dt(client, child, data);
>  		if (err)
>  			return err;

  reply	other threads:[~2021-10-15 22:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14 13:00 [PATCH v5 0/9] Add per channel properies support in tmp421 Krzysztof Adamski
2021-10-14 13:00 ` [PATCH v5 1/9] dt-bindings: hwmon: add missing tmp421 binding Krzysztof Adamski
2021-10-14 16:31   ` Rob Herring
2021-10-15 22:29   ` Guenter Roeck
2021-10-14 13:00 ` [PATCH v5 2/9] hwmon: (tmp421) add support for defining labels from DT Krzysztof Adamski
2021-10-15 22:45   ` Guenter Roeck
2021-10-14 13:01 ` [PATCH v5 3/9] hwmon: (tmp421) support disabling channels " Krzysztof Adamski
2021-10-15 22:47   ` Guenter Roeck
2021-10-17  0:00     ` Krzysztof Adamski
2021-10-14 13:01 ` [PATCH v5 4/9] hwmon: (tmp421) support specifying n-factor via DT Krzysztof Adamski
2021-10-15 22:49   ` Guenter Roeck
2021-10-14 13:09 ` [PATCH v5 5/9] hwmon: (tmp421) really disable channels Krzysztof Adamski
2021-10-15 22:53   ` Guenter Roeck
2021-10-14 13:09 ` [PATCH v5 6/9] hwmon: (tmp421) support HWMON_T_ENABLE Krzysztof Adamski
2021-10-15 22:53   ` Guenter Roeck
2021-10-14 13:10 ` [PATCH v5 7/9] hwmon: (tmp421) update documentation Krzysztof Adamski
2021-10-15 22:54   ` Guenter Roeck
2021-10-14 13:11 ` [PATCH v5 8/9] hwmon: (tmp421) ignore non-channel related DT nodes Krzysztof Adamski
2021-10-15 22:56   ` Guenter Roeck [this message]
2021-10-14 13:11 ` [PATCH v5 9/9] dt-bindings: hwmon: allow specifying channels for tmp421 Krzysztof Adamski
2021-10-14 16:31   ` Rob Herring
2021-10-15 22:57   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211015225621.GA1486145@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzysztof.adamski@nokia.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).