From: DENG Qingfang <dqfext@gmail.com>
To: "Alvin Šipraga" <alvin@pqrs.dk>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 net-next 5/7] net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tag
Date: Sat, 16 Oct 2021 14:04:29 +0800 [thread overview]
Message-ID: <20211016060429.783447-1-dqfext@gmail.com> (raw)
In-Reply-To: <20211015171030.2713493-6-alvin@pqrs.dk>
On Fri, Oct 15, 2021 at 07:10:26PM +0200, Alvin Šipraga wrote:
> +static struct sk_buff *rtl8_4_tag_xmit(struct sk_buff *skb,
> + struct net_device *dev)
> +{
> + struct dsa_port *dp = dsa_slave_to_port(dev);
> + __be16 *tag;
> +
> + /* Pad out so the (stripped) packet is at least 64 bytes long
> + * (including FCS), otherwise the switch will drop the packet.
> + * Then we need an additional 8 bytes for the Realtek tag.
> + */
> + if (unlikely(__skb_put_padto(skb, ETH_ZLEN + RTL8_4_TAG_LEN, false)))
> + return NULL;
Is this still required if you set rtl8365mb_cpu_rxlen to 64 bytes already?
> +
> + skb_push(skb, RTL8_4_TAG_LEN);
> +
next prev parent reply other threads:[~2021-10-16 6:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 17:10 [PATCH v3 net-next 0/7] net: dsa: add support for RTL8365MB-VC Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 1/7] ether: add EtherType for proprietary Realtek protocols Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 2/7] net: dsa: allow reporting of standard ethtool stats for slave devices Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 3/7] net: dsa: move NET_DSA_TAG_RTL4_A to right place in Kconfig/Makefile Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 4/7] dt-bindings: net: dsa: realtek-smi: document new compatible rtl8365mb Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 5/7] net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tag Alvin Šipraga
2021-10-16 6:04 ` DENG Qingfang [this message]
2021-10-18 7:58 ` Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 6/7] net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC Alvin Šipraga
2021-10-16 0:40 ` Jakub Kicinski
2021-10-16 10:39 ` Alvin Šipraga
2021-10-16 22:32 ` Linus Walleij
2021-10-15 17:10 ` [PATCH v3 net-next 7/7] net: phy: realtek: add support for RTL8365MB-VC internal PHYs Alvin Šipraga
2021-10-16 9:13 ` [PATCH v3 net-next 0/7] net: dsa: add support for RTL8365MB-VC Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016060429.783447-1-dqfext@gmail.com \
--to=dqfext@gmail.com \
--cc=alsi@bang-olufsen.dk \
--cc=alvin@pqrs.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).