From: Jonathan Cameron <jic23@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Jander <david@protonic.nl>,
Robin van der Gracht <robin@protonic.nl>,
linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH v2 1/2] iio: adc: tsc2046: fix scan interval warning
Date: Sun, 17 Oct 2021 17:24:35 +0100 [thread overview]
Message-ID: <20211017172435.791cd280@jic23-huawei> (raw)
In-Reply-To: <20211007093007.1466-2-o.rempel@pengutronix.de>
On Thu, 7 Oct 2021 11:30:06 +0200
Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> Sync if statement with the actual warning.
>
> Fixes: 9504db5765e8 ("iio: adc: tsc2046: fix a warning message in tsc2046_adc_update_scan_mode()")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Applied this one to the fixes-togreg branch of iio.git and marked it for stable.
Thanks,
Jonathan
> ---
> drivers/iio/adc/ti-tsc2046.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c
> index 170950d5dd49..d84ae6b008c1 100644
> --- a/drivers/iio/adc/ti-tsc2046.c
> +++ b/drivers/iio/adc/ti-tsc2046.c
> @@ -398,7 +398,7 @@ static int tsc2046_adc_update_scan_mode(struct iio_dev *indio_dev,
> priv->xfer.len = size;
> priv->time_per_scan_us = size * 8 * priv->time_per_bit_ns / NSEC_PER_USEC;
>
> - if (priv->scan_interval_us > priv->time_per_scan_us)
> + if (priv->scan_interval_us < priv->time_per_scan_us)
> dev_warn(&priv->spi->dev, "The scan interval (%d) is less then calculated scan time (%d)\n",
> priv->scan_interval_us, priv->time_per_scan_us);
>
next prev parent reply other threads:[~2021-10-17 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 9:30 [PATCH v2 0/2] iio: adc: tsc2046: fixes Oleksij Rempel
2021-10-07 9:30 ` [PATCH v2 1/2] iio: adc: tsc2046: fix scan interval warning Oleksij Rempel
2021-10-17 16:24 ` Jonathan Cameron [this message]
2021-10-07 9:30 ` [PATCH v2 2/2] iio: adc: tsc2046: fix sleeping in atomic context warning and a deadlock after iio_trigger_poll() call Oleksij Rempel
2021-10-17 17:13 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211017172435.791cd280@jic23-huawei \
--to=jic23@kernel.org \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox