From: Drew Fustini <dfustini@baylibre.com>
To: Dave Gerlach <d-gerlach@ti.com>, Keerthy <j-keerthy@ti.com>,
Johan Hovold <johan@kernel.org>,
Jason Kridner <jkridner@beagleboard.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Drew Fustini <dfustini@baylibre.com>
Subject: [PATCH 0/2] ARM: dts: am335x: add rtc system-power-controller
Date: Mon, 18 Oct 2021 15:00:18 -0700 [thread overview]
Message-ID: <20211018220018.1514652-1-dfustini@baylibre.com> (raw)
Johan pointed out when I submitted "ARM: dts: am335x: Add rtc node as
system-power-controller" [1] that mentioning am335x-evm and boneblack
in the commit message was incorrect. system-power-controller is already
present in am335x-boneblack-common.dtsi and am335x-evm would need the
property added directly to the dts file.
These are the dts files that currently include either
am335x-bone-common.dtsi or am335x-boneblack-common.dtsi:
am335x-bone.dts
am335x-bone-common.dtsi
am335x-boneblack.dts
am335x-bone-common.dtsi
am335x-boneblack-common.dtsi
am335x-boneblack-wireless.dts
am335x-bone-common.dtsi
am335x-boneblack-common.dtsi
am335x-bonegreen.dts
am335x-bone-common.dtsi
am335x-bonegreen-wireless.dts
am335x-bone-common.dtsi
am335x-sancloud-bbe.dts
am335x-bone-common.dtsi
am335x-boneblack-common.dtsi
am335x-sancloud-bbe-lite.dts
am335x-bone-common.dtsi
am335x-boneblack-common.dtsi
am335x-boneblack, am335x-boneblack-wireless, am335x-sancloud-bbe and
am335x-sancloud-bbe-lite currently get the system-power-controller
property from am335x-boneblack-common.dtsi. Moving that property to
am335x-bone-common.dtsi would have no change for these boards as they
include that dtsi file too.
This change would result in the addition of system-power-controller
to bone, bonegreen and bonegreen-wireless. These boards all have
PMIC_POWR_EN (ZCZ ball C6) connected to PWR_EN on the TPS65217B PMIC.
Thus system-power-controller is a valid property for them too.
In addition to BeagleBone, I have reviewed the TI AM335x eval boards:
am335x-evm.dts should _not_ have the system-power-controller property as
the PMIC_POWER_EN is not connected on the TMDXEVM3358 board [2]. The
ball would be connected to SLEEP (pin 37) on the TPS65910A3 PMIC but R65
is marked as do not populate.
am335x-evmsk.dts should _not_ have system-power-controller property as
PMIC_POWER_EN is not connected on the TMDSSK3358 board [3].
am335x-icev2.dts should have the system-power-controller property as the
PMIC_POWER_EN (ZCZ ball C6) is connected to PWRHOLD (pin 1) of the
TPS65910A3 PMIC on the TMDSICE3359 board [4].
Cc: Jason Kridner <jkridner@beagleboard.org>
Cc: Dave Gerlach <d-gerlach@ti.com>
Cc: Keerthy <j-keerthy@ti.com>
Cc: Johan Hovold <johan@kernel.org>
[1] https://lore.kernel.org/linux-omap/20211012191311.879838-1-dfustini@baylibre.com/
[2] https://www.ti.com/tool/TMDXEVM3358
[3] https://www.ti.com/tool/TMDSSK3358
[4] https://www.ti.com/tool/TMDSICE3359
Drew Fustini (2):
ARM: dts: am335x-boneblack-common: move system-power-controller
ARM: dts: am335x-icev2: Add system-power-controller to RTC node
arch/arm/boot/dts/am335x-bone-common.dtsi | 1 +
arch/arm/boot/dts/am335x-boneblack-common.dtsi | 4 ----
arch/arm/boot/dts/am335x-icev2.dts | 4 ++++
3 files changed, 5 insertions(+), 4 deletions(-)
--
2.27.0
next reply other threads:[~2021-10-18 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 22:00 Drew Fustini [this message]
2021-10-18 22:00 ` [PATCH 1/2] ARM: dts: am335x-boneblack-common: move system-power-controller Drew Fustini
2021-10-18 22:00 ` [PATCH 2/2] ARM: dts: am335x-icev2: Add system-power-controller to RTC node Drew Fustini
2021-10-19 12:57 ` [PATCH 0/2] ARM: dts: am335x: add rtc system-power-controller Johan Hovold
2021-12-09 7:40 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2021-10-18 21:50 Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018220018.1514652-1-dfustini@baylibre.com \
--to=dfustini@baylibre.com \
--cc=bcousson@baylibre.com \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=jkridner@beagleboard.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).