From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: Robin van der Gracht <robin@protonic.nl>,
Rob Herring <robh+dt@kernel.org>,
Paul Burton <paulburton@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pavel Machek <pavel@ucw.cz>, Marek Behun <marek.behun@nic.cz>,
devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH v8 10/21] auxdisplay: ht16k33: Fix frame buffer device blanking
Date: Tue, 19 Oct 2021 16:45:09 +0200 [thread overview]
Message-ID: <20211019144520.3613926-11-geert@linux-m68k.org> (raw)
In-Reply-To: <20211019144520.3613926-1-geert@linux-m68k.org>
As the ht16k33 frame buffer sub-driver does not register an
fb_ops.fb_blank() handler, blanking does not work:
$ echo 1 > /sys/class/graphics/fb0/blank
sh: write error: Invalid argument
Fix this by providing a handler that always returns zero, to make sure
blank events will be sent to the actual device handling the backlight.
Reported-by: Robin van der Gracht <robin@protonic.nl>
Suggested-by: Robin van der Gracht <robin@protonic.nl>
Fixes: 8992da44c6805d53 ("auxdisplay: ht16k33: Driver for LED controller")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
v8:
- No changes,
v7:
- New.
---
drivers/auxdisplay/ht16k33.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index 2b630e194570f6e5..ed5808349990782c 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -219,6 +219,15 @@ static const struct backlight_ops ht16k33_bl_ops = {
.check_fb = ht16k33_bl_check_fb,
};
+/*
+ * Blank events will be passed to the actual device handling the backlight when
+ * we return zero here.
+ */
+static int ht16k33_blank(int blank, struct fb_info *info)
+{
+ return 0;
+}
+
static int ht16k33_mmap(struct fb_info *info, struct vm_area_struct *vma)
{
struct ht16k33_priv *priv = info->par;
@@ -231,6 +240,7 @@ static const struct fb_ops ht16k33_fb_ops = {
.owner = THIS_MODULE,
.fb_read = fb_sys_read,
.fb_write = fb_sys_write,
+ .fb_blank = ht16k33_blank,
.fb_fillrect = sys_fillrect,
.fb_copyarea = sys_copyarea,
.fb_imageblit = sys_imageblit,
--
2.25.1
next prev parent reply other threads:[~2021-10-19 14:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 14:44 [PATCH v8 00/21] auxdisplay: ht16k33: Add character display support Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 01/21] uapi: Add <linux/map_to_14segment.h> Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 02/21] dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 03/21] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string Geert Uytterhoeven
2021-10-19 20:50 ` Miguel Ojeda
2021-10-19 21:09 ` Miguel Ojeda
2021-10-20 8:27 ` Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 04/21] auxdisplay: img-ascii-lcd: Add helper variable dev Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 05/21] auxdisplay: img-ascii-lcd: Convert device attribute to sysfs_emit() Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 06/21] auxdisplay: Extract character line display core support Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 07/21] auxdisplay: linedisp: Use kmemdup_nul() helper Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 08/21] auxdisplay: linedisp: Add support for changing scroll rate Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 09/21] auxdisplay: ht16k33: Connect backlight to fbdev Geert Uytterhoeven
2021-10-19 14:45 ` Geert Uytterhoeven [this message]
2021-10-19 14:45 ` [PATCH v8 11/21] auxdisplay: ht16k33: Use HT16K33_FB_SIZE in ht16k33_initialize() Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 12/21] auxdisplay: ht16k33: Remove unneeded error check in keypad probe() Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 13/21] auxdisplay: ht16k33: Convert to simple i2c probe function Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 14/21] auxdisplay: ht16k33: Add helper variable dev Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 15/21] auxdisplay: ht16k33: Move delayed work Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 16/21] auxdisplay: ht16k33: Extract ht16k33_brightness_set() Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 17/21] auxdisplay: ht16k33: Extract frame buffer probing Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 18/21] auxdisplay: ht16k33: Add support for segment displays Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 19/21] dt-bindings: auxdisplay: ht16k33: Document LED subnode Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 20/21] auxdisplay: ht16k33: Add LED support Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 21/21] auxdisplay: ht16k33: Make use of device properties Geert Uytterhoeven
2021-10-19 16:44 ` [PATCH v8 00/21] auxdisplay: ht16k33: Add character display support Miguel Ojeda
2021-10-21 21:57 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211019144520.3613926-11-geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=ojeda@kernel.org \
--cc=paulburton@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).