* [PATCH] ARM: dts: at91: sama5d2_xplained: remove PA11__SDMMC0_VDDSEL from pinctrl
@ 2021-10-26 13:20 Eugen Hristev
2021-12-08 11:22 ` Nicolas Ferre
0 siblings, 1 reply; 4+ messages in thread
From: Eugen Hristev @ 2021-10-26 13:20 UTC (permalink / raw)
To: nicolas.ferre, devicetree
Cc: alexandre.belloni, ludovic.desroches, eugen.hristev,
linux-arm-kernel, linux-kernel, Mihai Sain
From: Mihai Sain <mihai.sain@microchip.com>
I/O voltage for eMMC is always 3.3V because PA11__SDMMC0_VDDSEL is
tied with 10K resistor to GND. U13 switch S1 is always selected as
voltage rail of 3.3V for VCCQ power pin from MPU controller and eMMC flash.
Removing PA11 from pinctrl because it remains unused.
Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
---
arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
index b1e854f658de..9bf2ec0ba3e2 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
@@ -66,7 +66,7 @@ sdmmc0: sdio-host@a0000000 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_sdmmc0_default>;
non-removable;
- mmc-ddr-1_8v;
+ mmc-ddr-3_3v;
status = "okay";
};
@@ -619,10 +619,9 @@ cmd_data {
bias-disable;
};
- ck_cd_rstn_vddsel {
+ ck_cd_rstn {
pinmux = <PIN_PA0__SDMMC0_CK>,
<PIN_PA10__SDMMC0_RSTN>,
- <PIN_PA11__SDMMC0_VDDSEL>,
<PIN_PA13__SDMMC0_CD>;
bias-disable;
};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: at91: sama5d2_xplained: remove PA11__SDMMC0_VDDSEL from pinctrl
2021-10-26 13:20 [PATCH] ARM: dts: at91: sama5d2_xplained: remove PA11__SDMMC0_VDDSEL from pinctrl Eugen Hristev
@ 2021-12-08 11:22 ` Nicolas Ferre
2021-12-08 11:27 ` Eugen.Hristev
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Ferre @ 2021-12-08 11:22 UTC (permalink / raw)
To: Eugen Hristev, devicetree
Cc: alexandre.belloni, ludovic.desroches, linux-arm-kernel,
linux-kernel, Mihai Sain
On 26/10/2021 at 15:20, Eugen Hristev wrote:
> From: Mihai Sain <mihai.sain@microchip.com>
>
> I/O voltage for eMMC is always 3.3V because PA11__SDMMC0_VDDSEL is
> tied with 10K resistor to GND. U13 switch S1 is always selected as
> voltage rail of 3.3V for VCCQ power pin from MPU controller and eMMC flash.
> Removing PA11 from pinctrl because it remains unused.
>
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks, best regards,
Nicolas
> ---
> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index b1e854f658de..9bf2ec0ba3e2 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -66,7 +66,7 @@ sdmmc0: sdio-host@a0000000 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_sdmmc0_default>;
> non-removable;
> - mmc-ddr-1_8v;
> + mmc-ddr-3_3v;
> status = "okay";
> };
>
> @@ -619,10 +619,9 @@ cmd_data {
> bias-disable;
> };
>
> - ck_cd_rstn_vddsel {
> + ck_cd_rstn {
> pinmux = <PIN_PA0__SDMMC0_CK>,
> <PIN_PA10__SDMMC0_RSTN>,
> - <PIN_PA11__SDMMC0_VDDSEL>,
> <PIN_PA13__SDMMC0_CD>;
> bias-disable;
> };
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: at91: sama5d2_xplained: remove PA11__SDMMC0_VDDSEL from pinctrl
2021-12-08 11:22 ` Nicolas Ferre
@ 2021-12-08 11:27 ` Eugen.Hristev
2021-12-08 13:06 ` Nicolas Ferre
0 siblings, 1 reply; 4+ messages in thread
From: Eugen.Hristev @ 2021-12-08 11:27 UTC (permalink / raw)
To: Nicolas.Ferre, devicetree
Cc: alexandre.belloni, Ludovic.Desroches, linux-arm-kernel,
linux-kernel, Mihai.Sain
On 12/8/21 1:22 PM, Nicolas Ferre wrote:
> On 26/10/2021 at 15:20, Eugen Hristev wrote:
>> From: Mihai Sain <mihai.sain@microchip.com>
>>
>> I/O voltage for eMMC is always 3.3V because PA11__SDMMC0_VDDSEL is
>> tied with 10K resistor to GND. U13 switch S1 is always selected as
>> voltage rail of 3.3V for VCCQ power pin from MPU controller and eMMC
>> flash.
>> Removing PA11 from pinctrl because it remains unused.
>>
>> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
You can also add my
Reviewed-by: Eugen Hristev <eugen.hristev@microchip.com>
and also
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
because I sent the patch.
>
> Thanks, best regards,
> Nicolas
>
>> ---
>> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> index b1e854f658de..9bf2ec0ba3e2 100644
>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> @@ -66,7 +66,7 @@ sdmmc0: sdio-host@a0000000 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_sdmmc0_default>;
>> non-removable;
>> - mmc-ddr-1_8v;
>> + mmc-ddr-3_3v;
>> status = "okay";
>> };
>> @@ -619,10 +619,9 @@ cmd_data {
>> bias-disable;
>> };
>> - ck_cd_rstn_vddsel {
>> + ck_cd_rstn {
>> pinmux = <PIN_PA0__SDMMC0_CK>,
>> <PIN_PA10__SDMMC0_RSTN>,
>> - <PIN_PA11__SDMMC0_VDDSEL>,
>> <PIN_PA13__SDMMC0_CD>;
>> bias-disable;
>> };
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: at91: sama5d2_xplained: remove PA11__SDMMC0_VDDSEL from pinctrl
2021-12-08 11:27 ` Eugen.Hristev
@ 2021-12-08 13:06 ` Nicolas Ferre
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2021-12-08 13:06 UTC (permalink / raw)
To: Eugen Hristev - M18282, devicetree@vger.kernel.org
Cc: alexandre.belloni@bootlin.com, Ludovic Desroches - M43218,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Mihai Sain - M19926
On 08/12/2021 at 12:27, Eugen Hristev - M18282 wrote:
> On 12/8/21 1:22 PM, Nicolas Ferre wrote:
>> On 26/10/2021 at 15:20, Eugen Hristev wrote:
>>> From: Mihai Sain <mihai.sain@microchip.com>
>>>
>>> I/O voltage for eMMC is always 3.3V because PA11__SDMMC0_VDDSEL is
>>> tied with 10K resistor to GND. U13 switch S1 is always selected as
>>> voltage rail of 3.3V for VCCQ power pin from MPU controller and eMMC
>>> flash.
>>> Removing PA11 from pinctrl because it remains unused.
>>>
>>> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
>>
>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>
> You can also add my
> Reviewed-by: Eugen Hristev <eugen.hristev@microchip.com>
>
> and also
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> because I sent the patch.
Sure Eugen: Done. Best regards,
Nicolas
>>> ---
>>> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 ++---
>>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> index b1e854f658de..9bf2ec0ba3e2 100644
>>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> @@ -66,7 +66,7 @@ sdmmc0: sdio-host@a0000000 {
>>> pinctrl-names = "default";
>>> pinctrl-0 = <&pinctrl_sdmmc0_default>;
>>> non-removable;
>>> - mmc-ddr-1_8v;
>>> + mmc-ddr-3_3v;
>>> status = "okay";
>>> };
>>> @@ -619,10 +619,9 @@ cmd_data {
>>> bias-disable;
>>> };
>>> - ck_cd_rstn_vddsel {
>>> + ck_cd_rstn {
>>> pinmux = <PIN_PA0__SDMMC0_CK>,
>>> <PIN_PA10__SDMMC0_RSTN>,
>>> - <PIN_PA11__SDMMC0_VDDSEL>,
>>> <PIN_PA13__SDMMC0_CD>;
>>> bias-disable;
>>> };
>>>
>>
>>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-08 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-26 13:20 [PATCH] ARM: dts: at91: sama5d2_xplained: remove PA11__SDMMC0_VDDSEL from pinctrl Eugen Hristev
2021-12-08 11:22 ` Nicolas Ferre
2021-12-08 11:27 ` Eugen.Hristev
2021-12-08 13:06 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).