From: Florian Klink <flokli@flokli.de>
To: Dennis Gilmore <dgilmore@redhat.com>
Cc: linux-rockchip@lists.infradead.org,
"Rob Herring" <robh+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: helios64: define usb hub and 2.5GbE nic
Date: Thu, 28 Oct 2021 18:35:32 +0200 [thread overview]
Message-ID: <20211028163532.xhcvlxi4e2wuuisz@tp> (raw)
In-Reply-To: <20211026150751.70115-1-dgilmore@redhat.com>
On 21-10-26 10:07:47, Dennis Gilmore wrote:
>Add the 4 ports on the internal hub and define and turn on the 2.5GbE
>nic.
>
>Signed-off-by: Dennis Gilmore <dgilmore@redhat.com>
Tested-by: Florian Klink <flokli@flokli.de>
>---
> .../dts/rockchip/rk3399-kobol-helios64.dts | 55 +++++++++++++++++++
> 1 file changed, 55 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>index 26d45cf7ce00..1ffddf860375 100644
>--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>@@ -125,6 +125,18 @@ pcie_power: pcie-power {
> vin-supply = <&vcc5v0_perdev>;
> };
>
>+ usblan_power: usblan-power {
>+ compatible = "regulator-fixed";
>+ enable-active-high;
>+ gpio = <&gpio1 RK_PC7 GPIO_ACTIVE_HIGH>;
>+ pinctrl-names = "default";
>+ pinctrl-0 = <&usb_lan_en>;
>+ regulator-name = "usblan_power";
>+ regulator-always-on;
>+ regulator-boot-on;
>+ vin-supply = <&vcc5v0_usb>;
>+ };
>+
> vcc1v8_sys_s0: vcc1v8-sys-s0 {
> compatible = "regulator-fixed";
> regulator-name = "vcc1v8_sys_s0";
>@@ -465,6 +477,11 @@ hdd_b_power_en: hdd-b-power-en {
> vcc5v0_usb_en: vcc5v0-usb-en {
> rockchip,pins = <1 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
> };
>+
>+ usb_lan_en: usb-lan-en {
>+ rockchip,pins = <1 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
>+ };
>+
> };
>
> vcc3v0-sd {
>@@ -563,5 +580,43 @@ &usbdrd3_1 {
> usb@fe900000 {
> dr_mode = "host";
> status = "okay";
>+
>+ #address-cells = <1>;
>+ #size-cells = <0>;
>+
>+ hub@1 {
>+ compatible = "usb2109,0815";
>+ reg = <1>;
>+ #address-cells = <1>;
>+ #size-cells = <0>;
>+
>+ port@1 {
>+ reg = <1>;
>+ #trigger-source-cells = <0>;
>+ };
>+
>+ port@2 {
>+ reg = <2>;
>+ #trigger-source-cells = <0>;
>+ };
>+
>+ port@3 {
>+ reg = <3>;
>+ #trigger-source-cells = <0>;
>+ };
>+
>+ device@4 {
>+ compatible = "usbbda,8156";
>+ reg = <4>;
>+
>+ #address-cells = <2>;
>+ #size-cells = <0>;
>+
>+ interface@0 { /* interface 0 of configuration 1 */
>+ compatible = "usbbda,8156.config1.0";
>+ reg = <0 1>;
>+ };
>+ };
>+ };
> };
> };
>--
>2.32.0
next prev parent reply other threads:[~2021-10-28 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 15:07 [PATCH] arm64: dts: rockchip: helios64: define usb hub and 2.5GbE nic Dennis Gilmore
2021-10-28 16:35 ` Florian Klink [this message]
2021-11-21 17:50 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028163532.xhcvlxi4e2wuuisz@tp \
--to=flokli@flokli.de \
--cc=devicetree@vger.kernel.org \
--cc=dgilmore@redhat.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox