From: kernel test robot <lkp@intel.com>
To: Rob Herring <robh@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>
Subject: [PATCH] arm64: fix boolconv.cocci warnings
Date: Fri, 29 Oct 2021 23:33:52 +0800 [thread overview]
Message-ID: <20211029153352.GA69389@7705b72ac8e7> (raw)
In-Reply-To: <20211028183355.360731-1-robh@kernel.org>
From: kernel test robot <lkp@intel.com>
arch/arm64/kernel/acpi.c:71:26-31: WARNING: conversion to bool not needed here
Remove unneeded conversion to bool
Semantic patch information:
Relational and logical operators evaluate to bool,
explicit conversion is overly verbose and unneeded.
Generated by: scripts/coccinelle/misc/boolconv.cocci
CC: Rob Herring <robh@kernel.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Rob-Herring/arm64-Simplify-checking-for-populated-DT/20211029-023532
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
:::::: branch date: 21 hours ago
:::::: commit date: 21 hours ago
acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/arm64/kernel/acpi.c
+++ b/arch/arm64/kernel/acpi.c
@@ -68,7 +68,7 @@ static bool __init dt_is_populated(void)
const void *fdt = initial_boot_params;
int node = fdt_node_offset_by_compatible(fdt, -1, "arm,armv8-timer");
- return node > 0 ? true : false;
+ return node > 0;
}
/*
prev parent reply other threads:[~2021-10-29 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 18:33 [PATCH] arm64: Simplify checking for populated DT Rob Herring
2021-10-29 9:38 ` Mark Rutland
2021-10-29 14:20 ` Rob Herring
2021-10-29 15:33 ` kernel test robot
2021-10-29 15:33 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029153352.GA69389@7705b72ac8e7 \
--to=lkp@intel.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).