From: Corey Minyard <minyard@acm.org>
To: Rob Herring <robh@kernel.org>
Cc: jae.hyun.yoo@intel.com, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
openipmi-developer@lists.sourceforge.net,
linux-aspeed@lists.ozlabs.org,
Haiyue Wang <haiyue.wang@linux.intel.com>,
Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Cedric Le Goater <clg@kaod.org>,
ChiaWei Wang <chiawei_wang@aspeedtech.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH -next v2 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property
Date: Tue, 2 Nov 2021 20:52:27 -0500 [thread overview]
Message-ID: <20211103015227.GO4667@minyard.net> (raw)
In-Reply-To: <1635902437.654631.3880388.nullmailer@robh.at.kernel.org>
On Tue, Nov 02, 2021 at 08:20:37PM -0500, Rob Herring wrote:
> On Tue, 02 Nov 2021 13:37:16 -0700, jae.hyun.yoo@intel.com wrote:
> > From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> >
> > Add 'clocks' as a required property.
> >
> > Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> > ---
> > v1 -> v2:
> > Changes sinve v1:
> > - Added 'clocks' property into kcs-bmc bindings using
> > 'aspeed,ast2400-kcs-bmc.yaml' because it's not merged into
> > 'aspeed-lpc.yaml' yet. The bindings merging could be done using a
> > separate patch later.
> >
> > .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1549943
>
From the code, I think this change will break all these platforms, as
the initialization of kcs will fail without the clock property. I'm
going to pull this out until it gets sorted out.
Also, could you rebase on the latest kernel when submitting next time?
There was a minor thing I had to fix up.
-corey
>
> kcs@114: 'clocks' is a required property
> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml
>
> kcs@24: 'clocks' is a required property
> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml
>
> kcs@28: 'clocks' is a required property
> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml
>
> kcs@2c: 'clocks' is a required property
> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dt.yaml
> arch/arm/boot/dts/aspeed-bmc-inspur-nf5280m6.dt.yaml
>
next prev parent reply other threads:[~2021-11-03 1:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 20:37 [PATCH -next v2 0/6] Add LCLK control into Aspeed LPC sub drivers jae.hyun.yoo
2021-11-02 20:37 ` [PATCH -next v2 1/6] ARM: dts: aspeed: add LCLK setting into LPC IBT node jae.hyun.yoo
2021-11-02 20:37 ` [PATCH -next v2 2/6] dt-bindings: ipmi: bt-bmc: add 'clocks' as a required property jae.hyun.yoo
2021-11-02 20:37 ` [PATCH -next v2 3/6] ipmi: bt: add clock control logic jae.hyun.yoo
2021-11-02 20:37 ` [PATCH -next v2 4/6] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes jae.hyun.yoo
2021-11-02 20:37 ` [PATCH -next v2 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property jae.hyun.yoo
2021-11-03 1:20 ` Rob Herring
2021-11-03 1:52 ` Corey Minyard [this message]
2021-11-03 16:13 ` Jae Hyun Yoo
2021-11-03 16:08 ` Jae Hyun Yoo
2021-11-03 16:29 ` Rob Herring
2021-11-03 17:26 ` Jae Hyun Yoo
2021-11-03 22:45 ` Joel Stanley
2021-11-04 16:16 ` Jae Hyun Yoo
2021-11-02 20:37 ` [PATCH -next v2 6/6] ipmi: kcs_bmc_aspeed: add clock control logic jae.hyun.yoo
2021-11-03 0:59 ` [PATCH -next v2 0/6] Add LCLK control into Aspeed LPC sub drivers Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103015227.GO4667@minyard.net \
--to=minyard@acm.org \
--cc=andrew@aj.id.au \
--cc=chiawei_wang@aspeedtech.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=haiyue.wang@linux.intel.com \
--cc=jae.hyun.yoo@intel.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).