From: jae.hyun.yoo@intel.com
To: Rob Herring <robh+dt@kernel.org>, Corey Minyard <minyard@acm.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Cedric Le Goater <clg@kaod.org>,
Haiyue Wang <haiyue.wang@linux.intel.com>,
ChiaWei Wang <chiawei_wang@aspeedtech.com>,
Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
openipmi-developer@lists.sourceforge.net
Subject: [PATCH v3 0/6] Add LCLK control into Aspeed LPC sub drivers
Date: Mon, 8 Nov 2021 11:01:54 -0800 [thread overview]
Message-ID: <20211108190200.290957-1-jae.hyun.yoo@intel.com> (raw)
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Hello all,
This series is for appliying below fix to all Aspped LPC sub drivers.
https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
An LPC sub driver can be enabled without using the lpc-ctrl driver or it
can be registered ahead of lpc-ctrl depends on each system configuration and
this difference introduces that LPC can be enabled without heart beating of
LCLK so it causes improper handling on host interrupts when the host sends
interrupts in that time frame. Then kernel eventually forcibly disables the
interrupt with dumping stack and printing a 'nobody cared this irq' message
out.
To prevent this issue, all LPC sub drivers should enable LCLK individually
so this patch adds clock control logic into the remaining Aspeed LPC sub
drivers.
Please review this series.
Thanks,
Jae
Changes sinve v2:
* Rebased it on the latest master.
* Made dts and bindigs changes' commit message more descriptive.
* Simplified the -EPROBE_DEFER handling using dev_err_probe().
Changes sinve v1:
* Added 'clocks' property into ibt and kcs-bmc bindings using
'aspeed,ast2400-ibt-bmc.txt' and 'aspeed,ast2400-kcs-bmc.yaml'
respectively because these are not merged into 'aspeed-lpc.yaml' yet.
The bindings merging could be done using a separate patch later.
Jae Hyun Yoo (6):
ARM: dts: aspeed: add LCLK setting into LPC IBT node
dt-bindings: ipmi: bt-bmc: add 'clocks' as a required property
ipmi: bt: add clock control logic
ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property
ipmi: kcs_bmc_aspeed: add clock control logic
.../bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 2 ++
.../bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++
arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
arch/arm/boot/dts/aspeed-g5.dtsi | 5 ++++
arch/arm/boot/dts/aspeed-g6.dtsi | 5 ++++
drivers/char/ipmi/bt-bmc.c | 21 +++++++++++++-
drivers/char/ipmi/kcs_bmc_aspeed.c | 28 ++++++++++++++++---
7 files changed, 64 insertions(+), 5 deletions(-)
--
2.25.1
next reply other threads:[~2021-11-08 18:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 19:01 jae.hyun.yoo [this message]
2021-11-08 19:01 ` [PATCH v3 1/6] ARM: dts: aspeed: add LCLK setting into LPC IBT node jae.hyun.yoo
2021-11-08 19:01 ` [PATCH v3 2/6] dt-bindings: ipmi: bt-bmc: add 'clocks' as a required property jae.hyun.yoo
2021-11-19 1:07 ` Rob Herring
2021-11-08 19:01 ` [PATCH v3 3/6] ipmi: bt: add clock control logic jae.hyun.yoo
2021-11-08 19:01 ` [PATCH v3 4/6] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes jae.hyun.yoo
2021-11-08 19:01 ` [PATCH v3 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property jae.hyun.yoo
2021-11-19 1:08 ` Rob Herring
2021-11-08 19:02 ` [PATCH v3 6/6] ipmi: kcs_bmc_aspeed: add clock control logic jae.hyun.yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211108190200.290957-1-jae.hyun.yoo@intel.com \
--to=jae.hyun.yoo@intel.com \
--cc=andrew@aj.id.au \
--cc=chiawei_wang@aspeedtech.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=haiyue.wang@linux.intel.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).