devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Florian Eckert <fe@dev.tdt.de>
Cc: robh+dt@kernel.org, Eckert.Florian@googlemail.com,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] leds: Add KTD20xx RGB LEDs driver from Kinetic
Date: Wed, 10 Nov 2021 00:29:17 +0100	[thread overview]
Message-ID: <20211109232917.GA26764@amd> (raw)
In-Reply-To: <20211109100822.5412-1-fe@dev.tdt.de>

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

Hi!

> Introduce the KTD2061/58/59/60 RGB LEDs driver. The difference in these
> parts are the address number on the I2C bus the device is listen on.
> 
> All KT20xx device could control up to 12 LEDs. The chip can be operated
> in two variants.
> 
> Florian Eckert (2):
>   leds: ktd20xx: Add the KTD20xx family of the RGB LEDs driver from
>     Kinetic
>   dt: bindings: KTD20xx: Introduce the ktd20xx family of RGB drivers

That's... not a nice piece of hardware.

We'll want dt changes first, driver next please.

If this uses non-standard interface, it will need to be
documented. But I would like to understand the limitations first.

Do you have actual device where this is used?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2021-11-09 23:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 10:08 [PATCH 0/2] leds: Add KTD20xx RGB LEDs driver from Kinetic Florian Eckert
2021-11-09 10:08 ` [PATCH 1/2] leds: ktd20xx: Add the KTD20xx family of the " Florian Eckert
2021-11-09 23:29   ` Pavel Machek
2021-11-22 10:32   ` Dan Carpenter
2021-11-09 10:08 ` [PATCH 2/2] dt: bindings: KTD20xx: Introduce the ktd20xx family of RGB drivers Florian Eckert
2021-11-09 23:29 ` Pavel Machek [this message]
2021-11-10  9:35   ` [PATCH 0/2] leds: Add KTD20xx RGB LEDs driver from Kinetic Florian Eckert
2021-11-22  7:17   ` Florian Eckert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211109232917.GA26764@amd \
    --to=pavel@ucw.cz \
    --cc=Eckert.Florian@googlemail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fe@dev.tdt.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).