* [PATCH v4 0/1] Mediatek pinctrl patch
@ 2021-11-10 7:18 Zhiyong Tao
2021-11-10 7:19 ` [PATCH v4] pinctrl: mediatek: fix global-out-of-bounds issue Zhiyong Tao
0 siblings, 1 reply; 3+ messages in thread
From: Zhiyong Tao @ 2021-11-10 7:18 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, light.hsieh, sean.wang,
seiya.wang, rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio
This series includes 1 patches:
1. fix global-out-of-bounds issue.
Changes in patch v4:
1. fix sort signed-off-by name.
2. add Reviewed-by.
Changes in patch v3:
1. keep original patch author
2. fix version issue.
Changes in patch v2:
1. change check eint number boundary condition.
Guodong Liu (1):
pinctrl: mediatek: fix global-out-of-bounds issue
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v4] pinctrl: mediatek: fix global-out-of-bounds issue
2021-11-10 7:18 [PATCH v4 0/1] Mediatek pinctrl patch Zhiyong Tao
@ 2021-11-10 7:19 ` Zhiyong Tao
2021-11-21 22:52 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Zhiyong Tao @ 2021-11-10 7:19 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, light.hsieh, sean.wang,
seiya.wang, rex-bc.chen, guodong.liu, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio, Guodong Liu,
Chen-Yu Tsai
From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
When eint virtual eint number is greater than gpio number,
it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
---
Changes in patch v4:
1. fix sort signed-off-by name.
2. add Reviewed-by.
Changes in patch v3:
1. keep original patch author
2. fix version issue.
Changes in patch v2:
1. change check eint number boundary condition.
---
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index 45ebdeba985a..12163d3c4bcb 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
desc = (const struct mtk_pin_desc *)hw->soc->pins;
*gpio_chip = &hw->chip;
- /* Be greedy to guess first gpio_n is equal to eint_n */
- if (desc[eint_n].eint.eint_n == eint_n)
+ /*
+ * Be greedy to guess first gpio_n is equal to eint_n.
+ * Only eint virtual eint number is greater than gpio number.
+ */
+ if (hw->soc->npins > eint_n &&
+ desc[eint_n].eint.eint_n == eint_n)
*gpio_n = eint_n;
else
*gpio_n = mtk_xt_find_eint_num(hw, eint_n);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4] pinctrl: mediatek: fix global-out-of-bounds issue
2021-11-10 7:19 ` [PATCH v4] pinctrl: mediatek: fix global-out-of-bounds issue Zhiyong Tao
@ 2021-11-21 22:52 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-11-21 22:52 UTC (permalink / raw)
To: Zhiyong Tao
Cc: robh+dt, mark.rutland, matthias.bgg, sean.wang, srv_heupstream,
hui.liu, light.hsieh, sean.wang, seiya.wang, rex-bc.chen,
guodong.liu, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-gpio, Guodong Liu, Chen-Yu Tsai
On Wed, Nov 10, 2021 at 8:19 AM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
> From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
>
> When eint virtual eint number is greater than gpio number,
> it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
>
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> Changes in patch v4:
> 1. fix sort signed-off-by name.
> 2. add Reviewed-by.
Patch applied for fixes!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-21 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-10 7:18 [PATCH v4 0/1] Mediatek pinctrl patch Zhiyong Tao
2021-11-10 7:19 ` [PATCH v4] pinctrl: mediatek: fix global-out-of-bounds issue Zhiyong Tao
2021-11-21 22:52 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).