From: Shawn Guo <shawn.guo@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Georgi Djakov <djakov@kernel.org>
Subject: Re: [PATCH 5/6] dt-bindings: interconnect: Add Qualcomm QCM2290 NoC support
Date: Thu, 11 Nov 2021 17:18:56 +0800 [thread overview]
Message-ID: <20211111091855.GK7231@dragon> (raw)
In-Reply-To: <1636573460.901134.1783738.nullmailer@robh.at.kernel.org>
On Wed, Nov 10, 2021 at 01:44:20PM -0600, Rob Herring wrote:
> On Wed, 10 Nov 2021 20:07:15 +0800, Shawn Guo wrote:
> > Add bindings for Qualcomm QCM2290 Network-On-Chip interconnect devices.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > ---
> > .../bindings/interconnect/qcom,qcm2290.yaml | 117 ++++++++++++++++++
> > .../dt-bindings/interconnect/qcom,qcm2290.h | 94 ++++++++++++++
> > 2 files changed, 211 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml
> > create mode 100644 include/dt-bindings/interconnect/qcom,qcm2290.h
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/interconnect/qcom,qcm2290.example.dts:20:18: fatal error: dt-bindings/clock/qcom,gcc-qcm2290.h: No such file or directory
> 20 | #include <dt-bindings/clock/qcom,gcc-qcm2290.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Thanks for the report!
The header has just landed on mainline tree. But the binding actually
doesn't need to include it. I will drop it for the next posting.
Shawn
next prev parent reply other threads:[~2021-11-11 9:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 12:07 [PATCH 0/6] Add QCM2290 interconnect support Shawn Guo
2021-11-10 12:07 ` [PATCH 1/6] interconnect: icc-rpm: Use NOC_QOS_MODE_INVALID for qos_mode check Shawn Guo
2021-11-10 12:07 ` [PATCH 2/6] interconnect: icc-rpm: Define ICC device type Shawn Guo
2021-11-10 12:07 ` [PATCH 3/6] interconnect: icc-rpm: Add QNOC type QoS support Shawn Guo
2021-11-10 12:07 ` [PATCH 4/6] interconnect: icc-rpm: Support child NoC device probe Shawn Guo
2021-11-10 12:07 ` [PATCH 5/6] dt-bindings: interconnect: Add Qualcomm QCM2290 NoC support Shawn Guo
2021-11-10 19:44 ` Rob Herring
2021-11-11 9:18 ` Shawn Guo [this message]
2021-11-10 12:07 ` [PATCH 6/6] interconnect: qcom: Add QCM2290 driver support Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211111091855.GK7231@dragon \
--to=shawn.guo@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).