From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: <robh+dt@kernel.org>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] iio: add filter subfolder
Date: Fri, 12 Nov 2021 17:44:06 +0000 [thread overview]
Message-ID: <20211112174406.7915970e@jic23-huawei> (raw)
In-Reply-To: <20211112173621.0ce23ef3@jic23-huawei>
On Fri, 12 Nov 2021 17:36:21 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 9 Nov 2021 14:31:24 +0200
> Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
>
> > Add filter subfolder for IIO devices that handle filter functionality.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
>
> Hi Antoniu,
>
> Are we likely to see many filter drivers? If not we could classify them
> as analog front ends and put them in the AFE directory?
On actually reading what device was I'm fine with filters directory.
AFE is more appropriate if we are talking about a front end for something
we are going to feed to an ADC rather that filtering a microwave frequency signal.
Jonathan
>
> If there are going to be lots then I'm fine with a new directory.
>
> Jonathan
>
> > ---
> > drivers/iio/Kconfig | 1 +
> > drivers/iio/Makefile | 1 +
> > drivers/iio/filter/Kconfig | 8 ++++++++
> > drivers/iio/filter/Makefile | 6 ++++++
> > 4 files changed, 16 insertions(+)
> > create mode 100644 drivers/iio/filter/Kconfig
> > create mode 100644 drivers/iio/filter/Makefile
> >
> > diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig
> > index 2334ad249b46..3a496a28bad4 100644
> > --- a/drivers/iio/Kconfig
> > +++ b/drivers/iio/Kconfig
> > @@ -77,6 +77,7 @@ source "drivers/iio/chemical/Kconfig"
> > source "drivers/iio/common/Kconfig"
> > source "drivers/iio/dac/Kconfig"
> > source "drivers/iio/dummy/Kconfig"
> > +source "drivers/iio/filter/Kconfig"
> > source "drivers/iio/frequency/Kconfig"
> > source "drivers/iio/gyro/Kconfig"
> > source "drivers/iio/health/Kconfig"
> > diff --git a/drivers/iio/Makefile b/drivers/iio/Makefile
> > index 65e39bd4f934..97d2fbcf0950 100644
> > --- a/drivers/iio/Makefile
> > +++ b/drivers/iio/Makefile
> > @@ -24,6 +24,7 @@ obj-y += common/
> > obj-y += dac/
> > obj-y += dummy/
> > obj-y += gyro/
> > +obj-y += filter/
> > obj-y += frequency/
> > obj-y += health/
> > obj-y += humidity/
> > diff --git a/drivers/iio/filter/Kconfig b/drivers/iio/filter/Kconfig
> > new file mode 100644
> > index 000000000000..e268bba43852
> > --- /dev/null
> > +++ b/drivers/iio/filter/Kconfig
> > @@ -0,0 +1,8 @@
> > +#
> > +# Filter drivers
> > +#
> > +# When adding new entries keep the list in alphabetical order
> > +
> > +menu "Filters"
> > +
> > +endmenu
> > diff --git a/drivers/iio/filter/Makefile b/drivers/iio/filter/Makefile
> > new file mode 100644
> > index 000000000000..cc0892c01142
> > --- /dev/null
> > +++ b/drivers/iio/filter/Makefile
> > @@ -0,0 +1,6 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +#
> > +# Makefile for industrial I/O Filter drivers
> > +#
> > +
> > +# When adding new entries keep the list in alphabetical order
>
next prev parent reply other threads:[~2021-11-12 17:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 12:31 [PATCH 0/4] Add support for ADMV8818 Antoniu Miclaus
2021-11-09 12:31 ` [PATCH 1/4] iio: add filter subfolder Antoniu Miclaus
2021-11-12 17:36 ` Jonathan Cameron
2021-11-12 17:44 ` Jonathan Cameron [this message]
2021-11-09 12:31 ` [PATCH 2/4] iio:filter:admv8818: add support for ADMV8818 Antoniu Miclaus
2021-11-12 18:06 ` Jonathan Cameron
2021-11-09 12:31 ` [PATCH 3/4] dt-bindings:iio:filter: add admv8818 doc Antoniu Miclaus
2021-11-10 1:07 ` Rob Herring
2021-11-10 9:39 ` Miclaus, Antoniu
2021-11-12 17:46 ` Jonathan Cameron
2021-11-16 14:43 ` Miclaus, Antoniu
2021-11-21 12:24 ` Jonathan Cameron
2021-11-09 12:31 ` [PATCH 4/4] iio:filter:admv8818: Add sysfs ABI documentation Antoniu Miclaus
2021-11-12 17:56 ` Jonathan Cameron
2021-11-12 18:05 ` Jonathan Cameron
2021-11-16 14:43 ` Miclaus, Antoniu
2021-11-21 12:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112174406.7915970e@jic23-huawei \
--to=jic23@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).