[PATCH v1 0/2] Support Sharp LQ101R1SX03 display panel

[PATCH v1 0/2] Support Sharp LQ101R1SX03 display panel

[Dmitry Osipenko]

Add support for Sharp LQ101R1SX03 display panel used by ASUS Transformer
TF701T tablet device.

Anton Bambura (2):
  dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03
  drm/panel: sharp: lq101r1sx01: Support LQ101R1SX03

 .../devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml  | 4 +++-
 drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c               | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.33.1

[PATCH v1 1/2] dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03

[Dmitry Osipenko]

From: Anton Bambura <jenneron@protonmail.com>

LQ101R1SX03 is compatible with LQ101R1SX01, document it.

Signed-off-by: Anton Bambura <jenneron@protonmail.com>
---
 .../devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml b/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml
index a679d3647dbd..f7514eb9ebda 100644
--- a/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml
@@ -30,7 +30,9 @@ allOf:
 
 properties:
   compatible:
-    const: sharp,lq101r1sx01
+    enum:
+      - sharp,lq101r1sx01
+      - sharp,lq101r1sx03
 
   reg: true
   power-supply: true
-- 
2.33.1

Re: [PATCH v1 1/2] dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03

[Rob Herring]

On Sun, Nov 14, 2021 at 11:07:16PM +0300, Dmitry Osipenko wrote:
> From: Anton Bambura <jenneron@protonmail.com>
> 
> LQ101R1SX03 is compatible with LQ101R1SX01, document it.

Then sounds like '"sharp,lq101r1sx03", "sharp,lq101r1sx01"' would be the 
appropriate compatible value. Do that, and you don't need a driver 
change.

> 
> Signed-off-by: Anton Bambura <jenneron@protonmail.com>
> ---
>  .../devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml  | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml b/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml
> index a679d3647dbd..f7514eb9ebda 100644
> --- a/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml
> @@ -30,7 +30,9 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: sharp,lq101r1sx01
> +    enum:
> +      - sharp,lq101r1sx01
> +      - sharp,lq101r1sx03
>  
>    reg: true
>    power-supply: true
> -- 
> 2.33.1
> 
> 

Re: [PATCH v1 1/2] dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03

[Dmitry Osipenko]

30.11.2021 00:32, Rob Herring пишет:
> On Sun, Nov 14, 2021 at 11:07:16PM +0300, Dmitry Osipenko wrote:
>> From: Anton Bambura <jenneron@protonmail.com>
>>
>> LQ101R1SX03 is compatible with LQ101R1SX01, document it.
> 
> Then sounds like '"sharp,lq101r1sx03", "sharp,lq101r1sx01"' would be the 
> appropriate compatible value. Do that, and you don't need a driver 
> change.

Apparently you're right. The "sharp,lq101r1sx03" should be a slightly
improved revision of "sharp,lq101r1sx01". I see now that LQ101R1SX03 is
sold as a spare part panel for ASUS TF701T, hence these panels should be
entirely compatible with each other.

Re: [PATCH v1 1/2] dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03

[Dmitry Osipenko]

30.11.2021 18:54, Dmitry Osipenko пишет:
> 30.11.2021 00:32, Rob Herring пишет:
>> On Sun, Nov 14, 2021 at 11:07:16PM +0300, Dmitry Osipenko wrote:
>>> From: Anton Bambura <jenneron@protonmail.com>
>>>
>>> LQ101R1SX03 is compatible with LQ101R1SX01, document it.
>>
>> Then sounds like '"sharp,lq101r1sx03", "sharp,lq101r1sx01"' would be the 
>> appropriate compatible value. Do that, and you don't need a driver 
>> change.
> 
> Apparently you're right. The "sharp,lq101r1sx03" should be a slightly
> improved revision of "sharp,lq101r1sx01". I see now that LQ101R1SX03 is
> sold as a spare part panel for ASUS TF701T, hence these panels should be
> entirely compatible with each other.
> 

I mixed up the panel model which TF701T uses.

I compared datasheets of both panel variants. These panel have
differences in the pins configuration. Hence panels seems aren't
compatible in terms of hardware integration, although the difference is
small. They should be compatible from software perspective.

[PATCH v1 2/2] drm/panel: sharp: lq101r1sx01: Support LQ101R1SX03

[Dmitry Osipenko]

From: Anton Bambura <jenneron@protonmail.com>

LQ101R1SX03 is compatible with LQ101R1SX01, add compatible to the driver.

Signed-off-by: Anton Bambura <jenneron@protonmail.com>
---
 drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c b/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
index f8cd2a42ed13..bbd1d889e069 100644
--- a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
+++ b/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
@@ -304,6 +304,7 @@ static const struct drm_panel_funcs sharp_panel_funcs = {
 
 static const struct of_device_id sharp_of_match[] = {
 	{ .compatible = "sharp,lq101r1sx01", },
+	{ .compatible = "sharp,lq101r1sx03", },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, sharp_of_match);
-- 
2.33.1